From: Markus Armbruster <armbru@redhat.com>
To: Hanna Czenczek <hreitz@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>,
"Denis V . Lunev" <den@openvz.org>,
Eric Blake <eblake@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 06/12] qapi/block: Add BLOCK_IO_DELAY event
Date: Mon, 26 Oct 2026 07:28:40 +0100 [thread overview]
Message-ID: <87jyn56kmf.fsf@pond.sub.org> (raw)
In-Reply-To: <44691c04-0bd0-48de-afc5-56f2cddd5662@redhat.com> (Hanna Czenczek's message of "Fri, 23 Oct 2026 16:33:45 +0200")
Hanna Czenczek <hreitz@redhat.com> writes:
> On 23.10.26 08:14, Markus Armbruster wrote:
[...]
>> In sane usage, @delay-report-ns < @delay-stop-ns. Correct?
>
> Well, uh, I suppose. The opposite could be imagined, but if someone wants that, that might rather indicate they would really want an array of thresholds rather than a single one, so… As long as we just have a single reporting threshold, `@delay-report-ns < @delay-stop-ns` is the sane usage, yes.
Three options, I think:
1. Make @delay-stop-ns < @delay-stop-ns an error.
2. Advice users that @delay-stop-ns < @delay-stop-ns probably makes no
sense.
3. Nothing, because we trust users they can figure this out themselves.
Entirely up to you!
[...]
next prev parent reply other threads:[~2026-10-26 6:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 18:20 [PATCH v2 00/12] block: BLOCK_IO_DELAY event Hanna Czenczek
2026-10-19 18:20 ` [PATCH v2 01/12] qapi/common: Clarify what IoOperationType is for Hanna Czenczek
2026-10-20 5:58 ` Markus Armbruster
2026-10-22 13:54 ` Hanna Czenczek
2026-10-19 18:20 ` [PATCH v2 02/12] qapi/block: Add IoAccountingOperation enum Hanna Czenczek
2026-10-20 5:59 ` Markus Armbruster
2026-10-22 15:48 ` Hanna Czenczek
2026-10-23 6:04 ` Markus Armbruster
2026-10-23 14:30 ` Hanna Czenczek
2026-10-26 6:24 ` Markus Armbruster
2026-10-19 18:20 ` [PATCH v2 03/12] runstate: Allow IO_ERROR/SUSPENDED transitions Hanna Czenczek
2026-10-19 18:20 ` [PATCH v2 04/12] iotests: PC-only test for I/O errors during suspend Hanna Czenczek
2026-10-19 18:20 ` [PATCH v2 05/12] qapi/run-state: Add io-hang state Hanna Czenczek
2026-10-20 6:02 ` Markus Armbruster
2026-10-19 18:20 ` [PATCH v2 06/12] qapi/block: Add BLOCK_IO_DELAY event Hanna Czenczek
2026-10-20 6:49 ` Markus Armbruster
2026-10-22 15:55 ` Hanna Czenczek
2026-10-23 6:14 ` Markus Armbruster
2026-10-23 14:33 ` Hanna Czenczek
2026-10-26 6:28 ` Markus Armbruster [this message]
2026-10-19 18:20 ` [PATCH v2 07/12] qapi/block: Add BLOCK_IO_DONE event Hanna Czenczek
2026-10-20 6:55 ` Markus Armbruster
2026-10-22 15:59 ` Hanna Czenczek
2026-10-23 6:18 ` Markus Armbruster
2026-10-23 14:38 ` Hanna Czenczek
2026-10-26 6:40 ` Markus Armbruster
2026-10-19 18:20 ` [PATCH v2 08/12] block-backend: Public blk_get_attached_dev_path() Hanna Czenczek
2026-10-19 18:20 ` [PATCH v2 09/12] host-utils: Add u{add,sub}{32,64}_saturate() Hanna Czenczek
2026-10-19 18:20 ` [PATCH v2 10/12] block: Per-request delay tracker Hanna Czenczek
2026-10-19 18:20 ` [PATCH v2 11/12] block: Add delay-report-ns and delay-stop-ns props Hanna Czenczek
2026-10-19 18:20 ` [PATCH v2 12/12] iotests: Add io-delay-reporting test Hanna Czenczek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyn56kmf.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.