From: Takashi Iwai <tiwai@suse.de>
To: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/hdmi: clamp sad_count in ELD proc write handler
Date: Thu, 08 Oct 2026 12:11:43 +0200 [thread overview]
Message-ID: <87jyns5wo0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261008085133.9528-1-peter.ujfalusi@linux.intel.com>
On Thu, 08 Oct 2026 10:51:33 +0200,
Peter Ujfalusi wrote:
>
> snd_hdmi_write_eld_info() parses a "sad_count N" line from the
> root-writable ELD proc interface and assigns N directly to
> e->sad_count with no upper bound, unlike the per-index "sadN_*" lines
> a few lines below which are already bounded to ELD_MAX_SAD.
>
> snd_hdmi_eld_update_pcm_info() later iterates
> "for (i = 0; i < e->sad_count; i++)" over the fixed
> e->sad[ELD_MAX_SAD] array, so an oversized sad_count read from the
> proc file causes it to walk past the array.
>
> Reject sad_count values above ELD_MAX_SAD, matching the existing
> per-index guard.
>
> Fixes: acb059938810 ("ALSA: hda - ELD proc interface write updates")
> Cc: stable@vger.kernel.org
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-10-08 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 8:51 [PATCH] ALSA: hda/hdmi: clamp sad_count in ELD proc write handler Peter Ujfalusi
2026-10-08 10:11 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyns5wo0.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.