From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B60B6CA5FB3 for ; Thu, 1 Oct 2026 08:28:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xCC94-0006fE-Vq; Thu, 01 Oct 2026 04:28:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xCC8h-0006I4-IP for qemu-devel@nongnu.org; Thu, 01 Oct 2026 04:27:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xCC8f-0003UM-Tj for qemu-devel@nongnu.org; Thu, 01 Oct 2026 04:27:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790843256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CruADJ2zASrL4o/gr8QoUDwLh+cDvnT24LinPipocgM=; b=RXI8vkKPylAIZNiq1tmz9L1UrDjgoarWE7fmaiQb2Y3/jiapXzT6nDoj0/DHvEPdV0QGb7 1Ul7+z1twD+jJl1vWpaQTkGKXapSp9wj+heZ3vb4dQ4Y0cWJobLL8As+r1hQDeE5kEOUNg UkBSbch6y9Lg+MkAkoCUC4co//16XeU= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-vn2JydYRMVqwywecT-XxiQ-1; Thu, 01 Oct 2026 04:27:34 -0400 X-MC-Unique: vn2JydYRMVqwywecT-XxiQ-1 X-Mimecast-MFC-AGG-ID: vn2JydYRMVqwywecT-XxiQ_1790843253 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 899001800870 for ; Thu, 1 Oct 2026 08:27:33 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.5]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4A76E41B for ; Thu, 1 Oct 2026 08:27:33 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id BE98521E6A04; Thu, 01 Oct 2026 10:27:30 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: Luigi Leonardi , qemu-devel@nongnu.org, Gerd Hoffmann , Stefano Garzarella , Ani Sinha , Paolo Bonzini , Eric Blake Subject: Re: [PATCH] igvm: add command line parameter support In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Thu, 1 Oct 2026 09:12:06 +0100") References: <20260930-igvm_command_line-v1-1-62857007d89d@redhat.com> <87qzi9alml.fsf@pond.sub.org> Date: Thu, 01 Oct 2026 10:27:30 +0200 Message-ID: <87jyo1akr1.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.341, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > On Thu, Oct 01, 2026 at 10:08:34AM +0200, Markus Armbruster wrote: >> Luigi Leonardi writes: >>=20 >> > Add a "cmdline" property to the igvm-cfg object and a handler for the >> > IGVM_VHT_COMMAND_LINE directive, which copies the string into the >> > parameter area the directive points at. >> > >> > This command line is intended for the component running at VMPL0, such >> > as SVSM, rather than for the guest OS, whose own command line still >> > comes from -append. SVSM can use it to select the serial port it logs >> > to, for example. >> > >> > Signed-off-by: Luigi Leonardi >>=20 >> [...] >>=20 >> > diff --git a/qapi/qom.json b/qapi/qom.json >> > index 5895c97750..d56bdef561 100644 >> > --- a/qapi/qom.json >> > +++ b/qapi/qom.json >> > @@ -1004,11 +1004,15 @@ >> > # >> > # @file: IGVM file to use to configure guest >> > # >> > +# @cmdline: command line for the software loaded from the IGVM file, >> > +# rather than for the guest OS. Ignored if the IGVM file does >> > +# not ask for one. (since 11.2) >> > +# >> > # Since: 10.1 >> > ## >> > { 'struct': 'IgvmCfgProperties', >> > 'if': 'CONFIG_IGVM', >> > - 'data': { 'file': 'str' } } >> > + 'data': { 'file': 'str', '*cmdline': 'str' } } >> >=20=20 >> > ## >> > # @SevCommonProperties: >>=20 >> How is @cmdline going to be parsed? By a shell? > > This is something passed to the guest workflow. ie a kernel command > line string. Not obvious from the description text. Please make it obvious. >> For what it's worth, MigrationExecCommand uses ['str']. Such values can >> be passed to exec()-like functions without parsing. > > In this case we should treat 'cmdline' as an opaque strnig and not > try to place any semantics on its expected syntax. > > With regards, > Daniel