From: Takashi Iwai <tiwai@suse.de>
To: Runyu Xiao <runyu.xiao@seu.edu.cn>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Jianhao Xu <jianhao.xu@seu.edu.cn>,
stable@vger.kernel.org
Subject: Re: [PATCH] m68k: dmasound: Keep the Q40 IRQ handler registered
Date: Tue, 29 Sep 2026 17:09:20 +0200 [thread overview]
Message-ID: <87jyo4ytzz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260929085400.2068977-1-runyu.xiao@seu.edu.cn>
On Tue, 29 Sep 2026 10:54:00 +0200,
Runyu Xiao wrote:
>
> Q40PlayNextFrame() re-registers the sample IRQ after stopping it. This
> function can be called with dmasound.lock held and from the sample IRQ
> handler, so free_irq() and request_irq() can sleep or deadlock. A failed
> re-registration can also leave playback without an IRQ.
>
> Register one handler for the lifetime of the driver and select mono or
> stereo sample handling inside that handler. Call the frame completion
> path after releasing dmasound.lock so it can refill the queue safely.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Runyu Xiao <runyu.xiao@seu.edu.cn>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-09-29 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 8:54 [PATCH] m68k: dmasound: Keep the Q40 IRQ handler registered Runyu Xiao
2026-09-29 15:09 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyo4ytzz.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=jianhao.xu@seu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=runyu.xiao@seu.edu.cn \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.