All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Federico Valentín Andrade" <fandrade@frba.utn.edu.ar>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	perex@perex.cz, tiwai@suse.com, kuba@kernel.org,
	alexander.deucher@amd.com
Subject: Re: [PATCH 1/2] ALSA: usb-audio: Skip reading sample rate on M-Audio Venom
Date: Sun, 23 Aug 2026 10:59:41 +0200	[thread overview]
Message-ID: <87jyphw6te.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260822043033.529424-2-fandrade@frba.utn.edu.ar>

On Sat, 22 Aug 2026 06:30:32 +0200,
Federico Valentín Andrade wrote:
> 
> The M-Audio Venom (0763:2084) is an USB Audio Class 1 compliant
> synth with an integrated audio interface, it does not implement
> GET_CUR on SAMPLING_FREQ_CONTROL, hanging up if requested on
> endpoint 0.
> 
> The first class request issued by the driver after enumeration is
> a GET_CUR on endpoint 0x02, freezing the device's USB microcontroller.
> Timing out on every transfer afterwards with -ETIMEDOUT, such as
> SET_INTERFACE, so neither the mixer nor any streaming interface is set up.
> 
> Analyzing a USBPcap capture of the Windows driver I found it never
> requests the sampling frequency, as the synth exposes a single
> discrete of 44100Hz on both streaming interfaces, thus asking for it
> is unnecessary.
> 
> So I applied get_sample_rate to avoid this check, and
> disable_autosuspend because the synth doesn't come back from being
> suspended.
> 
> Signed-off-by: Federico Valentín Andrade <fandrade@frba.utn.edu.ar>
> ---
>  sound/usb/quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index f4e1eac639..caa80487f4 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2334,6 +2334,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
>  		   QUIRK_FLAG_MIXER_GET_CUR_BROKEN | QUIRK_FLAG_GENERIC_IMPLICIT_FB),
>  	DEVICE_FLG(0x0763, 0x2081, /* M-Audio Fast Track Ultra */
>  		   QUIRK_FLAG_MIXER_GET_CUR_BROKEN | QUIRK_FLAG_GENERIC_IMPLICIT_FB),
> +	DEVICE_FLG(0x0763, 0x2084, /* M-Audio Venom */
> +		   QUIRK_FLAG_MIXER_GET_SAMPLE_RATE | QUIRK_FLAG_DISABLE_AUTOSUSPEND),
>  	DEVICE_FLG(0x07fd, 0x000b, /* MOTU M Series 2nd hardware revision */
>  		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
>  	DEVICE_FLG(0x08bb, 0x2702, /* LineX FM Transmitter */

This caused a build error.  A typo of QUIRK_FLAG_GET_SAMPLE_RATE?


thanks,

Takashi


  reply	other threads:[~2026-08-23  8:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-22  4:30 [PATCH 0/2] Quirks for the M-Audio Venom synth Federico Valentín Andrade
2026-08-22  4:30 ` [PATCH 1/2] ALSA: usb-audio: Skip reading sample rate on M-Audio Venom Federico Valentín Andrade
2026-08-23  8:59   ` Takashi Iwai [this message]
2026-08-22  4:30 ` [PATCH 2/2] ALSA: usb-audio: Skip mixer creation " Federico Valentín Andrade
2026-08-23 15:27 ` [PATCH v2 0/2] ALSA: usb-audio: Include M-Audio Venom Quirks Federico Valentín Andrade
2026-08-24 14:02   ` [PATCH v3 " Federico Valentín Andrade
2026-08-24 14:02   ` [PATCH v3 1/2] ALSA: usb-audio: Skip reading sample rate on M-Audio Venom Federico Valentín Andrade
2026-08-25  7:55     ` Takashi Iwai
2026-08-24 14:02   ` [PATCH v3 2/2] ALSA: usb-audio: Skip mixer creation " Federico Valentín Andrade
2026-08-23 15:27 ` [PATCH v2 1/2] ALSA: usb-audio: Skip reading sample rate " Federico Valentín Andrade
2026-08-24  6:44   ` Takashi Iwai
2026-08-23 15:27 ` [PATCH v2 2/2] ALSA: usb-audio: Skip mixer creation " Federico Valentín Andrade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jyphw6te.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alexander.deucher@amd.com \
    --cc=fandrade@frba.utn.edu.ar \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.