Re: [RFC PATCH v2 0/8] fuse: caches documentation and testing

[Luis Henriques <luis@igalia.com>]

On Tue, Aug 18 2026, Amir Goldstein wrote:

> On Mon, Aug 17, 2026 at 4:11 PM Luis Henriques <luis@igalia.com> wrote:
>>
>> Hi!
>>
>> I'm (finally!) sending v2 of this patchset.  It tries to document (and add
>> a few kselftests) to the different types of caches that are currently in use
>> within FUSE.  As I mentioned in v1 the idea for documenting this came from
>> Miklos during this year's LSFMM, where he mentioned he would like to see
>> caches usage documented before he could merge an initial version of fusex.
>>
>> This version documents symlinks, attributes, ACLs and readdir caches.  Still
>> missing: dentries and data caching.
>>
>> I'm still sending it as an RFC as I'm still not sure if it fulfils Miklos'
>> initial goal.
>>
>> As usual feedback is welcome, as I'll (slowly) continue looking into other
>> cache types.
>>
>> Major changes since v1:
>> - Added more caches to the document
>> - Changed tests format to single self-contained binaries
>> - Since Amir added a new fuse3-based test, the conversion to fuse3 of the
>>   fusectl has minor changes to the Makefile
>>   - NOTE: I've kept Amir's Reviewed-by anyway (should I drop it?)
>
> It's fine. I trust your judgement.
>
> Please see Sashiko review comments.

Sure, I will do that.  (For some reason I assumed I would receive an email
if there was a review for my patches.  Looks like that's not the case.)

> My main concern is with the doc - it's not an easy read
> and I would have liked it to be and I found many correctness error
> which is not a good sign.

Hmm... OK, I'll need to go through those errors and try my best to see if
I can fix them.

Thanks a lot for your feedback, Amir.  Much appreciated.

Cheers,
-- 
Luís