Re: [PATCH 6/6] mtd: spi-nor-ids: Add support for Winbond W25Q256JV/W25Q512JV

[Miquel Raynal <miquel.raynal@bootlin.com>]

>> > +	{
>> > +		INFO("w25q512jv", 0xef7020, 0, 64 * 1024, 1024,
>> 
>> This is JV-M (here and above).
>
> Of course. I didn't test the -Q version but I already saw related parts
> like w25q512jvq existed.
>
> Perhaps naming these -M series with 'm' suffix is better.

I'm fine with both, I prefer -m in this case, because there are letters
in between:
- 2 or 3 letters for the package type
- I or J for the temperature range

>> These chips also happen to conflict with W25QxxRV-M chips. Is this
>> support for these new chips that you are targeting?
>
> I didn't use RV series now. w25q256jv/w25q512jv are tested on
> MediaTek's filogic platform.

This is worth mentioning in your commit log.

>
> As winbond doesn't provide the actual contents of the SFDP table, I'm
> not sure if there's a way to distinguish between these two families.

There is one, I will contribute it to Linux/U-Boot soon, but both are
very similar in their behaviour, so it's okay like that.

Thanks,
Miquèl