From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31CC010ED665 for ; Fri, 27 Mar 2026 12:28:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w66IH-0000KB-2k; Fri, 27 Mar 2026 08:28:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w66IF-0000Jq-AL for qemu-devel@nongnu.org; Fri, 27 Mar 2026 08:28:03 -0400 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w66ID-0002xa-UB for qemu-devel@nongnu.org; Fri, 27 Mar 2026 08:28:03 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BC7EC4D338; Fri, 27 Mar 2026 12:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774614480; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aCHx5AbCecyKFnTFwf6RtAg935iVAyZAvJYvrRGJxtU=; b=cJmwMbPl87qhi2Zp/h+/t5i6O2yqXzkrmgRkUrYIq7/mYlljvupWoi3BYobTQxl6j4Lx9V 6gUZgMXdLp/CoK7OCRdJqe+KJ33fitCGMOx/Ba67i4uTQ3dOIhcp37yd3ro8rL5CcbfpUz hkHixVzCv5F3XL7jLsoqJt1ioslIM0o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774614480; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aCHx5AbCecyKFnTFwf6RtAg935iVAyZAvJYvrRGJxtU=; b=PtKo5vd1aU7dS+lNx0neh2+jF30zXOqxPo2XXGn8UMXXFiPZ/XCBgl2Eo0tU0lRBRj1vBp GKC5eFVxNIAe2KBw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774614480; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aCHx5AbCecyKFnTFwf6RtAg935iVAyZAvJYvrRGJxtU=; b=cJmwMbPl87qhi2Zp/h+/t5i6O2yqXzkrmgRkUrYIq7/mYlljvupWoi3BYobTQxl6j4Lx9V 6gUZgMXdLp/CoK7OCRdJqe+KJ33fitCGMOx/Ba67i4uTQ3dOIhcp37yd3ro8rL5CcbfpUz hkHixVzCv5F3XL7jLsoqJt1ioslIM0o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774614480; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aCHx5AbCecyKFnTFwf6RtAg935iVAyZAvJYvrRGJxtU=; b=PtKo5vd1aU7dS+lNx0neh2+jF30zXOqxPo2XXGn8UMXXFiPZ/XCBgl2Eo0tU0lRBRj1vBp GKC5eFVxNIAe2KBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5ABA24A0A2; Fri, 27 Mar 2026 12:28:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NnEDC9B3xmkyVQAAD6G6ig (envelope-from ); Fri, 27 Mar 2026 12:28:00 +0000 From: Fabiano Rosas To: Peter Xu , qemu-devel@nongnu.org Cc: Alexander Mikhalitsyn , peterx@redhat.com, Juraj Marcin , Alexander Mikhalitsyn Subject: Re: [PATCH RFC v2 06/11] vmstate: Introduce vmstate_save_field_with_vmdesc() In-Reply-To: <20260326210532.379027-7-peterx@redhat.com> References: <20260326210532.379027-1-peterx@redhat.com> <20260326210532.379027-7-peterx@redhat.com> Date: Fri, 27 Mar 2026 09:27:58 -0300 Message-ID: <87jyuxihip.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; MISSING_XM_UA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:email, futurfusion.io:email, imap1.dmz-prg2.suse.org:helo] Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > Introduce a helper to do both the JSON blob generations and save vmstate. > This further shrinks the function a bit. More importantly, we'll need to > save two fields in one loop very soon in the future with the JSON blob. > > Reviewed-by: Alexander Mikhalitsyn > Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas