From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBFBBCFD31C for ; Mon, 24 Nov 2025 08:00:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kQYBNr9Ft7mYqsw/mP0Y17rVXr6MI7roG7E7QV6WgyA=; b=bvydx9wlCXYu+v 8NWkhEgEFk4bMMbojmY7neAjMJ5skdHSNHudsn4pkDrzGxWO1mDcTe7c0kVfARHXnQLK5ki/BwAyt ifwTST2OvJKbKQ9TtTQ/pJ79tDhYZZw05Cn4iMO6XvNOdRykKby/gBdXoTe+Ud5ZUeD04Jw4Pgy7N eqgWjR51vwkmN59SKIuNEYi4ialg34hPb3L9enHnrzDpwTfdFRoMZ9Iu3yCkjZzTk6+XHUzAllTZF tHJvwQqYmDHcjrokWcM/Srg2U2AMwO3KdTBCPmrezcm6ffT8C1X+v3qCT4+Z3B4kJbSXwcLPwJQhR 3wUzHchxhI0jtwToDaVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNRV3-0000000BFu9-1RKw; Mon, 24 Nov 2025 08:00:41 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNRV0-0000000BFtc-0JlQ for linux-mtd@lists.infradead.org; Mon, 24 Nov 2025 08:00:40 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id A98B01A1D08; Mon, 24 Nov 2025 08:00:32 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 7D8F3606FC; Mon, 24 Nov 2025 08:00:32 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 166A010370004; Mon, 24 Nov 2025 09:00:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763971231; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=nAYucZ//0PJKUxBFzIXxcaSNRPWJLukjBLAGomp2KiY=; b=dflCg6JWqiq6r+0sn/UcxrmbmlFXNuSqzjz6AS8+1tY+na6I7Z+8fJdbjMl4o9Jy9lpBiS cMJ6CAZmtgrDh4wh119IxyoZeGY8en+eO9OUmk78Bs++K4O34qb3jEvWVi0MaZnq1iT625 4AGoXLR7hpb8OUtkbxnXzJiLu1nwvBNIcZyXXjWY4pAViRxCGvasoxFS4dPumUXIAi8jYQ l0Em+g2xipKEG+sP55MasTq8Zhj2jvnaYG0j2z/g8qA0A3t9g97wvywRDB7aMVHwG9yFlc ZLOxaOj0IpCElf4NWg5z5XdqJOJNnTJF5dhyzW8bBYuimDoM3f0Q51jh1imlqQ== From: Miquel Raynal To: Marc Olberding Cc: Tudor Ambarus , Pratyush Yadav , Michael Walle , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: spi-nor: Fix w25q01jv flags In-Reply-To: <20251121-w25q01jv_fixup-v1-1-3d175050db73@nvidia.com> (Marc Olberding's message of "Fri, 21 Nov 2025 14:35:34 -0800") References: <20251121-w25q01jv_fixup-v1-1-3d175050db73@nvidia.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Mon, 24 Nov 2025 09:00:27 +0100 Message-ID: <87jyzfzwpw.fsf@bootlin.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251124_000038_252779_57AB29C9 X-CRM114-Status: GOOD ( 27.09 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWFyYywKCk9uIDIxLzExLzIwMjUgYXQgMTQ6MzU6MzQgLTA4LCBNYXJjIE9sYmVyZGluZyA8 bW9sYmVyZGluZ0BudmlkaWEuY29tPiB3cm90ZToKCj4gVGhlIHByZXZpb3VzIHN1cHBvcnQgZm9y IHcyNXEwMWp2IHdhcyBjYXVzaW5nIHJlYWQvd3JpdGUKPiBtaXNjb21wYXJlcyBvbiBmbGFzaGlu ZyB3aXRoIHRoZSBhc3BlZWQgYXN0MjYwMC4gQWRkIGluCj4gZXh0cmEgZmxhZ3MgdG8gYWxsb3cg dGhlIGNoaXAgdG8gaWRlbnRpZnkgYXMgaGF2aW5nIDRLCj4gc2VjdG9ycyBpZiB0aGUgc2ZkcCB0 YWJsZXMgYXJlbid0IHByZXNlbnQsIGFzIHdlbGwKCkFyZSB3ZSBzdXJlIGFib3V0IHRoZSByZWFz b24/IE5vcm1hbGx5IHRoaXMgaXMgYSBub24tc2ZkcCBmbGFnLCB3aGljaAptZWFucyBldmVuIGlm IHlvdSBoYXZlIHNmZHAgdGFibGVzLCB5b3UgbXVzdCBtYXJrIHRoaXMgZmxhZwptYW51YWxseS4g VGhlc2UgY2hpcHMgc2hvdWxkIGFsd2F5cyBoYXZlIHRoZSBzZmRwIHRhYmxlcy4gRGlkIHlvdSBm YWNlCmNhc2VzIHdoZXJlIHRoZXkgYXJlIG5vdCBwb3B1bGF0ZWQ/Cgo+IGFzIHJlcG9ydGluZyB0 aGUgbmFtZSBhbmQgYWRkaW5nIHRoZSBMT0NLIGFuZCBUQiBmbGFnLgo+Cj4gQWZ0ZXIgdGhpcyBj aGFuZ2UsIG5vIG1pc2NvbXBhcmVzIHdlcmUgc2Vlbi4KPgo+IEZpeGVzOiA5YjRkYjAzMmZiMmIg KCJtdGQ6IHNwaS1ub3I6IHdpbmJvbmQ6IEFkZCBzdXBwb3J0IGZvciB3MjVxMDFqdiIpCj4gU2ln bmVkLW9mZi1ieTogTWFyYyBPbGJlcmRpbmcgPG1vbGJlcmRpbmdAbnZpZGlhLmNvbT4KPiAtLS0K PiBUaGUgaW5pdGlhbCBjb21taXRbMV0gdGhhdCBjYW1lIGluIGZvciB3MjVxMDFqdiBbMl0gc3Vw cG9ydAo+IGxhY2tzIHRoZSA0SyBzZWN0b3IgZmxhZ3MgaW4gdGhlIGNhc2UgdGhhdCB0aGUgc2Zk cCBmbGFncyBkb24ndAo+IGV4aXN0IG9uIHRoZSBjaGlwLiBUaGlzIGNhdXNlZCBmaWxlc3lzdGVt IGNvcnJ1cHRpb24gdXBvbiB3cml0ZXMuCj4gQWRkIGluIHRoZSBmbGFncyBhcyB3ZWxsIGFzIHRo ZSBjaGlwcyBzaXplIGFuZCBuYW1lLgo+Cj4gVGVzdGluZzoKPiBBZnRlciB0aGlzIHBhdGNoLCBC TUMncyBiYWNrZWQgYnkgdGhlIHcyNXEwMWp2IHN1Y2NlZWQgb24gYm9vdAo+IGFzIHdlbGwgYXMg c2VsZi1mbGFzaAo+Cj4gWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC8yMDI1MTAxNDA1 MDEwOC42NjUzMzgtMS1jaG91LmNvc21vQGdtYWlsLmNvbS8KPiBbMl0gaHR0cHM6Ly93d3cud2lu Ym9uZC5jb20vcmVzb3VyY2UtZmlsZXMvVzI1UTAxSlYlMjBTUEklMjBSZXZFJTIwMDMwNDIwMjQl MjBQbHVzLnBkZgo+IC0tLQo+ICBkcml2ZXJzL210ZC9zcGktbm9yL3dpbmJvbmQuYyB8IDUgKysr Ky0KPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL3NwaS1ub3Ivd2luYm9uZC5jIGIvZHJpdmVycy9tdGQv c3BpLW5vci93aW5ib25kLmMKPiBpbmRleCA2M2E5M2M5ZWI5MTc0YjA3M2UxOWM0MWVlYWRhMzNi MjNhOTliMTg0Li43ZDQxMTlhZmM4YzZiNDEzNWI1YTA1NWI1MmIxYWRlN2UzZWY5MjZjIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvbXRkL3NwaS1ub3Ivd2luYm9uZC5jCj4gKysrIGIvZHJpdmVycy9t dGQvc3BpLW5vci93aW5ib25kLmMKPiBAQCAtMjI3LDggKzIyNywxMSBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IGZsYXNoX2luZm8gd2luYm9uZF9ub3JfcGFydHNbXSA9IHsKPiAgCQkuc2l6ZSA9IFNa XzY0TSwKPiAgCQkubm9fc2ZkcF9mbGFncyA9IFNFQ1RfNEsgfCBTUElfTk9SX0RVQUxfUkVBRCB8 IFNQSV9OT1JfUVVBRF9SRUFELAo+ICAJfSwgewo+IC0JCS8qIFcyNVEwMUpWICovCj4gIAkJLmlk ID0gU05PUl9JRCgweGVmLCAweDQwLCAweDIxKSwKPiArCQkubmFtZSA9ICJ3MjVxMDFqdiIsCgpD aGFuZ2luZyB0aGUgY29tbWVudCBpbnRvIGEgbmFtZSBpcyBub3QgcmVsZXZhbnQgaGVyZSBmb3Ig dHdvIHJlYXNvbnM6Ci0gdGhpcyBpcyBkZXByZWNhdGVkCi0gdGhpcyBwYXRjaCBpcyBhIGZpeCwg YW55IGZ1cnRoZXIgYWRkaXRpb25zIHNob3VsZCBiZSBpbiBhIGRlZGljYXRlZCBwYXRjaC4KCj4g KwkJLnNpemUgPSBTWl8xMjhNLAoKRG8geW91IHJlYWxseSBuZWVkIHRoaXMgZmllbGQ/IEhvdyBk aWQgdGhlIGZsYXNoIGV2ZW4gd29ya2VkIGJlZm9yZSBpZgp5b3UgbmVlZCB0aGlzPwoKPiArCQku ZmxhZ3MgPSBTUElfTk9SX0hBU19MT0NLIHwgU1BJX05PUl9IQVNfVEIsCgpJIGhhdmUgbm90IHVz ZWQgbm9yIHRlc3RlZCBibG9jayBwcm90ZWN0aW9uIG9uIHRoYXQgY2hpcC4gSWYgaXQncyBhbgph ZGRpdGlvbiB5b3UgbXVzdCBwdXQgdGhhdCBpbiBhIHNlcGFyYXRlZCBwYXRjaC4gRml4ZXMgd2ls bCBiZSBxdWV1ZWQKZmFzdGVyIHRoYW4gZmVhdHVyZSBhZGRpdGlvbnMsIHlvdSBjYW5ub3QgbWl4 IGJvdGguCgo+ICsJCS5ub19zZmRwX2ZsYWdzID0gU0VDVF80SywKClRoaXMgb25lIGlzIHRoZSBy aWdodCBmaXggYW5kIHNob3VsZCBzdGFuZCBhbG9uZSBpbiBpdHMgb3duIHBhdGNoIChmaXJzdApp biB0aGUgc2VyaWVzIGlmIHlvdSBhZGQgc3VwcG9ydCBmb3IgdGhlIGJsb2NrIHByb3RlY3Rpb24p LgoKPiAgCQkuZml4dXBzID0gJndpbmJvbmRfbm9yX211bHRpX2RpZV9maXh1cHMsCj4gIAl9LCB7 Cj4gIAkJLmlkID0gU05PUl9JRCgweGVmLCAweDUwLCAweDEyKSwKClRoYW5rcywKTWlxdcOobAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxp bnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BB4920CCCA for ; Mon, 24 Nov 2025 08:00:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763971238; cv=none; b=dAdieBS40Grv1Oc0yMj0KWAN6CFLTTBOap4YUKBp9Bp2/21NgHGJLdPrYo70SLOvb7AdD34mACVz5Eoo7nG3qmybZrGBrk8/Qi46wDYQ0Ez5NcE1m/5CxY3KUCGyzDC/IxionSZZWcjWsEH0eiPPba/xutU3XT7vB0oM9jG3kJ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763971238; c=relaxed/simple; bh=dGKPpm7k8tuka8ZhEfMm6JqB+0CUpCKmZWKS0+hgD70=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=RdgyxeAn4pzvggTqbRSYkj0IL0EZJjbmGCmYQfre0NsDAPac//JEKhSE+ou4o6rV2m1DIraSzhv1Mb3ZacjTLppLgr9AdRTrrgN9P/rAqpKQ/rSI7SJ9nx60NjtWTHA/fvvvQHpV3JjXCzyw2H9qnx6qkGNHbNVrMB7bRVT9TRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=dflCg6JW; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="dflCg6JW" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id E4411C139A5; Mon, 24 Nov 2025 08:00:09 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 7D8F3606FC; Mon, 24 Nov 2025 08:00:32 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 166A010370004; Mon, 24 Nov 2025 09:00:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763971231; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=nAYucZ//0PJKUxBFzIXxcaSNRPWJLukjBLAGomp2KiY=; b=dflCg6JWqiq6r+0sn/UcxrmbmlFXNuSqzjz6AS8+1tY+na6I7Z+8fJdbjMl4o9Jy9lpBiS cMJ6CAZmtgrDh4wh119IxyoZeGY8en+eO9OUmk78Bs++K4O34qb3jEvWVi0MaZnq1iT625 4AGoXLR7hpb8OUtkbxnXzJiLu1nwvBNIcZyXXjWY4pAViRxCGvasoxFS4dPumUXIAi8jYQ l0Em+g2xipKEG+sP55MasTq8Zhj2jvnaYG0j2z/g8qA0A3t9g97wvywRDB7aMVHwG9yFlc ZLOxaOj0IpCElf4NWg5z5XdqJOJNnTJF5dhyzW8bBYuimDoM3f0Q51jh1imlqQ== From: Miquel Raynal To: Marc Olberding Cc: Tudor Ambarus , Pratyush Yadav , Michael Walle , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: spi-nor: Fix w25q01jv flags In-Reply-To: <20251121-w25q01jv_fixup-v1-1-3d175050db73@nvidia.com> (Marc Olberding's message of "Fri, 21 Nov 2025 14:35:34 -0800") References: <20251121-w25q01jv_fixup-v1-1-3d175050db73@nvidia.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Mon, 24 Nov 2025 09:00:27 +0100 Message-ID: <87jyzfzwpw.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Marc, On 21/11/2025 at 14:35:34 -08, Marc Olberding wrote: > The previous support for w25q01jv was causing read/write > miscompares on flashing with the aspeed ast2600. Add in > extra flags to allow the chip to identify as having 4K > sectors if the sfdp tables aren't present, as well Are we sure about the reason? Normally this is a non-sfdp flag, which means even if you have sfdp tables, you must mark this flag manually. These chips should always have the sfdp tables. Did you face cases where they are not populated? > as reporting the name and adding the LOCK and TB flag. > > After this change, no miscompares were seen. > > Fixes: 9b4db032fb2b ("mtd: spi-nor: winbond: Add support for w25q01jv") > Signed-off-by: Marc Olberding > --- > The initial commit[1] that came in for w25q01jv [2] support > lacks the 4K sector flags in the case that the sfdp flags don't > exist on the chip. This caused filesystem corruption upon writes. > Add in the flags as well as the chips size and name. > > Testing: > After this patch, BMC's backed by the w25q01jv succeed on boot > as well as self-flash > > [1] https://lore.kernel.org/all/20251014050108.665338-1-chou.cosmo@gmail.= com/ > [2] https://www.winbond.com/resource-files/W25Q01JV%20SPI%20RevE%20030420= 24%20Plus.pdf > --- > drivers/mtd/spi-nor/winbond.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c > index 63a93c9eb9174b073e19c41eeada33b23a99b184..7d4119afc8c6b4135b5a055b5= 2b1ade7e3ef926c 100644 > --- a/drivers/mtd/spi-nor/winbond.c > +++ b/drivers/mtd/spi-nor/winbond.c > @@ -227,8 +227,11 @@ static const struct flash_info winbond_nor_parts[] = =3D { > .size =3D SZ_64M, > .no_sfdp_flags =3D SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, > }, { > - /* W25Q01JV */ > .id =3D SNOR_ID(0xef, 0x40, 0x21), > + .name =3D "w25q01jv", Changing the comment into a name is not relevant here for two reasons: - this is deprecated - this patch is a fix, any further additions should be in a dedicated patch. > + .size =3D SZ_128M, Do you really need this field? How did the flash even worked before if you need this? > + .flags =3D SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB, I have not used nor tested block protection on that chip. If it's an addition you must put that in a separated patch. Fixes will be queued faster than feature additions, you cannot mix both. > + .no_sfdp_flags =3D SECT_4K, This one is the right fix and should stand alone in its own patch (first in the series if you add support for the block protection). > .fixups =3D &winbond_nor_multi_die_fixups, > }, { > .id =3D SNOR_ID(0xef, 0x50, 0x12), Thanks, Miqu=C3=A8l