Re: [PATCH] wifi: iwlwifi: Add missing firmware info for bz-b0-* models

[Takashi Iwai <tiwai@suse.de>]

On Sun, 19 Oct 2025 13:54:14 +0200,
Korenblit, Miriam Rachel wrote:
> 
> 
> > Cc: linux-wireless@vger.kernel.org; Berg, Johannes <johannes.berg@intel.com>
> > Subject: [PATCH] wifi: iwlwifi: Add missing firmware info for bz-b0-* models
> 
> Please specify the destination tree for this patch, we have iwlwifi-next and iwlwifi-fixes.
> So yours should probably be [PATCH iwlwifi-next] ....
> > 
> > The module firmware info is missing for iwlwifi-bz-b0-* models, which results in
> > the non-working WiFi on some installers or images.
> > 
> > Add the entries for iwlwifi-bz-b0-fm-c0, iwlwifi-bz-b0-gf-a0 and iwlwifi-bz-b0-hr-
> > b0.
> > 
> > Link: https://bugzilla.suse.com/show_bug.cgi?id=1252084
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> >  drivers/net/wireless/intel/iwlwifi/cfg/bz.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/bz.c
> > b/drivers/net/wireless/intel/iwlwifi/cfg/bz.c
> > index 3e6206e739f6..44a00acce81f 100644
> > --- a/drivers/net/wireless/intel/iwlwifi/cfg/bz.c
> > +++ b/drivers/net/wireless/intel/iwlwifi/cfg/bz.c
> > @@ -22,6 +22,9 @@
> >  #define IWL_BZ_A_FM_B_FW_PRE		"iwlwifi-bz-a0-fm-b0"
> >  #define IWL_BZ_A_FM_C_FW_PRE		"iwlwifi-bz-a0-fm-c0"
> >  #define IWL_BZ_A_FM4_B_FW_PRE		"iwlwifi-bz-a0-fm4-b0"
> > +#define IWL_BZ_B_FM_C_FW_PRE		"iwlwifi-bz-b0-fm-c0"
> > +#define IWL_BZ_B_GF_A_FW_PRE		"iwlwifi-bz-b0-gf-a0"
> > +#define IWL_BZ_B_HR_B_FW_PRE		"iwlwifi-bz-b0-hr-b0"
> >  #define IWL_GL_B_FM_B_FW_PRE		"iwlwifi-gl-b0-fm-b0"
> >  #define IWL_GL_C_FM_C_FW_PRE		"iwlwifi-gl-c0-fm-c0"
> > 
> > @@ -104,5 +107,8 @@ const struct iwl_mac_cfg iwl_gl_mac_cfg = {
> > IWL_CORE_FW(IWL_BZ_A_FM_B_FW_PRE, IWL_BZ_UCODE_CORE_MAX);
> > IWL_CORE_FW(IWL_BZ_A_FM_C_FW_PRE, IWL_BZ_UCODE_CORE_MAX);
> > IWL_CORE_FW(IWL_BZ_A_FM4_B_FW_PRE, IWL_BZ_UCODE_CORE_MAX);
> > +IWL_CORE_FW(IWL_BZ_B_FM_C_FW_PRE, IWL_BZ_UCODE_CORE_MAX);
> > +IWL_CORE_FW(IWL_BZ_B_GF_A_FW_PRE, IWL_BZ_UCODE_CORE_MAX);
> > +IWL_CORE_FW(IWL_BZ_B_HR_B_FW_PRE, IWL_BZ_UCODE_CORE_MAX);
> >  IWL_CORE_FW(IWL_GL_B_FM_B_FW_PRE, IWL_BZ_UCODE_CORE_MAX);
> > IWL_CORE_FW(IWL_GL_C_FM_C_FW_PRE, IWL_BZ_UCODE_CORE_MAX);
> 
> Those FW files should really be added to the relevant rf-*.h files
> (yes, I know there are already others here but those should move as well)
> 
> So for example, iwlwifi-bz-b0-fm-c0 should go to rf-fm.h etc.

Sorry for the late reaction, as I was too much side-tracked.

I saw you already moved the stuff into rf-fm.c on linux-next, so I'm
going to resubmit v2 after the rebase.


thanks,

Takashi