From: Takashi Iwai <tiwai@suse.de>
To: "René Rebe" <rene@exactco.de>
Cc: linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
<tiwai@suse.com>, Richard Fitzgerald <rf@opensource.cirrus.com>
Subject: Re: [PATCH] fix cs420x MacPro 6,1 inverted jack detection
Date: Mon, 17 Nov 2025 17:17:14 +0100 [thread overview]
Message-ID: <87jyzofxbp.wl-tiwai@suse.de> (raw)
In-Reply-To: <20251114.173541.1765928837929818015.rene@exactco.de>
On Fri, 14 Nov 2025 17:35:41 +0100,
René Rebe wrote:
>
> Turns out the Apple MacPro 6,1 trashcan also needs the inverted jack
> detection like Mac mini patched, too.
>
> Signed-off-by: René Rebe <rene@exactco.de>
>
> diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c
> index 06e046214a41..dcd58f0b8bdf 100644
> --- a/sound/hda/codecs/cirrus/cs420x.c
> +++ b/sound/hda/codecs/cirrus/cs420x.c
> @@ -643,6 +643,7 @@ static const struct hda_quirk cs4208_fixup_tbl[] = {
> static const struct hda_quirk cs4208_mac_fixup_tbl[] = {
> SND_PCI_QUIRK(0x106b, 0x5e00, "MacBookPro 11,2", CS4208_MBP11),
> SND_PCI_QUIRK(0x106b, 0x6c00, "MacMini 7,1", CS4208_MACMINI),
> + SND_PCI_QUIRK(0x106b, 0x7800, "MacPro 6,1", CS4208_MACMINI),
> SND_PCI_QUIRK(0x106b, 0x7100, "MacBookAir 6,1", CS4208_MBA6),
> SND_PCI_QUIRK(0x106b, 0x7200, "MacBookAir 6,2", CS4208_MBA6),
> SND_PCI_QUIRK(0x106b, 0x7b00, "MacBookPro 12,1", CS4208_MBP11),
The table entries are sorted rather in PCI SSID order.
Could you try to put at the right position?
Also, please put a proper subject prefix, e.g. "ALSA: hda/cirrus: fix
cs420x MacPro ....".
thanks,
Takashi
prev parent reply other threads:[~2025-11-17 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 16:35 [PATCH] fix cs420x MacPro 6,1 inverted jack detection René Rebe
2025-11-17 16:17 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyzofxbp.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rene@exactco.de \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.