From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5167DCCF9E0 for ; Mon, 27 Oct 2025 15:08:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vDOoR-0008QJ-8U; Mon, 27 Oct 2025 11:07:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDOoK-0008PT-F3 for qemu-devel@nongnu.org; Mon, 27 Oct 2025 11:07:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDOoA-00032w-QI for qemu-devel@nongnu.org; Mon, 27 Oct 2025 11:07:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761577609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FX4GHEaPcsy7R+RTPvY4S0flBMk0vAvan/cPmzI9740=; b=ZJapFgUJn/Z8pod3+lvJ7UZYYDuZ8X++FYmiQbsQkoZjQ4SKSVO9TLlnGW1w03EO+wrnl0 uzd2Ttmjz+TT7vpmRon7lb1ytUBorqYRFVWhO9AHWm95fcYDmMtzBwcp39ZKIAq2kLCUFi 7e0Z9kvYFlFjAGgqo6Z7ghF/w1A32WE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-467-hLXvWnLHMYGJalBwf4olBQ-1; Mon, 27 Oct 2025 11:06:44 -0400 X-MC-Unique: hLXvWnLHMYGJalBwf4olBQ-1 X-Mimecast-MFC-AGG-ID: hLXvWnLHMYGJalBwf4olBQ_1761577603 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CC8AD19540DC; Mon, 27 Oct 2025 15:06:42 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.18]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 208B3180057C; Mon, 27 Oct 2025 15:06:42 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 71A5C21E6A27; Mon, 27 Oct 2025 16:06:39 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy Cc: peterx@redhat.com, stefanb@linux.vnet.ibm.com, farosas@suse.de, qemu-devel@nongnu.org, berrange@redhat.com Subject: Re: [PATCH v3 2/4] tmp_emulator: fix unset errp on error path In-Reply-To: (Vladimir Sementsov-Ogievskiy's message of "Mon, 27 Oct 2025 17:33:20 +0300") References: <20251025202649.1122420-1-vsementsov@yandex-team.ru> <20251025202649.1122420-3-vsementsov@yandex-team.ru> <87y0owodjd.fsf@pond.sub.org> Date: Mon, 27 Oct 2025 16:06:39 +0100 Message-ID: <87jz0gl6yo.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Vladimir Sementsov-Ogievskiy writes: > On 27.10.25 13:16, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Note, that called tpm_emulator_startup_tpm_resume() does error_report() >>> failure paths, which could be turned into error_setg() to passthough an >>> error. But, not on all error paths. Not saying about >>> tpm_emulator_startup_tpm_resume() return -1 on failure and we mix it >>> with -errno from tpm_emulator_set_state_blobs(). So, it all needs deeper >>> refactoring, which is out of scope of this small fix. >>> >>> Fixes: 42e556fa3f7ac >>> "backends/tpm: Propagate vTPM error on migration failure" >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>> backends/tpm/tpm_emulator.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c >>> index dacfca5ab7..aa69eb606f 100644 >>> --- a/backends/tpm/tpm_emulator.c >>> +++ b/backends/tpm/tpm_emulator.c >>> @@ -961,6 +961,7 @@ static int tpm_emulator_post_load(void *opaque, int version_id, Error **errp) >>> } >>> if (tpm_emulator_startup_tpm_resume(tb, 0, true) < 0) { >>> + error_setg(errp, "Failed to resume tpm"); >>> return -EIO; >>> } >> >> Anti-pattern: we call error_report() (via >> tpm_emulator_startup_tpm_resume(), tpm_emulator_set_buffer_size, ...) >> from within an Error-setting function. You need to convert the entire >> nest of functions to Error. >> > > Is it a show-stopper for bug-fix? I'm afraid, I have no time to convert the whole > tpm_emulator.c. Fair. Throw in a FIXME comment, and I'll give my R-by.