All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: linux-doc@vger.kernel.org, Vegard Nossum <vegard.nossum@oracle.com>
Subject: Re: [PATCH] docs: sphinx: remove SPDX/copyright comments from HTML output
Date: Wed, 03 Sep 2025 15:59:07 -0600	[thread overview]
Message-ID: <87jz2fp590.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20250830170808.3911151-1-vegard.nossum@oracle.com>

Vegard Nossum <vegard.nossum@oracle.com> writes:

> Use Jinja2 comments instead of HTML comments for the SPDX and copyright
> lines. This prevents them from appearing in the HTML output, which was
> never the intention; the HTML output has its own copyright line at the
> bottom of the document.
>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
> ---
>  Documentation/sphinx/templates/kernel-toc.html   | 3 ++-
>  Documentation/sphinx/templates/translations.html | 4 ++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/sphinx/templates/kernel-toc.html b/Documentation/sphinx/templates/kernel-toc.html
> index 41f1efbe64bb2..b84969bd31c4f 100644
> --- a/Documentation/sphinx/templates/kernel-toc.html
> +++ b/Documentation/sphinx/templates/kernel-toc.html
> @@ -1,4 +1,5 @@
> -<!-- SPDX-License-Identifier: GPL-2.0 -->
> +{# SPDX-License-Identifier: GPL-2.0 #}
> +

So this stuff started with jinja2 comments, but then was changed to HTML
by 4e98799a7021 in 2023.  The problem being addressed there was that
spdxcheck.py doesn't recognize those comments and whines, and it didn't
seem worth fixing at the time.

I was thinking I should just fix spdxcheck.py now and be done with it,
but it seems that 154916f4b59d by Lukas Bulwahn tweaked the script
earlier this year.

...which is a long way of saying: applied, thanks ... :)

jon

      reply	other threads:[~2025-09-03 21:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-30 17:08 [PATCH] docs: sphinx: remove SPDX/copyright comments from HTML output Vegard Nossum
2025-09-03 21:59 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jz2fp590.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=vegard.nossum@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.