Re: [PULL 00/32] QAPI patches patches for 2025-07-14

[Markus Armbruster <armbru@redhat.com>]

Stefan Hajnoczi <stefanha@gmail.com> writes:

> On Mon, Jul 14, 2025 at 11:14 AM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336:
>>
>>   Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into staging (2025-07-13 01:46:04 -0400)
>>
>> are available in the Git repository at:
>>
>>   https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2025-07-14
>>
>> for you to fetch changes up to 07273ca0ce3af397071f7a6c11abdab649ff25e1:
>>
>>   tests/qtest/qom-test: unit test for qom-list-get (2025-07-14 15:25:12 +0200)
>>
>> ----------------------------------------------------------------
>> QAPI patches patches for 2025-07-14
>>
>> ----------------------------------------------------------------
>> John Snow (27):
>>       docs/sphinx: adjust qapidoc to cope with same-line error sections
>>       docs/sphinx: parse @references in freeform text
>>       docs/sphinx: remove legacy QAPI manual generator
>>       docs/sphinx: remove special parsing for freeform sections
>>       qapi: lift restriction on using '=' in doc blocks
>>       docs/qapi-domain: add return-nodesc
>>       qapi: Fix undocumented return values by generating something
>>       qapi: remove trivial "Returns:" sections
>>       qapi: rephrase return docs to avoid type name
>>       qapi: add cross-references to acpi.json
>>       qapi: add cross-references to authz.json
>>       qapi: add cross-references to block layer
>>       qapi: add cross-references to crypto.json
>>       qapi: add cross-references to dump.json
>>       qapi: add cross-references to job.json
>>       qapi: add cross-references to Machine core
>>       qapi: add cross-references to migration.json
>>       qapi: add cross-references to net.json
>>       qapi: add cross-references to pci.json
>>       qapi: add cross-references to QOM
>>       qapi: add cross-references to replay.json
>>       qapi: add cross-references to run-state.json
>>       qapi: add cross-references to sockets.json
>>       qapi: add cross-references to ui.json
>>       qapi: add cross-references to virtio.json
>>       qapi: add cross-references to yank.json
>>       qapi: add cross-references to misc modules
>>
>> Markus Armbruster (2):
>>       qapi: Clean up "This command will do ..." command descriptions
>>       qapi: Clean up a few Errors: sections
>>
>> Steve Sistare (3):
>>       qom: qom-list-get
>>       python: use qom-list-get
>>       tests/qtest/qom-test: unit test for qom-list-get
>
> The check-python-minreqs CI job is failing:
>
> qemu/utils/qom.py:35:1: F401 'qemu.qmp.ExecuteError' imported but unused
> qemu/utils/qom.py:241:34: E201 whitespace after '['
> qemu/utils/qom.py:241:56: E202 whitespace before ']'
> qemu/utils/qom.py:244:30: E711 comparison to None should be 'if cond is None:'
> qemu/utils/qom.py:245:33: F541 f-string is missing placeholders
> qemu/utils/qom.py:254:5: E303 too many blank lines (2)
> Log file "stderr" content for test "01-tests/flake8.sh" (FAIL):
> Log file "stdout" content for test "05-tests/mypy.sh" (FAIL):
> qemu/utils/qom_common.py:96: error: Function is missing a type
> annotation [no-untyped-def]
> qemu/utils/qom_common.py:192: error: Function is missing a type
> annotation for one or more arguments [no-untyped-def]
> qemu/utils/qom.py:227: error: Bracketed expression "[...]" is not
> valid as a type [valid-type]
> qemu/utils/qom.py:227: note: Did you mean "List[...]"?
> Found 3 errors in 2 files (checked 22 source files)
> Log file "stderr" content for test "05-tests/mypy.sh" (FAIL):
> Log file "stdout" content for test "33-tests/pylint.sh" (FAIL):
> ************* Module /builds/qemu-project/qemu/python/setup.cfg
> setup.cfg:1:0: W0012: Unknown option value for '--disable', expected a
> valid pylint message and got 'too-many-positional-arguments'
> (unknown-option-value)
> ************* Module utils.qom
> qemu/utils/qom.py:244:23: C0121: Comparison 'value == None' should be
> 'value is None' (singleton-comparison)
> qemu/utils/qom.py:245:32: W1309: Using an f-string that does not have
> any interpolated variables (f-string-without-interpolation)
> qemu/utils/qom.py:35:0: W0611: Unused ExecuteError imported from
> qemu.qmp (unused-import)
> ************* Module utils.qom_common
> qemu/utils/qom_common.py:92:0: R0903: Too few public methods (1/2)
> (too-few-public-methods)
>
> https://gitlab.com/qemu-project/qemu/-/jobs/10682353448
>
> Please take a look and resend this pull request if fixes are necessary. Thanks!

Sorry about that.  I'm going to split this pull request: 29 unmodified
patches now, the three remaining as soon as they're ready.