All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Khalid Ali <khaliidcaliy@gmail.com>,
	peterz@infradead.org, luto@kernel.org
Cc: linux-kernel@vger.kernel.org, Khalid Ali <khaliidcaliy@gmail.com>
Subject: Re: [PATCH v2] kernel/entry: Remove some redundancy checks on syscall works
Date: Fri, 20 Jun 2025 23:20:22 +0200	[thread overview]
Message-ID: <87jz56p0tl.ffs@tglx> (raw)
In-Reply-To: <20250615082833.858-1-khaliidcaliy@gmail.com>

On Sun, Jun 15 2025 at 08:28, Khalid Ali wrote:

Same prefix comment as for the other patch.

> Use SYSCALL_WORK_SYSCALL_AUDIT to check if audit needs to be done
> instead of audit context for consistency to other syscall work bit
> checks.

This does not explain why this is correct. I explained it to you here:

     https://lore.kernel.org/all/87frg2q1w7.ffs@tglx

You also missed the fact that audit_syscall_entry() has yet another
check for audit context, which means there is still redundancy, right?

Thanks,

        tglx



  reply	other threads:[~2025-06-20 21:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-15  8:28 [PATCH v2] kernel/entry: Remove some redundancy checks on syscall works Khalid Ali
2025-06-20 21:20 ` Thomas Gleixner [this message]
2025-06-21  7:10   ` Khalid Ali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jz56p0tl.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=khaliidcaliy@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.