All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: Drop unused "pinctrl-names"
Date: Mon, 14 Apr 2025 16:32:55 +0200	[thread overview]
Message-ID: <87jz7mhkyw.fsf@BLaptop.bootlin.com> (raw)
In-Reply-To: <20250409204936.1521405-1-robh@kernel.org>

Hello Rob,

> "pinctrl-names" depends on "pinctrl-[0-9]" properties, but none are
> present for the pca9555 nodes.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  arch/arm64/boot/dts/marvell/armada-7040-db.dts | 1 -
>  arch/arm64/boot/dts/marvell/armada-8040-db.dts | 2 --
>  arch/arm64/boot/dts/marvell/cn9130-db.dtsi     | 1 -
>  3 files changed, 4 deletions(-)


Applied on mvebu/dt64

Thanks,

Gregory


>
> diff --git a/arch/arm64/boot/dts/marvell/armada-7040-db.dts b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> index 2b5e45d2c5a6..3add6506ff20 100644
> --- a/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> @@ -124,7 +124,6 @@ &cp0_i2c0 {
>  
>  	expander0: pca9555@21 {
>  		compatible = "nxp,pca9555";
> -		pinctrl-names = "default";
>  		gpio-controller;
>  		#gpio-cells = <2>;
>  		reg = <0x21>;
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> index 9d45e881a97d..21ecb9c12505 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> @@ -122,7 +122,6 @@ &cp0_i2c0 {
>  	/* U31 */
>  	expander0: pca9555@21 {
>  		compatible = "nxp,pca9555";
> -		pinctrl-names = "default";
>  		gpio-controller;
>  		#gpio-cells = <2>;
>  		reg = <0x21>;
> @@ -131,7 +130,6 @@ expander0: pca9555@21 {
>  	/* U25 */
>  	expander1: pca9555@25 {
>  		compatible = "nxp,pca9555";
> -		pinctrl-names = "default";
>  		gpio-controller;
>  		#gpio-cells = <2>;
>  		reg = <0x25>;
> diff --git a/arch/arm64/boot/dts/marvell/cn9130-db.dtsi b/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
> index be56a2336265..50e9e0724828 100644
> --- a/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
> +++ b/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
> @@ -209,7 +209,6 @@ i2c@1 {
>  			/* U12 */
>  			cp0_module_expander1: pca9555@21 {
>  				compatible = "nxp,pca9555";
> -				pinctrl-names = "default";
>  				gpio-controller;
>  				#gpio-cells = <2>;
>  				reg = <0x21>;
> -- 
> 2.47.2
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      reply	other threads:[~2025-04-14 14:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-09 20:49 [PATCH] arm64: dts: marvell: Drop unused "pinctrl-names" Rob Herring (Arm)
2025-04-14 14:32 ` Gregory CLEMENT [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jz7mhkyw.fsf@BLaptop.bootlin.com \
    --to=gregory.clement@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.