From: Markus Armbruster <armbru@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: yong.huang@smartx.com, qemu-devel@nongnu.org,
Fabiano Rosas <farosas@suse.de>, Eric Blake <eblake@redhat.com>
Subject: Re: [RFC] migration: Introduce migration throttle event
Date: Tue, 18 Feb 2025 20:21:59 +0100 [thread overview]
Message-ID: <87jz9n9hyg.fsf@pond.sub.org> (raw)
In-Reply-To: <Z7TOXfn6BQBhS5uG@x1.local> (Peter Xu's message of "Tue, 18 Feb 2025 13:15:57 -0500")
Peter Xu <peterx@redhat.com> writes:
> On Tue, Feb 18, 2025 at 10:39:55AM +0800, yong.huang@smartx.com wrote:
>> From: Hyman Huang <yong.huang@smartx.com>
>>
>> When the developer is examining the time distribution of
>> the migration, it is useful to record the migration throttle
>> timestamp. Consequently, include the migration throttle event.
>
> Would trace_cpu_throttle_set() work too? That can provide a timestamp and
> also the new percentage of throttle.
>
> I don't feel strongly that we must not introduce qmp events for debugging,
> but allowing that to happen means we can get tons of events at last.. as
> people can start requesting many more events, and we'll need one way to
> justify them at last.
>
> One way to justify events can be that it could be consumed by mgmt. On
> that, this one I'm not yet sure.. so ideally tracepoints could work already.
Good point.
next prev parent reply other threads:[~2025-02-18 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 2:39 [RFC] migration: Introduce migration throttle event yong.huang
2025-02-18 5:44 ` Markus Armbruster
2025-02-18 6:50 ` Yong Huang
2025-02-18 18:15 ` Peter Xu
2025-02-18 19:21 ` Markus Armbruster [this message]
2025-02-19 1:31 ` Yong Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jz9n9hyg.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=farosas@suse.de \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yong.huang@smartx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.