From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 365F8D3B985 for ; Tue, 26 Nov 2024 11:33:47 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.843635.1259247 (Exim 4.92) (envelope-from ) id 1tFtov-00061q-Kp; Tue, 26 Nov 2024 11:33:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 843635.1259247; Tue, 26 Nov 2024 11:33:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tFtov-00061j-I7; Tue, 26 Nov 2024 11:33:29 +0000 Received: by outflank-mailman (input) for mailman id 843635; Tue, 26 Nov 2024 11:33:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tFtou-00061B-4F for xen-devel@lists.xenproject.org; Tue, 26 Nov 2024 11:33:28 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062a.outbound.protection.outlook.com [2a01:111:f403:2612::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f32422b-abea-11ef-a0cd-8be0dac302b0; Tue, 26 Nov 2024 12:33:24 +0100 (CET) Received: from GV1PR03MB10456.eurprd03.prod.outlook.com (2603:10a6:150:16a::21) by DB8PR03MB6268.eurprd03.prod.outlook.com (2603:10a6:10:133::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8182.20; Tue, 26 Nov 2024 11:33:21 +0000 Received: from GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e]) by GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e%7]) with mapi id 15.20.8182.018; Tue, 26 Nov 2024 11:33:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f32422b-abea-11ef-a0cd-8be0dac302b0 X-Custom-Connection: eyJyZW1vdGVpcCI6IjJhMDE6MTExOmY0MDM6MjYxMjo6NjJhIiwiaGVsbyI6IkVVUjA1LUFNNi1vYmUub3V0Ym91bmQucHJvdGVjdGlvbi5vdXRsb29rLmNvbSJ9 X-Custom-Transaction: eyJpZCI6IjNmMzI0MjJiLWFiZWEtMTFlZi1hMGNkLThiZTBkYWMzMDJiMCIsInRzIjoxNzMyNjIwODA0LjU3MDI3Nywic2VuZGVyIjoidm9sb2R5bXlyX2JhYmNodWtAZXBhbS5jb20iLCJyZWNpcGllbnQiOiJ4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcifQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UtSVSopLYl6Q1isZ+eFqHaQsquY+lx5wjVB0hMNWBJpR7hRC8YM6EDO4+/lJUnn0cGF1/DeBkCdJyt9duIUqUqw8eyZmnnMOXgbcDskw3/bW7iBs841qSmL9g4BAmaH6AKuQ8/Mol6CnwfhgIxcBl4tz7iQEYjLWk2GScaluPdM6AQ5QLEHp3nl8eDTlvzIkyvwoFT5YtLXhq1covVlVXsNsHiyFKDG+X1/bowXAywbW5yIth4d4Kr8yBmrmccw3ZBAxatLM1d18D9EHZVuC3K9RxYgKcv2oIH38aXa+kj6//H0x9AGQTuBGA8lI5qGiGqYWM/MhQZDZjlcdpl1IAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BONro44LvlcrQMnwueHeP4LdW0F6v65BUBjlsnzObLs=; b=qqkRtW92XuYS1ScqfVz+oSdx2rebBnW2ykb9zV8M52j5o8PxAsr8eteU95GkSg90GZAzvMcuaC+AY5i8LHc9VIL1kDOT+17jPIVGShKV3aRirYD9fEBriEx6jitcrmlTntyA6CIPrdD4uLZtUS71Bgi30ENzTheLZwFjdKxulJx/qmas//jA2aU6oSn58U2UafZZEpVkSFZ3sfpFH+WQx+dtK7Dt8kVmUgxBDxvMnTbtwu3gBHbvgpHAi9OCD+fccBgQRLLynd2/jNpIqetNDmPYaDPT/jCC60aTgz4CD9aQyj0kz12Bh1a3Sq5VvGYfrSLKJy59sBIeWrTvG2Mw8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BONro44LvlcrQMnwueHeP4LdW0F6v65BUBjlsnzObLs=; b=l2cTUExw72QbAcNaFEa0xTk3gBDW5pNoXgNdf4HWqfQGmFJo0U4H0vy9mXNxaceNei0VzO0YxdtYyqyBG5ce1R4IPAY9ALrjMJ0a96DNd2RYF4DEzIsG4d0HAR5ZdJqv7v015Qio/AdsvZmaUy79gJ4Jr0Eo75oGkU2qwEOhGkHqeN5MuT/NXPtI7MwfcMut4jFEgk22EOjEn5UR66gY99KfuPR7ORejAMKj4SPDvGbabLAf6+puGMgR4R4NHxhnnfM09Vxr0f8OrtUF3lVk5mk/2nhSLNV89J5DUsQOPokaH+wRNw/Sg1V+1EevZGOtSoYoH3Wz6bjlcIEv1VjR7A== From: Volodymyr Babchuk To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Jan Beulich , Stefano Stabellini , Anthony PERARD , Samuel Thibault , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH 1/3] xen: common: add ability to enable stack protector Thread-Topic: [PATCH 1/3] xen: common: add ability to enable stack protector Thread-Index: AQHbPSKKCRg4722UIUuMGLA9PEEyZg== Date: Tue, 26 Nov 2024 11:33:20 +0000 Message-ID: <87jzcqjklc.fsf@epam.com> References: <20241122210719.2572072-1-volodymyr_babchuk@epam.com> <20241122210719.2572072-2-volodymyr_babchuk@epam.com> <20d65a5d-dfdc-4622-b066-fc6de705af57@xen.org> In-Reply-To: <20d65a5d-dfdc-4622-b066-fc6de705af57@xen.org> (Julien Grall's message of "Mon, 25 Nov 2024 20:36:22 +0000") Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: GV1PR03MB10456:EE_|DB8PR03MB6268:EE_ x-ms-office365-filtering-correlation-id: 3ce904ab-a2fe-4884-93ce-08dd0e0e217d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?k6H88EePXIuC2Fp6gOso5Yy8zvi78E/AnPI4VgQB5x1ZFVz7X1mIb3IzTB?= =?iso-8859-1?Q?iFhu1NPnUBYLHU55DHAtZbKrGevczBpbrl+rDAnBL1QaLZ9/Su3xMv7oqO?= =?iso-8859-1?Q?yhZUelnTpZtWBSbxi/d0v8jRvgpPNloVtDGuyysi1LLMmNvgMcPZIpiYZQ?= =?iso-8859-1?Q?iEf+5AOhIAJeXAml/vw2fFND0SLhb8IXEC2TXs8+tbar8mzczgOk1KpFh1?= =?iso-8859-1?Q?Ly+psvbnqicREWno9wlnBYwkuLYxPgVsPqP8TzJfxbMhglb/WKYhitT+mB?= =?iso-8859-1?Q?KVUNDP6Hn5gremNN7XpqzOYf/+Z9yt6TlNr1QcFlymkAclnpFeeHdnTsJl?= =?iso-8859-1?Q?9Vk3Bl/ijYRObytcdYF2NIWDQO15E2DOP1pcErtzudjbZN42wBe3A+EE2w?= =?iso-8859-1?Q?ZqQ5+S0Tg48MbZBFTLQbOvq6I7MNYvZ5Twj342Kt9RWZbmkOL7XJaIQWPn?= =?iso-8859-1?Q?3lHlX62UWAe4tKl13kuPKyudLpb/I0rBr0kn6DYay5Bf/sICmqhgIKt++m?= =?iso-8859-1?Q?ZQmNQC09fokXVU1XGoecolYS35pGQQo3OwT7aev/QVIx5oyCgToKGiErLs?= =?iso-8859-1?Q?ASabTTy4y7uMtL3J1iUf6xx2IcAzl0ROa7gVQ/GgAgcnmhOljruXax4SDy?= =?iso-8859-1?Q?1KzyxOKyKkBD6KL9aqEtmYn3kbONJvaXEznH6Z0fEc1yqW8MV9T90YCc71?= =?iso-8859-1?Q?iSPG2P/P6uPHOCwc1NWj6a8po6LiiOKDnnZlqxaZQQFgxDydAUcuYGPqBE?= =?iso-8859-1?Q?uxqUbfq+gsqS8IZey3NsyOhnLYMl6BWQZE6jOj/+CnUusa/sNGun1OUDGE?= =?iso-8859-1?Q?Yc+IkQe9q6iWxQe3cW6vhzwBH4Wrj13b/kUCOrX0yTohXxStjE2id3jcam?= =?iso-8859-1?Q?xGnVw0n3BEsdPvkuMSSxSmBTtNmg59N/UEEkCi8hv+tJkRecFuSUROXCjN?= =?iso-8859-1?Q?O4p32jIZRsW/GSBnhAF8rsUb6BfOgebD8miuJBk1722/L605o21dalQYUY?= =?iso-8859-1?Q?3IcMk8guB9IGJUtn9eI2Mzg1m7Wb7S7HpAQcIOaBiaYTvY+ef5M6M/Aqra?= =?iso-8859-1?Q?a+XYyJewaVIu0CQCcn6TZ/dLjSI+nZD0pvWDc69N920i/xhCaEfuRuqEAp?= =?iso-8859-1?Q?gWoJEDEGtRGFtwedhDw8lH6Jfzk0JeXDjxzDiWu83qJTbVAebcN98ZpdKK?= =?iso-8859-1?Q?REd0epBGuHuU17jL75h1i2VE+On9VK8JkX4YuQ+8qGzdADfTH6m4VNkOlK?= =?iso-8859-1?Q?W2m2IvcEzEGP3Gg7Q5dLSKjses3bystQSe15nBNBVbJyozfEyIoxe8PeOm?= =?iso-8859-1?Q?9bB/kIu7ExivN3auZbaylu0hhxoimcfIlQvKMcZgcCJMJ2Gc5rxWUzCQg3?= =?iso-8859-1?Q?VfYsVHyLQ/aZid24/w5vwAg9SkWqu+ZxpDxGg8Y/67/DxutmpEOOCEMjUC?= =?iso-8859-1?Q?tPoOA5sB0Tb3zxdmTIClE4cGNR/4HcEHcJyYpQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV1PR03MB10456.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Z7TK97Ejggm2OQqFA8uz9kWRsqTTzAxFfn0oLJ37HiI6bL4WY0b6a/Hnak?= =?iso-8859-1?Q?zCTykKB6uEqKMQbg0XOkNl61t9gHU9lmZXci/Rg2PnrYf915d6r8EGqS5P?= =?iso-8859-1?Q?BOGXVbvTJBcGandE/hOCV+z71clJx4yiDLNje9SIbvtfo3r9DtBjnscCAY?= =?iso-8859-1?Q?P8xK272Fu5oSoLdXpvCgEweDwKIaj9vo9kEu+8kmm9CE/HKQzLr3/oJVAr?= =?iso-8859-1?Q?M2FCHX2i4mCAD+LiPbIxFNKNHwHWKPZR40VthSZgO1BZw4+hKIt5kZS6bv?= =?iso-8859-1?Q?PaOFtyr70tvJ83zYNgOHfUIxSS1ggN8YZZ2WUBZzsXyQ6sW1cN1yTqhy7t?= =?iso-8859-1?Q?ZxSNTyPJzDqWawB3q/c0gUeylX6KORwWUJYxOArfErr/ERQAntGCbUnMCl?= =?iso-8859-1?Q?91ErUS+2vXlhiw0HvvZS0mbIduoaM2HhL51d09PbyyoxHcB5tBIfL/WiB1?= =?iso-8859-1?Q?TdYsdBre+Avg3R3KZp3BNiUBq9zmGWdblReCpSRPp6HpwPv16f8ysNlXMp?= =?iso-8859-1?Q?kx49zMgfxZohPRpe7V+b2WRIa/O8Iau1+nGjH4bsxjyGVfLqJyiYjka/oB?= =?iso-8859-1?Q?A0zmOPrlTEPw3PM04s2d1UJ0rQxD57az4CvkEE1xhl1YRvfv+LnEuSsO6Z?= =?iso-8859-1?Q?vMJ7xMEKTsW35hzPeR0uKD1xs9Tvfy8Jk0Xvdit+OejUwnUfq6wX6K9ESg?= =?iso-8859-1?Q?5Z7uG2d+sJTU23QIC7ePuNsSaZzRR9SgL04Y5Xrdnd7CXXAxcsdTp4eayr?= =?iso-8859-1?Q?r6Vvv6BFriIPpZhkheTyXkWxz7773yMz4ewQE6/bDRqfaDmkskf+Ki50es?= =?iso-8859-1?Q?IlZZTEZ1CHmZNiECZO3eGYdeqdHLsJGlXBGx7hg3CLEGkxoCGo4nu43/+q?= =?iso-8859-1?Q?ylQhNjgIZcj1rJF6UYlCD+KfIiAnEWqYWV3JdA6bJkgsCkkTzwrjW+R3Jo?= =?iso-8859-1?Q?cSXs31KnFs2o8/LEyZd3h8H9nsPDMM6C1lRNCymWooaYHzC1aWH5BoyE2U?= =?iso-8859-1?Q?YKLWjTw8BKH9xaH0JVNb3FBPW8/miNekrZwnvMYDWfAmH/84Oos+8j9UFw?= =?iso-8859-1?Q?gRphx11tydoGAL/r5DPgYemB636vEBl2Y/8UioQqval8ID4hmuLQWhajqF?= =?iso-8859-1?Q?xeMxCIp+Rvu1qKnu3TtrkUbJnAm/LyOC+BA5cqGEjcy5NI8QvT2pHaHhut?= =?iso-8859-1?Q?fRil9xfG9oY8ONNM6Yyl75298vTSrX2jG4H6ViEGI+UgC8/F0Sj6mgKJGv?= =?iso-8859-1?Q?dOxZHc/hllFO/USDP6d7Lhcp63nl8pNJ0eXZUJ1uLu3Z9LyQ24v8QGeZW3?= =?iso-8859-1?Q?w7aO8+HnxjpfWaa7WfLEy4mIP9eIRZMYftZ2rHRubHyHUUmT/FbpJbFE+Y?= =?iso-8859-1?Q?biLifyyZpuhEMTaQRgXZbPquZIRL9zWxoXpJYAPzoiQN9zgpYZ2rl9fQvC?= =?iso-8859-1?Q?Q3DUdIbzC7jyJ7lfntIZZ/Y2vZ+hTwPducRGQItJAff4lEIiOdxhkDK12v?= =?iso-8859-1?Q?vYSSf6WWlOt1a5vDvykqCynIttweLZaccVnV6St7wDY5OsN4FTrMcMJuqG?= =?iso-8859-1?Q?cm74xDq/fCRSk7PcTTD55njmra7bDuEi8mydBvgpDrsAtG3chhAht0edla?= =?iso-8859-1?Q?j9b1kOZ+94N/sWFKTK82O0euCGBeTORgR3k+TdgABQ7uD9l4HmS1TyGQ?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: GV1PR03MB10456.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ce904ab-a2fe-4884-93ce-08dd0e0e217d X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2024 11:33:21.0140 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j5jaidGfYK+mz80cWXpVNzc13Ch2NMKUX9/BXyNKFHcFH6EnmzOgzhknoohOcr7Gk3wwGqotu5a+F4J6EV8qZzRBisgdmY+lEyJo2DFpMz4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR03MB6268 Hi Julien, Julien Grall writes: > Hi, > > Hi Volodymyr, > > On 22/11/2024 21:07, Volodymyr Babchuk wrote: >> diff --git a/xen/include/xen/stack_protector.h b/xen/include/xen/stack_p= rotector.h >> new file mode 100644 >> index 0000000000..97f1eb5ac0 >> --- /dev/null >> +++ b/xen/include/xen/stack_protector.h >> @@ -0,0 +1,30 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> + >> +#ifndef XEN__STACK_PROTECTOR_H >> +#define XEN__STACK_PROTECTOR_H >> + >> +#ifdef CONFIG_STACKPROTECTOR >> + >> +#ifndef CONFIG_X86 >> +extern unsigned long __stack_chk_guard; > > Is this variable meant to change after boot? If not, then can you tag > it with __ro_after_init? > No, changing it after boot will lead to a random panic. So yes, it is good idea to make it RO. --=20 WBR, Volodymyr=