From: "Alex Bennée" <alex.bennee@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, manos.pitsidianakis@linaro.org,
kwolf@redhat.com, junjie.mao@hotmail.com, zhao1.liu@intel.com,
qemu-rust@nondevel.org
Subject: Re: [RFC PATCH 00/11] rust: improved integration with cargo
Date: Thu, 14 Nov 2024 15:22:03 +0000 [thread overview]
Message-ID: <87jzd5suw4.fsf@draig.linaro.org> (raw)
In-Reply-To: <CABgObfZT_jYJqKDnTAdrVjr9KdQXjNVEt2eQfDpoqrh6xEnVsQ@mail.gmail.com> (Paolo Bonzini's message of "Thu, 14 Nov 2024 14:11:25 +0100")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On Thu, Nov 14, 2024 at 2:07 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>> > First, while it is currently possible to run cargo on the rust/ directory,
>> > it has the issue that the bindings.rs must be placed by hand in
>> > the build directory. Therefore, this series starts by allowing
>> > cargo to "just work" when run in a "meson devenv" environment:
>> >
>> > meson devenv -w ../rust cargo clippy --tests
>> > meson devenv -w ../rust cargo fmt
>>
>> Is this meant to be the rust source root, or the root of the rust
>> builddir:
>>
>> $ meson devenv ../../rust
>
> rust/ in the source directory. You also need to run "meson devenv"
> from the root of the build directory.
>
> In practice you can just use "make clippy" or similar.
make clippy certainly works
>> ERROR: Build data file './meson-private/build.dat' references
>> functions or classes that don't exist. This probably means that it
>> was generated with an old version of meson. Try running from the
>> source directory meson setup . --wipe
>> 🕙13:05:22 alex@draig:qemu.git/builds/rust on review/rust-cargo-rfc [$!?] [🔴 ERROR]
>> $ meson devenv rust
>
> Your meson-private/ directory is stale. Any "make" or "ninja" invocation will
> fix it.
✗ make -j30
[1/53] Generating tests/include/QAPI test (include) with a custom command
[2/21] Generating rust_arm_softmmu.rs with a custom command (wrapped by meson to capture output)
[3/21] Generating rust_aarch64_softmmu.rs with a custom command (wrapped by meson to capture output)
[4/21] Generating qemu-version.h with a custom command (wrapped by meson to capture output)
🕙15:18:58 alex@draig:qemu.git/builds/rust on review/rust-cargo-rfc [$!?]
➜ meson devenv ../../rust
ERROR: Build data file './meson-private/build.dat' references functions or classes that don't exist. This probably means that it was generated with an old version of meson. Try running from the source directory meson setup . --wipe
I also tried a wipe and re-configure but the same thing.
➜ ls -la meson-private/
total 24768
drwxr-xr-x 4 alex alex 4096 Nov 14 15:20 ./
drwxr-xr-x 77 alex alex 4096 Nov 14 15:21 ../
-rw-r--r-- 1 alex alex 7569 Nov 14 15:20 aarch64-softmmu-config-devices.mak.d
-rw-r--r-- 1 alex alex 7084 Nov 14 15:20 arm-softmmu-config-devices.mak.d
-rw-r--r-- 1 alex alex 1877658 Nov 14 15:20 build.dat
-rw-r--r-- 1 alex alex 27208 Nov 14 15:20 cleantrees.dat
drwxr-xr-x 3 alex alex 4096 Nov 14 15:20 __CMake_compiler_info__/
drwxr-xr-x 3 alex alex 4096 Nov 14 15:20 cmake_libcbor/
-rw-r--r-- 1 alex alex 162 Nov 14 15:20 cmd_line.txt
-rw-r--r-- 1 alex alex 333651 Nov 14 15:20 coredata.dat
-rw-r--r-- 1 alex alex 24920 Nov 14 15:20 install.dat
-rw-r--r-- 1 alex alex 19049522 Nov 14 15:20 libsanity.a
-rw-r--r-- 1 alex alex 1748 Nov 14 15:20 meson_benchmark_setup.dat
-rw-r--r-- 1 alex alex 0 Nov 14 15:20 meson.lock
-rw-r--r-- 1 alex alex 140166 Nov 14 15:20 meson_test_setup.dat
-rwxr-xr-x 1 alex alex 3826912 Nov 14 15:20 rusttest*
-rw-r--r-- 1 alex alex 46 Nov 14 15:20 sanitycheckc.c
-rwxr-xr-x 1 alex alex 15840 Nov 14 15:20 sanitycheckc.exe*
-rw-r--r-- 1 alex alex 30 Nov 14 15:20 sanity.rs
🕙15:21:27 alex@draig:qemu.git/builds/rust on review/rust-cargo-rfc [$!?]
➜ meson devenv ../../rust
ERROR: Build data file './meson-private/build.dat' references functions or classes that don't exist. This probably means that it was generated with an old version of meson. Try running from the source directory meson setup . --wipe
🕙15:21:43 alex@draig:qemu.git/builds/rust on review/rust-cargo-rfc [$!?] [🔴 ERROR]
✗
>
> Paolo
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2024-11-14 15:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 18:01 [RFC PATCH 00/11] rust: improved integration with cargo Paolo Bonzini
2024-11-08 18:01 ` [RFC PATCH 01/11] rust: qemu_api: do not disable lints outside bindgen-generated code Paolo Bonzini
2024-11-12 2:25 ` Junjie Mao
2024-11-12 5:33 ` Paolo Bonzini
2024-11-12 10:10 ` Junjie Mao
2024-11-12 18:47 ` Paolo Bonzini
2024-11-13 6:46 ` Junjie Mao
2024-11-13 10:41 ` Paolo Bonzini
2024-11-08 18:01 ` [RFC PATCH 02/11] rust: build: move rustc_args.py invocation to individual crates Paolo Bonzini
2024-11-12 3:02 ` Junjie Mao
2024-11-08 18:01 ` [RFC PATCH 03/11] rust: build: restrict --cfg generation to only required symbols Paolo Bonzini
2024-11-08 18:01 ` [RFC PATCH 04/11] rust: build: generate warning flags from Cargo.toml Paolo Bonzini
2024-11-08 18:01 ` [RFC PATCH 05/11] rust: cargo: store desired warning levels in workspace Cargo.toml Paolo Bonzini
2024-11-12 3:12 ` Junjie Mao
2024-11-12 5:28 ` Paolo Bonzini
2024-11-12 5:40 ` Junjie Mao
2024-11-08 18:01 ` [RFC PATCH 06/11] rust: build: move strict lints handling to rustc_args.py Paolo Bonzini
2024-11-08 18:01 ` [RFC PATCH 07/11] rust: fix a couple style issues from clippy Paolo Bonzini
2024-11-13 6:59 ` Junjie Mao
2024-11-08 18:01 ` [RFC PATCH 08/11] rust: build: establish a baseline of lints across all crates Paolo Bonzini
2024-11-13 7:14 ` Junjie Mao
2024-11-13 10:02 ` Paolo Bonzini
2024-11-13 10:13 ` Junjie Mao
2024-11-08 18:01 ` [RFC PATCH 09/11] rust: build: add "make clippy", "make rustfmt" Paolo Bonzini
2024-11-13 7:20 ` Junjie Mao
2024-11-08 18:01 ` [RFC PATCH 10/11] rust: fix doc test syntax Paolo Bonzini
2024-11-13 7:22 ` Junjie Mao
2024-11-08 18:01 ` [RFC PATCH 11/11] rust: ci: add job that runs Rust tools Paolo Bonzini
2024-11-08 18:12 ` Daniel P. Berrangé
2024-11-14 13:07 ` [RFC PATCH 00/11] rust: improved integration with cargo Alex Bennée
2024-11-14 13:11 ` Paolo Bonzini
2024-11-14 15:22 ` Alex Bennée [this message]
2024-11-14 15:38 ` Paolo Bonzini
2024-11-14 17:27 ` Alex Bennée
2024-11-14 18:18 ` Paolo Bonzini
2024-11-14 21:13 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzd5suw4.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=junjie.mao@hotmail.com \
--cc=kwolf@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nondevel.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.