From: Thomas Gleixner <tglx@linutronix.de>
To: David Wang <00107082@163.com>
Cc: linux-kernel@vger.kernel.org, David Wang <00107082@163.com>
Subject: Re: [PATCH 01/13] kernel/irq/proc: use seq_put_decimal_ull_width() for decimal values
Date: Wed, 13 Nov 2024 20:10:08 +0100 [thread overview]
Message-ID: <87jzd7kl0v.ffs@tglx> (raw)
In-Reply-To: <20241108160717.9547-1-00107082@163.com>
On Sat, Nov 09 2024 at 00:07, David Wang wrote:
> The improvement has pratical significance, considering many monitoring
> tools would read /proc/interrupts periodically.
I've applied this, but ...
looking at a 256 CPU machine. /proc/interrupts provides data for 560
interrupts, which amounts to ~1.6MB data size.
There are 560 * 256 = 143360 interrupt count fields. 140615 of these
fields are zero, which means 140615 * 11 bytes. That's 96% of the
overall data size. The actually useful information is less than
50KB if properly condensed.
I'm really amused that people spend a lot of time to improve the
performance of /proc/interrupts instead of actually sitting down and
implementing a proper new interface for this purpose, which would make
both the kernel and the tools faster by probably several orders of
magnitude.
Thanks,
tglx
next prev parent reply other threads:[~2024-11-13 19:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 16:07 [PATCH 01/13] kernel/irq/proc: use seq_put_decimal_ull_width() for decimal values David Wang
2024-11-13 16:44 ` [tip: irq/core] genirq/proc: Use " tip-bot2 for David Wang
2024-11-13 19:10 ` Thomas Gleixner [this message]
2024-11-14 12:10 ` [PATCH 01/13] kernel/irq/proc: use " David Wang
2024-11-19 19:55 ` Geert Uytterhoeven
2024-11-20 1:20 ` Thomas Gleixner
2024-11-20 1:36 ` David Wang
2024-11-20 4:24 ` David Wang
2024-11-26 17:40 ` Thomas Gleixner
2024-11-27 0:07 ` David Wang
2024-11-20 8:56 ` Geert Uytterhoeven
2024-12-03 10:40 ` [PATCH] genirq/proc: Add missing space separator back Thomas Gleixner
2024-12-03 11:19 ` David Wang
2024-12-03 11:21 ` [PATCH] " Geert Uytterhoeven
2024-12-03 13:56 ` Thomas Gleixner
2024-12-03 14:11 ` [tip: irq/urgent] " tip-bot2 for Thomas Gleixner
2024-11-20 1:37 ` [PATCH 01/13] kernel/irq/proc: use seq_put_decimal_ull_width() for decimal values David Wang
2024-11-20 2:08 ` David Wang
2024-11-20 9:00 ` Geert Uytterhoeven
2024-11-20 9:36 ` David Wang
2024-11-20 9:56 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzd7kl0v.ffs@tglx \
--to=tglx@linutronix.de \
--cc=00107082@163.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.