RE: [PATCH v3] drm/i915/display: use x100 version for full version and release

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 30 Oct 2024, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote:
>> -----Original Message-----
>> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani
>> Nikula
>> Sent: Tuesday, October 29, 2024 9:26 PM
>> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
>> Cc: Nikula, Jani <jani.nikula@intel.com>; ville.syrjala@linux.intel.com; Roper,
>> Matthew D <matthew.d.roper@intel.com>; De Marchi, Lucas
>> <lucas.demarchi@intel.com>
>> Subject: [PATCH v3] drm/i915/display: use x100 version for full version and
>> release
>>
>> Use x100, or ver * 100 + rel, versions for full IP version checks, similar to what
>> xe driver does:
>>
>> - Replace IP_VER(14, 1) inline with 1401, etc.
>>
>> - Convert DISPLAY_VER_FULL() to DISPLAY_VERx100()
>>
>> - Convert IS_DISPLAY_VER_FULL() to IS_DISPLAY_VERx100()
>>
>> - Convert IS_DISPLAY_VER_STEP() to IS_DISPLAY_VERx100_STEP()
>>
>> This makes ver.rel versions easier to use, follows the xe driver pattern, and
>> drops the dependency on the IP_VER() macro.
>>
>> v2: Rebase, drop IP_VER() from xe compat headers
>>
>> v3: Rebase
>>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Acked-by: Matt Roper <matthew.d.roper@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> LGTM,
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

Thanks for the review, pushed to din.

BR,
Jani.


-- 
Jani Nikula, Intel