From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Baochen Qiang <quic_bqiang@quicinc.com>,
<ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<kernel@quicinc.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath12k: use 128 bytes aligned iova in transmit path for WCN7850
Date: Mon, 05 Aug 2024 12:36:02 +0300 [thread overview]
Message-ID: <87jzgv71ml.fsf@kernel.org> (raw)
In-Reply-To: <90077fb2-42e0-42ab-b5a1-b4b73ff201d5@quicinc.com> (Jeff Johnson's message of "Thu, 1 Aug 2024 11:04:18 -0700")
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>>> @@ -279,6 +334,23 @@ int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif,
>>> goto fail_remove_tx_buf;
>>> }
>>>
>>> + if (iova_mask &&
>>> + (unsigned long)skb->data & iova_mask) {
>>> + ret = ath12k_dp_tx_align_payload(ab, &skb);
>>> + if (ret) {
>>> + dev_warn_once(ab->dev, "failed to align TX buffer %d\n", ret);
>>
>> Why dev_warn_once()? I changed it to ath12k_warn() in the pending
>> branch.
>
> My concern was that if this is an ongoing issue that you'd end up spamming the
> kernel log. But I guess the rate limiting will reduce the spam to no more than
> 10 logs in a 5 second interval
Yeah, ratelimiting used by ath12k_warn() should be safe. It would be
consistent to have ath12k_warn_once() instead of using dev_warn_once()
but in this it's better to print the warning more than once so that
users don't miss it.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-08-05 10:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 2:38 [PATCH] wifi: ath12k: use 128 bytes aligned iova in transmit path for WCN7850 Baochen Qiang
2024-07-19 13:07 ` Mark Pearson
2024-08-01 15:20 ` Kalle Valo
2024-07-19 14:10 ` Jeff Johnson
2024-07-22 6:54 ` Baochen Qiang
2024-07-22 7:02 ` Baochen Qiang
2024-08-01 15:22 ` Kalle Valo
2024-08-01 15:07 ` Kalle Valo
2024-08-01 18:04 ` Jeff Johnson
2024-08-05 9:36 ` Kalle Valo [this message]
2024-08-05 3:20 ` Baochen Qiang
2024-08-05 9:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzgv71ml.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=kernel@quicinc.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quic_bqiang@quicinc.com \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.