From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 129EDC25B10 for ; Fri, 10 May 2024 10:19:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HdLwLRezpbpLc5Y5woJvH2iRdrpUS+IvCCacbvAo21o=; b=H8O0F6n7kxyAa9ZkxyvqmhuioL GTkzBhuMo0U4y6LNMkBTO6svzZkkJi6QrW4O+a+fyWKnT8JuFCL5eHMTLs24bh1eOtz+vjeDc6W+m 9WtPCyn6ULxgnDgo1EsfU7s6TMqZS0Ccg7jOxyBCgxfQqSstd3FVzy3nn3W5tSCk3+XWO1Pf/4150 EIDZDsJaHSx7ONkyWtsX30EUElt8e/5Xh6HG7R3ybyBHMtdUPD9hxUol64pIVTiHxDsVd+Zy8OyNI uNbaJ/v11LxU63fZINngd0L9RWZl2lDO+R5y6ww7sEtneHeBxOEp5mLNRppq9N3W7Hnfbpxc9r3N4 dlpAsmmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5NLC-00000004qTz-2aJs; Fri, 10 May 2024 10:19:02 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5NL9-00000004qSc-3i5v for ath11k@lists.infradead.org; Fri, 10 May 2024 10:19:01 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D4CBD61E43; Fri, 10 May 2024 10:18:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 573D9C32783; Fri, 10 May 2024 10:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715336338; bh=Yiu+qkyJjBmS6HAy7q+jESZdM+IpPiaNYPekdHCehtE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=a23nI+g4n1oFGG/z7seERI3vuJEHB65S2SinVvd9/DkwNDlh/i8EvTXTsrED695cr iXJ0hgWJuJ4uNJiHmk37g+XDhLIe+YqJcIlB6126AQhF88h6lvkA5P2LL3+ByQxziA SL2ce8BMpstt1K08z/XFk5puZLq0J3EVMdm86fkwQWn/VcbcSBO3a1b1MY8vb6is30 THuGraOiNB5pdZ18cjqwIbfUACx0CXqXlZBPQ1Q1RGIGnyZ8ZaVNY3SbXHeOB63dka 0tmUua8EcJH9j3ljGBfPA30Xgxy8sQdGbT7wBNUoNIv+rWYRht4WrJdrFJyRz/1nIX HSjrtFysFXnHw== From: Kalle Valo To: "Luca Weiss" Cc: "Carl Huang" , , , regressions@lists.linux.dev Subject: Re: [PATCH 1/2] wifi: ath11k: supports 2 station interfaces References: <20230714023801.2621802-1-quic_cjhuang@quicinc.com> <20230714023801.2621802-2-quic_cjhuang@quicinc.com> Date: Fri, 10 May 2024 13:18:55 +0300 In-Reply-To: (Luca Weiss's message of "Fri, 10 May 2024 10:22:50 +0200") Message-ID: <87jzk2km0g.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240510_031900_021428_F88C74EC X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org "Luca Weiss" writes: > On Fri Jul 14, 2023 at 4:38 AM CEST, Carl Huang wrote: >> Add hardware parameter support_dual_stations to indicate >> whether 2 station interfaces are supported. For chips which >> support this feature, limit total number of AP interface and >> mesh point to 1. The max interfaces are 3 for such chips. >> >> The chips affected are: >> QCA6390 hw2.0 >> WCN6855 hw2.0 >> WCN6855 hw2.1 >> Other chips are not affected. >> >> For affected chips, remove radar_detect_widths because now >> num_different_channels is set to 2. radar_detect_widths can >> be set only when num_different_channels is 1. See mac80211 >> function wiphy_verify_combinations for details. >> >> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3 > > Hi Carl, > > Unfortunately this commit breaks wifi on a QCM6490 smartphone > (qcm6490-fairphone-fp5) and makes the board crash. > > Reverting this commit (plus for conflict resolution 5dc9d1a55e95 ("wifi: > ath11k: add support for QCA2066") and 24395ec11707 ("wifi: ath11k: > provide address list if chip supports 2 stations")) makes wifi work > again. Thanks for the report. So the broken commit is: f019f4dff2e4 wifi: ath11k: support 2 station interfaces This went into v6.9-rc1 so I'm guessing that WCN6750 support will be fully broken in v6.9? Not good. And most likely Linus will release v6.9 on Sunday so it's too late to get a fix included in the final release. Carl, can you fix this ASAP? Or should we just revert the broken commits? Adding this to our regression tracking: #regzbot introduced: f019f4dff2e4 ^ #regzbot title: ath11k: WCN6750 firmware crashes during initialisation -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches