From: Takashi Iwai <tiwai@suse.de>
To: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Cc: Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
linux-sound@vger.kernel.org
Subject: Re: regression/bisected/6.9 commit 587d67fd929ad89801bcc429675bda90d53f6592 decrease 30% of gaming performance
Date: Wed, 24 Apr 2024 15:42:34 +0200 [thread overview]
Message-ID: <87jzkmdghh.wl-tiwai@suse.de> (raw)
In-Reply-To: <87pluedgx5.wl-tiwai@suse.de>
On Wed, 24 Apr 2024 15:33:10 +0200,
Takashi Iwai wrote:
>
> On Wed, 24 Apr 2024 15:21:26 +0200,
> Mikhail Gavrilov wrote:
> >
> > On Thu, Apr 18, 2024 at 11:22 AM Mikhail Gavrilov
> > <mikhail.v.gavrilov@gmail.com> wrote:
> > >
> > > On Tue, Apr 2, 2024 at 12:29 AM <mikhail.v.gavrilov@gmail.com> wrote:
> > > >
> > > > On Mon, 2024-04-01 at 21:50 +0500, Mikhail Gavrilov wrote:
> > > > > On Mon, Apr 1, 2024 at 7:48 PM Takashi Iwai <tiwai@suse.de> wrote:
> > > > > >
> > > > > >
> > > > > > Then it shouldn't be dmix/dsnoop. You'd better try profiling
> > > > > > what's
> > > > > > going on there. e.g. try to get perf results with and without the
> > > > > > commit.
> > > > >
> > > > >
> > > > > Here is original perf files:
> > > > > [1] perf-with-revert-587d67fd929a.data -
> > > > > https://mega.nz/file/EpZmXbgL#vEnxuODoB__jM6TwV6XbwC_TWMMqvT7qaWkJU22JY48
> > > > > [2] perf-with-revert-587d67fd929a-beb45974dd49.data -
> > > > > https://mega.nz/file/0lI31CDA#hKsv6vX7t5u-Sx1_p2E7-Y32-z5VFPlW2Y793oM-JRU
> > > > >
> > >
> > > Excuse me. Can you have time to look in my perf files?
> > >
> >
> > This is a friendly reminder
>
> Honestly speaking, it's your role to analyze what's going on.
> Such a performance issue is pretty much dependent on the installed
> system, so giving a perf data to me won't help much, unfortunately.
That said, maybe the first thing you can try would be to check who is
actually calling the corresponding function
(snd_timer_close_locked()). Put a debug print or a tracing hook to
watch out for figuring out. If the commit was really relevant, it
must be called very frequently and concurrently, and I don't know
really who does it except for dmix/dsnoop.
Takashi
next prev parent reply other threads:[~2024-04-24 13:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 20:21 regression/bisected/6.9 commit 587d67fd929ad89801bcc429675bda90d53f6592 decrease 30% of gaming performance Mikhail Gavrilov
2024-04-01 7:07 ` Takashi Iwai
2024-04-01 11:07 ` Mikhail Gavrilov
2024-04-01 11:41 ` Takashi Iwai
2024-04-01 13:49 ` Mikhail Gavrilov
2024-04-01 14:48 ` Takashi Iwai
2024-04-01 16:50 ` Mikhail Gavrilov
2024-04-01 19:29 ` mikhail.v.gavrilov
2024-04-18 6:22 ` Mikhail Gavrilov
2024-04-24 13:21 ` Mikhail Gavrilov
2024-04-24 13:33 ` Takashi Iwai
2024-04-24 13:42 ` Takashi Iwai [this message]
2024-04-29 23:00 ` Mikhail Gavrilov
2024-04-30 5:51 ` Takashi Iwai
2024-04-30 10:54 ` Mikhail Gavrilov
2024-04-30 12:12 ` Takashi Iwai
2024-04-30 14:42 ` Mikhail Gavrilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzkmdghh.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mikhail.v.gavrilov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.