From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1rfhc3-00024s-QA for mharc-qemu-trivial@gnu.org; Thu, 29 Feb 2024 09:42:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfhby-00021c-Q4 for qemu-trivial@nongnu.org; Thu, 29 Feb 2024 09:42:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfhbw-0001HO-9w for qemu-trivial@nongnu.org; Thu, 29 Feb 2024 09:42:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709217731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i1QgDldSsCJtxeJ0IjtTCPbiOKSp6fBTys1FmNx1zCs=; b=LB3ImcIayNEEzmuBofXPEci4u/J5gSHtcjSytEe0X7MWOaMjnz0rHlRrXO2uqwOiKFgyo7 Lr7ALmdcMyB/XYj5GbOhqxiaPpiMDmfxyifjovzdO+NJii6sFopKXK2jKkrpWqxfOoOWsz Bi6yTlT7kg1wGGmYVeySH9eOXARB3xc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-513-MbFVY4TEMDu_Od64SNMAlQ-1; Thu, 29 Feb 2024 09:42:07 -0500 X-MC-Unique: MbFVY4TEMDu_Od64SNMAlQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AB1DE85A588; Thu, 29 Feb 2024 14:42:06 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7314820229A4; Thu, 29 Feb 2024 14:42:06 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4C95C21E6767; Thu, 29 Feb 2024 15:42:05 +0100 (CET) From: Markus Armbruster To: Zhao Liu Cc: Michael Roth , Michael Tokarev , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Zhao Liu Subject: Re: [PATCH 01/16] error: Add error_vprepend() in comment of ERRP_GUARD() rules In-Reply-To: <20240228163723.1775791-2-zhao1.liu@linux.intel.com> (Zhao Liu's message of "Thu, 29 Feb 2024 00:37:08 +0800") References: <20240228163723.1775791-1-zhao1.liu@linux.intel.com> <20240228163723.1775791-2-zhao1.liu@linux.intel.com> Date: Thu, 29 Feb 2024 15:42:05 +0100 Message-ID: <87jzmnuybm.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.096, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Feb 2024 14:42:15 -0000 Zhao Liu writes: > From: Zhao Liu > > The error_vprepend() should use ERRP_GUARD() just as the documentation > of ERRP_GUARD() says: > >> It must be used when the function dereferences @errp or passes >> @errp to error_prepend(), error_vprepend(), or error_append_hint(). > > Considering that error_vprepend() is also an API provided in error.h, > it is necessary to add it to the description of the rules for using > ERRP_GUARD(). > > Signed-off-by: Zhao Liu > --- > include/qapi/error.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/qapi/error.h b/include/qapi/error.h > index f21a231bb1a6..b1b389967f92 100644 > --- a/include/qapi/error.h > +++ b/include/qapi/error.h > @@ -207,7 +207,7 @@ > * > * Without ERRP_GUARD(), use of the @errp parameter is restricted: > * - It must not be dereferenced, because it may be null. > - * - It should not be passed to error_prepend() or > + * - It should not be passed to error_prepend(), error_vprepend() or > * error_append_hint(), because that doesn't work with &error_fatal. > * ERRP_GUARD() lifts these restrictions. > * Good catch! I'd like a comma after error_vprepend(). Reviewed-by: Markus Armbruster