From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D56BC48BC4 for ; Tue, 20 Feb 2024 20:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U0hqHSw9Ck63Hhhy5oAyuQNlF21Fzl0WqcY/QQqSMBI=; b=5CKlDjvGsAyIhk F4ICjuaCIU2c79/wp9f6rcr3hcyZSIv8PEYSfBH0lGQ9lYCMJPuyxEASLDlXn/b/CTYH1DfJZ982C SLjdNsD8GePk1wasm3XzT78u+6+nUzpBeI2z5ejDPJF8QlcDISM7VL4LiG9bOR7lD6RREkqsxIbKC RRi9ngtuh367/QjezWaJitgzGz1YrQaeKSGGnBWm3NTmaVZ90rZygbVDOdLBHsQl+XH6/ql8k13h1 IEvUb1GIMi5JhTxr4vrlDj0GQ6Vk4FFUavpKYzI53LiQkfjUvHzqpIOA5y9+CtfDdE5vJvMAWqQYa meeqnE6zC1bPoTdYM20Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcWLJ-0000000G32g-2Lpk; Tue, 20 Feb 2024 20:03:53 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcWLE-0000000G2zj-2Vzk; Tue, 20 Feb 2024 20:03:51 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1708459424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jJRsPsyZ6zDS1QWFQN2wLBFM6mS+0QImDjTMgSPiL7I=; b=aYQmsEOwQopLCUpYpAQuDyrIpn/ZjclA2riggfw0WWir8TT6NmiPQZJzpeC9YRHKgp0rWt k9TQyzVThpxVBDmox2nnESsknS5oTRd4VzFt0IU9vtyq1EJQHNR2c8XYNJ501UxxiXHAvM kXdsE5fN2sy9MVO94uyCUiwX4v8h1pq6bevWl8yrwk+XqoCaj9mBmXHCJGdlZPtLIuvqLX 3q+Zma5P0XbwLUpcToklgoNTEsCISC+ORpEWQc1gQ0abV9ucGF0qXfXXUnwwqsBvpXZvEQ 4wLIzGkKNOg+Vur2e3RHi5rEfoxeWqrJBnwmSEj0b/eNkGMG09MxRmsKO7Z1XQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1708459424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jJRsPsyZ6zDS1QWFQN2wLBFM6mS+0QImDjTMgSPiL7I=; b=0bZpy8Ucv4te6DfmhFa1QQKyXrhJJterh1+UZ0hC/H+1QXta7TTSsn4wIZdFftqnZDB7KQ v4NtqSu0q+WZZFDw== To: Anup Patel Subject: Re: [PATCH v13 08/13] irqchip/riscv-imsic: Add device MSI domain support for PCI devices In-Reply-To: References: <20240220060718.823229-1-apatel@ventanamicro.com> <20240220060718.823229-9-apatel@ventanamicro.com> <8734tni7h3.ffs@tglx> Date: Tue, 20 Feb 2024 21:03:43 +0100 Message-ID: <87jzmyhpi8.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_120348_812375_3D80B9F4 X-CRM114-Status: GOOD ( 12.52 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Conor Dooley , Saravana Kannan , Marc Zyngier , Anup Patel , Atish Patra , linux-kernel@vger.kernel.org, =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Rob Herring , Palmer Dabbelt , Krzysztof Kozlowski , Paul Walmsley , linux-riscv@lists.infradead.org, Frank Rowand , linux-arm-kernel@lists.infradead.org, Andrew Jones Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBGZWIgMjAgMjAyNCBhdCAyMjo1MSwgQW51cCBQYXRlbCB3cm90ZToKCj4gT24gVHVl LCBGZWIgMjAsIDIwMjQgYXQgNzowNeKAr1BNIFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJv bml4LmRlPiB3cm90ZToKPj4KPj4gT24gVHVlLCBGZWIgMjAgMjAyNCBhdCAxMTozNywgQW51cCBQ YXRlbCB3cm90ZToKPj4gPiAgc3RhdGljIGJvb2wgaW1zaWNfaW5pdF9kZXZfbXNpX2luZm8oc3Ry dWN0IGRldmljZSAqZGV2LAo+PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBz dHJ1Y3QgaXJxX2RvbWFpbiAqZG9tYWluLAo+PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBzdHJ1Y3QgaXJxX2RvbWFpbiAqcmVhbF9wYXJlbnQsCj4+ID4gQEAgLTIxOCw2ICsy NDEsNyBAQCBzdGF0aWMgYm9vbCBpbXNpY19pbml0X2Rldl9tc2lfaW5mbyhzdHJ1Y3QgZGV2aWNl ICpkZXYsCj4+ID4KPj4gPiAgICAgICAvKiBNU0kgcGFyZW50IGRvbWFpbiBzcGVjaWZpYyBzZXR0 aW5ncyAqLwo+PiA+ICAgICAgIHN3aXRjaCAocmVhbF9wYXJlbnQtPmJ1c190b2tlbikgewo+PiA+ ICsgICAgIGNhc2UgRE9NQUlOX0JVU19QQ0lfTVNJOgo+Pgo+PiAgICAgICAgIGNhc2UgRE9NQUlO X0JVU19QQ0lfREVWSUNFX01TSVg6Cj4+Cj4+ID8KPgo+IEFjdHVhbGx5LCB0aGUgRE9NQUlOX0JV U19QQ0lfTVNJIGlzIG5vdCBuZWVkZWQgYmVjYXVzZQo+IHRoZSByZWFsIHBhcmVudCBkb21haW4g aXMgYWx3YXlzIHRoZSBJTVNJQyBiYXNlIGlycV9kb21haW4KPiBzbyBET01BSU5fQlVTX05FWFVT IGlzIHN1ZmZpY2llbnQuCgpJbmRlZWQuIE9idmlvdXNseSBJIGNhbid0IHJlYWQuCgo+IEJldHRl ciB0byBqdXN0IGRyb3AgRE9NQUlOX0JVU19QQ0lfTVNJIGZyb20gdGhpcyBzd2l0Y2ggY2FzZSA/ CgpZZXMuIEkgYWN0dWFsbHkgd291bGQgYmUgYSBidWcgaWYgdGhhdCBlbmRzIHVwIGFzIHRoZSBy ZWFsIHBhcmVudApkb21haW4uCgpUaGFua3MsCgogICAgICAgdGdseAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0 CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B17C9C48BC4 for ; Tue, 20 Feb 2024 20:04:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Oc39tPmc6JmHoECzkUtmq5GvCPUmZl8yDzvip5DAFr4=; b=dWugwvdkpUqRMw 2uvUtLF6Uk8O6w+i6gmUWofoslhip1sm0ILPyJoWP6jrfMiTbAMHD6GJnCFY7r8sRiOiMaSVomBvI yR6XmvTFWLauJAkTV9VoFvDV0ClenqnT4IXwI2BcT4ckveZowuRYmB42YMJi9WCFkxI4TWMaMYnsM YReL1qUI4bMs6LwbUsyw/8N4MoZaIVoq6seFadJ518Kw+YtJuU5izTvr4mDddtv3vnWQCGuykDFTe S2qiBnVU4BfU+IS0UOQ23R03gM1WbJGU2J8AsDDOQKeckXttMMoDiToVuDyB1gSoI3qHHWKbMVoUz 8td7EqhCpJTyN8fLwrFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcWLI-0000000G32H-3oPf; Tue, 20 Feb 2024 20:03:52 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcWLE-0000000G2zj-2Vzk; Tue, 20 Feb 2024 20:03:51 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1708459424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jJRsPsyZ6zDS1QWFQN2wLBFM6mS+0QImDjTMgSPiL7I=; b=aYQmsEOwQopLCUpYpAQuDyrIpn/ZjclA2riggfw0WWir8TT6NmiPQZJzpeC9YRHKgp0rWt k9TQyzVThpxVBDmox2nnESsknS5oTRd4VzFt0IU9vtyq1EJQHNR2c8XYNJ501UxxiXHAvM kXdsE5fN2sy9MVO94uyCUiwX4v8h1pq6bevWl8yrwk+XqoCaj9mBmXHCJGdlZPtLIuvqLX 3q+Zma5P0XbwLUpcToklgoNTEsCISC+ORpEWQc1gQ0abV9ucGF0qXfXXUnwwqsBvpXZvEQ 4wLIzGkKNOg+Vur2e3RHi5rEfoxeWqrJBnwmSEj0b/eNkGMG09MxRmsKO7Z1XQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1708459424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jJRsPsyZ6zDS1QWFQN2wLBFM6mS+0QImDjTMgSPiL7I=; b=0bZpy8Ucv4te6DfmhFa1QQKyXrhJJterh1+UZ0hC/H+1QXta7TTSsn4wIZdFftqnZDB7KQ v4NtqSu0q+WZZFDw== To: Anup Patel Cc: Palmer Dabbelt , Paul Walmsley , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley , Marc Zyngier , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Atish Patra , Andrew Jones , Sunil V L , Saravana Kannan , Anup Patel , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v13 08/13] irqchip/riscv-imsic: Add device MSI domain support for PCI devices In-Reply-To: References: <20240220060718.823229-1-apatel@ventanamicro.com> <20240220060718.823229-9-apatel@ventanamicro.com> <8734tni7h3.ffs@tglx> Date: Tue, 20 Feb 2024 21:03:43 +0100 Message-ID: <87jzmyhpi8.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_120348_812375_3D80B9F4 X-CRM114-Status: GOOD ( 12.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBGZWIgMjAgMjAyNCBhdCAyMjo1MSwgQW51cCBQYXRlbCB3cm90ZToKCj4gT24gVHVl LCBGZWIgMjAsIDIwMjQgYXQgNzowNeKAr1BNIFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJv bml4LmRlPiB3cm90ZToKPj4KPj4gT24gVHVlLCBGZWIgMjAgMjAyNCBhdCAxMTozNywgQW51cCBQ YXRlbCB3cm90ZToKPj4gPiAgc3RhdGljIGJvb2wgaW1zaWNfaW5pdF9kZXZfbXNpX2luZm8oc3Ry dWN0IGRldmljZSAqZGV2LAo+PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBz dHJ1Y3QgaXJxX2RvbWFpbiAqZG9tYWluLAo+PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBzdHJ1Y3QgaXJxX2RvbWFpbiAqcmVhbF9wYXJlbnQsCj4+ID4gQEAgLTIxOCw2ICsy NDEsNyBAQCBzdGF0aWMgYm9vbCBpbXNpY19pbml0X2Rldl9tc2lfaW5mbyhzdHJ1Y3QgZGV2aWNl ICpkZXYsCj4+ID4KPj4gPiAgICAgICAvKiBNU0kgcGFyZW50IGRvbWFpbiBzcGVjaWZpYyBzZXR0 aW5ncyAqLwo+PiA+ICAgICAgIHN3aXRjaCAocmVhbF9wYXJlbnQtPmJ1c190b2tlbikgewo+PiA+ ICsgICAgIGNhc2UgRE9NQUlOX0JVU19QQ0lfTVNJOgo+Pgo+PiAgICAgICAgIGNhc2UgRE9NQUlO X0JVU19QQ0lfREVWSUNFX01TSVg6Cj4+Cj4+ID8KPgo+IEFjdHVhbGx5LCB0aGUgRE9NQUlOX0JV U19QQ0lfTVNJIGlzIG5vdCBuZWVkZWQgYmVjYXVzZQo+IHRoZSByZWFsIHBhcmVudCBkb21haW4g aXMgYWx3YXlzIHRoZSBJTVNJQyBiYXNlIGlycV9kb21haW4KPiBzbyBET01BSU5fQlVTX05FWFVT IGlzIHN1ZmZpY2llbnQuCgpJbmRlZWQuIE9idmlvdXNseSBJIGNhbid0IHJlYWQuCgo+IEJldHRl ciB0byBqdXN0IGRyb3AgRE9NQUlOX0JVU19QQ0lfTVNJIGZyb20gdGhpcyBzd2l0Y2ggY2FzZSA/ CgpZZXMuIEkgYWN0dWFsbHkgd291bGQgYmUgYSBidWcgaWYgdGhhdCBlbmRzIHVwIGFzIHRoZSBy ZWFsIHBhcmVudApkb21haW4uCgpUaGFua3MsCgogICAgICAgdGdseAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C72E14A4E1; Tue, 20 Feb 2024 20:03:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708459431; cv=none; b=oiQo835m5sE9QPTnsurhpjH8zGPYbHeEBf1ip8OfW/N0DkLcnXwg5Rfp4nv+0DfBwLywGlEbnuGUsmDn/x0M28/hRsg5AXO/F40c4l7NWCLsssnLPQ4zqltVfn6utRvCzrQ/dJYE3fFKeYhz9TKcOtUtItZ3v77PjJaw1YS4m5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708459431; c=relaxed/simple; bh=RGYI1C/SB4NfKZcUVQLWJNCPAbpYUuYgeLGtJ3F3BJY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Vx9kLN0KSA+DXsFFWF2hgyfWnDXDydrUqSxxC8OmVy5Zm5mU6sw9c1IH9iZYc2OW/HKoCwfGq3Jy1aKs++3teANjJcMpdqlfrEg+Eu37u2xtViO4UI9uejuK7q06fA+EpRWRCrOFvvCnp9gBAWwASX1zK13Qju/Nkz+MUOM5NEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=aYQmsEOw; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=0bZpy8Uc; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="aYQmsEOw"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="0bZpy8Uc" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1708459424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jJRsPsyZ6zDS1QWFQN2wLBFM6mS+0QImDjTMgSPiL7I=; b=aYQmsEOwQopLCUpYpAQuDyrIpn/ZjclA2riggfw0WWir8TT6NmiPQZJzpeC9YRHKgp0rWt k9TQyzVThpxVBDmox2nnESsknS5oTRd4VzFt0IU9vtyq1EJQHNR2c8XYNJ501UxxiXHAvM kXdsE5fN2sy9MVO94uyCUiwX4v8h1pq6bevWl8yrwk+XqoCaj9mBmXHCJGdlZPtLIuvqLX 3q+Zma5P0XbwLUpcToklgoNTEsCISC+ORpEWQc1gQ0abV9ucGF0qXfXXUnwwqsBvpXZvEQ 4wLIzGkKNOg+Vur2e3RHi5rEfoxeWqrJBnwmSEj0b/eNkGMG09MxRmsKO7Z1XQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1708459424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jJRsPsyZ6zDS1QWFQN2wLBFM6mS+0QImDjTMgSPiL7I=; b=0bZpy8Ucv4te6DfmhFa1QQKyXrhJJterh1+UZ0hC/H+1QXta7TTSsn4wIZdFftqnZDB7KQ v4NtqSu0q+WZZFDw== To: Anup Patel Cc: Palmer Dabbelt , Paul Walmsley , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley , Marc Zyngier , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Atish Patra , Andrew Jones , Sunil V L , Saravana Kannan , Anup Patel , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v13 08/13] irqchip/riscv-imsic: Add device MSI domain support for PCI devices In-Reply-To: References: <20240220060718.823229-1-apatel@ventanamicro.com> <20240220060718.823229-9-apatel@ventanamicro.com> <8734tni7h3.ffs@tglx> Date: Tue, 20 Feb 2024 21:03:43 +0100 Message-ID: <87jzmyhpi8.ffs@tglx> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Feb 20 2024 at 22:51, Anup Patel wrote: > On Tue, Feb 20, 2024 at 7:05=E2=80=AFPM Thomas Gleixner wrote: >> >> On Tue, Feb 20 2024 at 11:37, Anup Patel wrote: >> > static bool imsic_init_dev_msi_info(struct device *dev, >> > struct irq_domain *domain, >> > struct irq_domain *real_parent, >> > @@ -218,6 +241,7 @@ static bool imsic_init_dev_msi_info(struct device = *dev, >> > >> > /* MSI parent domain specific settings */ >> > switch (real_parent->bus_token) { >> > + case DOMAIN_BUS_PCI_MSI: >> >> case DOMAIN_BUS_PCI_DEVICE_MSIX: >> >> ? > > Actually, the DOMAIN_BUS_PCI_MSI is not needed because > the real parent domain is always the IMSIC base irq_domain > so DOMAIN_BUS_NEXUS is sufficient. Indeed. Obviously I can't read. > Better to just drop DOMAIN_BUS_PCI_MSI from this switch case ? Yes. I actually would be a bug if that ends up as the real parent domain. Thanks, tglx