From: Fabiano Rosas <farosas@suse.de>
To: Avihai Horon <avihaih@nvidia.com>, qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>,
Leonardo Bras <leobras@redhat.com>,
Li Zhijian <lizhijian@fujitsu.com>,
Avihai Horon <avihaih@nvidia.com>
Subject: Re: [PATCH 07/11] migration/multifd: Fix leaking of Error in TLS error flow
Date: Tue, 02 Jan 2024 16:32:29 -0300 [thread overview]
Message-ID: <87jzor5y5u.fsf@suse.de> (raw)
In-Reply-To: <20231231093016.14204-8-avihaih@nvidia.com>
Avihai Horon <avihaih@nvidia.com> writes:
> If there is an error in multifd TLS handshake task,
> multifd_tls_outgoing_handshake() retrieves the error with
> qio_task_propagate_error() but never frees it.
>
> Fix it by freeing the obtained Error.
>
> In addition, the error is not reported at all, so report it with
> migrate_set_error().
>
> Fixes: 29647140157a ("migration/tls: add support for multifd tls-handshake")
> Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2024-01-02 19:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-31 9:30 [PATCH 00/11] migration: Misc cleanups and fixes Avihai Horon
2023-12-31 9:30 ` [PATCH 01/11] migration: Remove migrate_max_downtime() declaration Avihai Horon
2024-01-02 17:27 ` Fabiano Rosas
2023-12-31 9:30 ` [PATCH 02/11] migration: Remove nulling of hostname in migrate_init() Avihai Horon
2024-01-02 18:43 ` Fabiano Rosas
2023-12-31 9:30 ` [PATCH 03/11] migration: Refactor migration_incoming_setup() Avihai Horon
2024-01-02 10:02 ` Philippe Mathieu-Daudé
2024-01-02 18:53 ` Fabiano Rosas
2023-12-31 9:30 ` [PATCH 04/11] migration: Remove errp parameter in migration_fd_process_incoming() Avihai Horon
2024-01-02 18:57 ` Fabiano Rosas
2023-12-31 9:30 ` [PATCH 05/11] migration/multifd: Fix error message in multifd_recv_initial_packet() Avihai Horon
2024-01-02 19:05 ` Fabiano Rosas
2023-12-31 9:30 ` [PATCH 06/11] migration/multifd: Simplify multifd_channel_connect() if else statement Avihai Horon
2024-01-02 10:03 ` Philippe Mathieu-Daudé
2023-12-31 9:30 ` [PATCH 07/11] migration/multifd: Fix leaking of Error in TLS error flow Avihai Horon
2024-01-02 19:32 ` Fabiano Rosas [this message]
2023-12-31 9:30 ` [PATCH 08/11] migration/multifd: Remove error_setg() in migration_ioc_process_incoming() Avihai Horon
2024-01-02 19:33 ` Fabiano Rosas
2023-12-31 9:30 ` [PATCH 09/11] migration: Fix migration_channel_read_peek() error path Avihai Horon
2024-01-02 10:05 ` Philippe Mathieu-Daudé
2024-01-08 12:34 ` Markus Armbruster
2024-01-02 19:39 ` Fabiano Rosas
2023-12-31 9:30 ` [PATCH 10/11] migration: Remove unnecessary usage of local Error Avihai Horon
2024-01-02 19:42 ` Fabiano Rosas
2023-12-31 9:30 ` [PATCH 11/11] migration/multifd: " Avihai Horon
2024-01-02 10:07 ` Philippe Mathieu-Daudé
2024-01-04 4:38 ` [PATCH 00/11] migration: Misc cleanups and fixes Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzor5y5u.fsf@suse.de \
--to=farosas@suse.de \
--cc=avihaih@nvidia.com \
--cc=leobras@redhat.com \
--cc=lizhijian@fujitsu.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.