Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove prohibited space after opening parenthesis

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 30 Oct 2023, Andi Shyti <andi.shyti@linux.intel.com> wrote:
> Hi Dorcas,
>
> On Fri, Oct 27, 2023 at 08:47:45PM +0300, Dorcas AnonoLitunya wrote:
>> Removes space after opening parenthesis.
>> 
>> Fixes the checkpatch.pl error:
>> ERROR: space prohibited after that opening parenthesis '('
>> 
>> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com>
>> ---
>>  drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>> index 4a11219e560e..40687806d22a 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
>> @@ -47,7 +47,7 @@
>>  #define GEN9_LR_CONTEXT_RENDER_SIZE	(22 * PAGE_SIZE)
>>  #define GEN11_LR_CONTEXT_RENDER_SIZE	(14 * PAGE_SIZE)
>>  
>> -#define GEN8_LR_CONTEXT_OTHER_SIZE	( 2 * PAGE_SIZE)
>> +#define GEN8_LR_CONTEXT_OTHER_SIZE	(2 * PAGE_SIZE)
>
> I'm actually having second thoughts on this change. The space was
> left on purpose in order to be aligned with the defines above.

I'd merge the patch.

BR,
Jani.


>
> On the other hand, this is a bit detached from the others and
> this change makes checkpatch happy.
>
> This is one of those patches that are not right and not wrong
> either.
>
> I'll give it a bit more time and merge if no complains arise.
>
> Andi
>
>>  #define MAX_MMIO_BASES 3
>>  struct engine_info {
>> -- 
>> 2.42.0.345.gaab89be2eb

-- 
Jani Nikula, Intel