From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E888AE728CA for ; Fri, 29 Sep 2023 17:06:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmGvR-0002Gk-N8; Fri, 29 Sep 2023 13:05:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmGvN-0002DT-QQ for qemu-devel@nongnu.org; Fri, 29 Sep 2023 13:05:11 -0400 Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qmGvL-0000uJ-Qi for qemu-devel@nongnu.org; Fri, 29 Sep 2023 13:05:09 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2C49921836; Fri, 29 Sep 2023 17:05:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696007104; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=viX8BCU/3q+JMOu3+5MZV3rX/71i3D367R80GDqqHAQ=; b=C+9L0P9lou6v7RrBzKdc1aGE3/eICBsGKeppSEizw02d85MAUZGJrPO1uaFyuAT1mm+CPD IhYQN7kAbhpf7aQHEOpiiu5ktSlp/8o0QjzYxAkmrAeEqx4xNgwOb5wFxGTPtz8rwYHKbG OzsDoyiibKpowohAbnAOS7dVWoSHRAg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696007104; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=viX8BCU/3q+JMOu3+5MZV3rX/71i3D367R80GDqqHAQ=; b=D4uczI7l2tqeo4ls4hqduSJC2d0fhyWIKYoFCu+JgxIY88OjbbzVLPAaoaxkM1LQ2GX1Vy auaotWXEN2jdyjAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B51221390A; Fri, 29 Sep 2023 17:05:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sVgKIL8DF2VUZAAAMHmgww (envelope-from ); Fri, 29 Sep 2023 17:05:03 +0000 From: Fabiano Rosas To: Markus Armbruster , qemu-devel@nongnu.org Cc: quintela@redhat.com, peterx@redhat.com, leobras@redhat.com, lizhijian@fujitsu.com, eblake@redhat.com Subject: Re: [PATCH v2 53/53] migration/rdma: Replace flawed device detail dump by tracing In-Reply-To: <20230928132019.2544702-54-armbru@redhat.com> References: <20230928132019.2544702-1-armbru@redhat.com> <20230928132019.2544702-54-armbru@redhat.com> Date: Fri, 29 Sep 2023 14:05:01 -0300 Message-ID: <87jzs8zz9e.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:67c:2178:6::1c; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Markus Armbruster writes: > qemu_rdma_dump_id() dumps RDMA device details to stdout. > > rdma_start_outgoing_migration() calls it via qemu_rdma_source_init() > and qemu_rdma_resolve_host() to show source device details. > rdma_start_incoming_migration() arranges its call via > rdma_accept_incoming_migration() and qemu_rdma_accept() to show > destination device details. > > Two issues: > > 1. rdma_start_outgoing_migration() can run in HMP context. The > information should arguably go the monitor, not stdout. > > 2. ibv_query_port() failure is reported as error. Its callers remain > unaware of this failure (qemu_rdma_dump_id() can't fail), so > reporting this to the user as an error is problematic. > > Fixable, but the device detail dump is noise, except when > troubleshooting. Tracing is a better fit. Similar function > qemu_rdma_dump_id() was converted to tracing in commit > 733252deb8b (Tracify migration/rdma.c). > > Convert qemu_rdma_dump_id(), too. > > While there, touch up qemu_rdma_dump_gid()'s outdated comment. > > Signed-off-by: Markus Armbruster Reviewed-by: Fabiano Rosas