From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCD59CE7A94 for ; Mon, 25 Sep 2023 11:49:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkk5z-0007Zl-2C; Mon, 25 Sep 2023 07:49:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkk5v-0007ZD-IH for qemu-devel@nongnu.org; Mon, 25 Sep 2023 07:49:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkk5u-0005b6-0o for qemu-devel@nongnu.org; Mon, 25 Sep 2023 07:49:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695642581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2XDfrNtDoPpkCQAL3Vgx0PQE6Nnu6KpXhcgHtwwxfhs=; b=QiXpq1vUliSEmTEdmJuEqeJqYWHyxsJe/9X5+uxXGcXECffQk5eaKOkmsYxcN7qoLaCJrI 3yh1tYt/E1jC3SOEQzk53BqlgoqVCZ9liI6LBAxvdlP1WFKYD+/hIusW5pj5jaXKv/KZ0g 9bid7X65sJ28ZrRoYj5nsKask/vtzuU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-93-lHFkP8tjMXmPMP9Ds7OxbQ-1; Mon, 25 Sep 2023 07:49:38 -0400 X-MC-Unique: lHFkP8tjMXmPMP9Ds7OxbQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 89E9918153FE; Mon, 25 Sep 2023 11:49:37 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CDC740C2070; Mon, 25 Sep 2023 11:49:37 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 37D1321E6900; Mon, 25 Sep 2023 13:49:36 +0200 (CEST) From: Markus Armbruster To: "Maciej S. Szmigiero" Cc: Paolo Bonzini , Richard Henderson , Eduardo Habkost , David Hildenbrand , "Michael S . Tsirkin" , Marcel Apfelbaum , Alex =?utf-8?Q?Benn=C3=A9e?= , Thomas Huth , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Eric Blake , Markus Armbruster , qemu-devel@nongnu.org Subject: Re: [PATCH v7 6/7] qapi: Add HV_BALLOON_STATUS_REPORT event and its QMP query command References: <03f58582c27a729ab305f8337ca2d2b8034bdd3b.1693240836.git.maciej.szmigiero@oracle.com> Date: Mon, 25 Sep 2023 13:49:36 +0200 In-Reply-To: <03f58582c27a729ab305f8337ca2d2b8034bdd3b.1693240836.git.maciej.szmigiero@oracle.com> (Maciej S. Szmigiero's message of "Mon, 28 Aug 2023 18:48:23 +0200") Message-ID: <87jzse79rj.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org "Maciej S. Szmigiero" writes: > From: "Maciej S. Szmigiero" > > Used by the hv-balloon driver for (optional) guest memory status reports. > > Signed-off-by: Maciej S. Szmigiero [...] > static void hv_balloon_handle_unballoon_response(HvBalloon *balloon, > diff --git a/monitor/monitor.c b/monitor/monitor.c > index dc352f9e9d95..81513c642691 100644 > --- a/monitor/monitor.c > +++ b/monitor/monitor.c > @@ -315,6 +315,7 @@ static MonitorQAPIEventConf monitor_qapi_event_conf[QAPI_EVENT__MAX] = { > [QAPI_EVENT_QUORUM_FAILURE] = { 1000 * SCALE_MS }, > [QAPI_EVENT_VSERPORT_CHANGE] = { 1000 * SCALE_MS }, > [QAPI_EVENT_MEMORY_DEVICE_SIZE_CHANGE] = { 1000 * SCALE_MS }, > + [QAPI_EVENT_HV_BALLOON_STATUS_REPORT] = { 1000 * SCALE_MS }, > }; > > /* > diff --git a/qapi/machine.json b/qapi/machine.json > index 5ede977cf2bc..f592876964af 100644 > --- a/qapi/machine.json > +++ b/qapi/machine.json > @@ -1113,6 +1113,70 @@ > { 'event': 'BALLOON_CHANGE', > 'data': { 'actual': 'int' } } > > +## > +# @HvBalloonInfo: > +# > +# hv-balloon guest-provided memory status information. > +# > +# @committed: the amount of memory in use inside the guest plus the > +# amount of the memory unusable inside the guest (ballooned out, > +# offline, etc.) > +# > +# @available: the amount of the memory inside the guest available for > +# new allocations ("free") > +# > +# Since: 8.2 > +## > +{ 'struct': 'HvBalloonInfo', 'data': { 'committed': 'size', 'available': 'size' } } > + > +## > +# @query-hv-balloon-status-report: > +# > +# Returns the hv-balloon driver data contained in the last received "STATUS" > +# message from the guest. > +# > +# Returns: > +# - @HvBalloonInfo on success > +# - If no hv-balloon device is present, DeviceNotFound > +# - If guest memory status reporting not enabled or no guest memory status > +# report received yet, GenericError Indentation is off, confusing Sphinx. Do you actually need to tell the two failures apart? Do me a favour and break the lines a bit earlier, like # Returns the hv-balloon driver data contained in the last received # "STATUS" message from the guest. # # Returns: # - @HvBalloonInfo on success # - If no hv-balloon device is present, DeviceNotFound # - If guest memory status reporting not enabled or no guest memory # status report received yet, GenericError > +# > +# Since: 8.2 > +# > +# Example: > +# > +# -> { "execute": "query-hv-balloon-status-report" } > +# <- { "return": { > +# "committed": 816640000, > +# "available": 3333054464 > +# } > +# } > +## > +{ 'command': 'query-hv-balloon-status-report', 'returns': 'HvBalloonInfo' } > + > +## > +# @HV_BALLOON_STATUS_REPORT: > +# > +# Emitted when the hv-balloon driver receives a "STATUS" message from > +# the guest. > +# > +# @data - a @HvBalloonInfo equivalent to the one returned by the This needs to be # @data: ... text ... to be rendered correctly. Suggest # @data: contents of "STATUS" message received from the guest. > +# 'query-hv-balloon-status-report' command. > +# > +# Note: this event is rate-limited. > +# > +# Since: 8.2 > +# > +# Example: > +# > +# <- { "event": "HV_BALLOON_STATUS_REPORT", > +# "data": { "committed": 816640000, "available": 3333054464 }, > +# "timestamp": { "seconds": 1600295492, "microseconds": 661044 } } > +# > +## > +{ 'event': 'HV_BALLOON_STATUS_REPORT', > + 'data': 'HvBalloonInfo' } > + > ## > # @MemoryInfo: > #