From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6772EB64DD for ; Thu, 13 Jul 2023 12:33:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJvUe-0008Pb-0o; Thu, 13 Jul 2023 08:32:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJvUc-0008P9-7k for qemu-devel@nongnu.org; Thu, 13 Jul 2023 08:32:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJvUX-0004mX-94 for qemu-devel@nongnu.org; Thu, 13 Jul 2023 08:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689251535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kRldcJzk1gNW9DLjeuPE8V+q+hyE4Bh523kmaDyUF2g=; b=DcNYoRfngWh/k8tVqIvvzN/+EOZ5H4Pe04Gtd4vYNj1JcYLjpE8iNNAgpCBp/TP1uybjLJ yQ2JIvMuvXbdGen9eJZP72X+dj9mOpEdTwLv0cXDq/uFpgvePZcr92jpLSD5a3N3UypYRe xAFAgPT9/6/U/zRjF0rVZD3elaco8OQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-380-wkXVKH82OqiB3sJn-QRjIw-1; Thu, 13 Jul 2023 08:32:11 -0400 X-MC-Unique: wkXVKH82OqiB3sJn-QRjIw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B0FC8F9E56; Thu, 13 Jul 2023 12:32:11 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.65]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CA47E40D285E; Thu, 13 Jul 2023 12:32:10 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9229821E6A1F; Thu, 13 Jul 2023 14:32:09 +0200 (CEST) From: Markus Armbruster To: ~hyman Cc: qemu-devel , ~hyman , Peter Xu , Paolo Bonzini , Juan Quintela , "Dr. David Alan Gilbert" , Eric Blake , Thomas Huth , Laurent Vivier , Richard Henderson , Philippe =?utf-8?Q?Mathieu-Dau?= =?utf-8?Q?d=C3=A9?= Subject: Re: [PATCH QEMU v8 2/9] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter References: <168870305868.29142.5121604177475325995-2@git.sr.ht> Date: Thu, 13 Jul 2023 14:32:09 +0200 In-Reply-To: <168870305868.29142.5121604177475325995-2@git.sr.ht> (hyman@git.sr.ht's message of "Wed, 07 Jun 2023 21:32:59 +0800") Message-ID: <87jzv4j8l2.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org ~hyman writes: > From: Hyman Huang(=E9=BB=84=E5=8B=87) > > Introduce "x-vcpu-dirty-limit-period" migration experimental > parameter, which is in the range of 1 to 1000ms and used to > make dirtyrate calculation period configurable. dirty rate > > Currently with the "x-vcpu-dirty-limit-period" varies, the Currently, as the > total time of live migration changes, test results show the Suggest period instead of comma. > optimal value of "x-vcpu-dirty-limit-period" ranges from > 500ms to 1000 ms. "x-vcpu-dirty-limit-period" should be made > stable once it proves best value can not be determined with > developer's experiments. > > Signed-off-by: Hyman Huang(=E9=BB=84=E5=8B=87) > Reviewed-by: Markus Armbruster > Reviewed-by: Juan Quintela [...] > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -789,9 +789,14 @@ > # Nodes are mapped to their block device name if there is one, and > # to their node name otherwise. (Since 5.2) > # > +# @x-vcpu-dirty-limit-period: Periodic time (in milliseconds) of dirty > +# limit during live migration. Should be in the range 1 to 1000ms, > +# defaults to 1000ms. (Since 8.1) Two spaces after sentence-ending punctuation, please: # @x-vcpu-dirty-limit-period: Periodic time (in milliseconds) of dirty # limit during live migration. Should be in the range 1 to # 1000ms, defaults to 1000ms. (Since 8.1) > +# > # Features: > # > -# @unstable: Member @x-checkpoint-delay is experimental. > +# @unstable: Members @x-checkpoint-delay and > +# @x-vcpu-dirty-limit-period are experimental. > # > # Since: 2.4 > ## > @@ -809,8 +814,10 @@ > 'multifd-channels', > 'xbzrle-cache-size', 'max-postcopy-bandwidth', > 'max-cpu-throttle', 'multifd-compression', > - 'multifd-zlib-level' ,'multifd-zstd-level', > - 'block-bitmap-mapping' ] } > + 'multifd-zlib-level', 'multifd-zstd-level', > + 'block-bitmap-mapping', > + { 'name': 'x-vcpu-dirty-limit-period', > + 'features': ['unstable'] } ] } >=20=20 > ## > # @MigrateSetParameters: > @@ -945,9 +952,14 @@ > # Nodes are mapped to their block device name if there is one, and > # to their node name otherwise. (Since 5.2) > # > +# @x-vcpu-dirty-limit-period: Periodic time (in milliseconds) of dirty > +# limit during live migration. Should be in the range 1 to 1000ms, > +# defaults to 1000ms. (Since 8.1) Likewise. > +# > # Features: > # > -# @unstable: Member @x-checkpoint-delay is experimental. > +# @unstable: Members @x-checkpoint-delay and > +# @x-vcpu-dirty-limit-period are experimental. > # > # TODO: either fuse back into MigrationParameters, or make > # MigrationParameters members mandatory > @@ -982,7 +994,9 @@ > '*multifd-compression': 'MultiFDCompression', > '*multifd-zlib-level': 'uint8', > '*multifd-zstd-level': 'uint8', > - '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ] } } > + '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ], > + '*x-vcpu-dirty-limit-period': { 'type': 'uint64', > + 'features': [ 'unstable' ] }= } } >=20=20 > ## > # @migrate-set-parameters: > @@ -1137,9 +1151,14 @@ > # Nodes are mapped to their block device name if there is one, and > # to their node name otherwise. (Since 5.2) > # > +# @x-vcpu-dirty-limit-period: Periodic time (in milliseconds) of dirty > +# limit during live migration. Should be in the range 1 to 1000ms, > +# defaults to 1000ms. (Since 8.1) Likewise. > +# > # Features: > # > -# @unstable: Member @x-checkpoint-delay is experimental. > +# @unstable: Members @x-checkpoint-delay and > +# @x-vcpu-dirty-limit-period are experimental. > # > # Since: 2.4 > ## > @@ -1171,7 +1190,9 @@ > '*multifd-compression': 'MultiFDCompression', > '*multifd-zlib-level': 'uint8', > '*multifd-zstd-level': 'uint8', > - '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ] } } > + '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ], > + '*x-vcpu-dirty-limit-period': { 'type': 'uint64', > + 'features': [ 'unstable' ] }= } } >=20=20 > ## > # @query-migrate-parameters: The issues I'm pointing out don't justfy yet another respin. But if you need to respin the series for some other reason, plase take care of them.