From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, balaton@eik.bme.hu
Subject: Re: [PATCH] target/ppc: Merge COMPUTE_CLASS and COMPUTE_FPRF
Date: Wed, 24 May 2023 14:18:34 +0100 [thread overview]
Message-ID: <87jzwxx3wh.fsf@linaro.org> (raw)
In-Reply-To: <20230523202507.688859-1-richard.henderson@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> Instead of computing an artifical "class" bitmask then
> converting that to the fprf value, compute the final
> value from the start.
>
> Reorder the tests to check the most likely cases first.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
We see a slight performance boost although my baseline run was a bit
noisy:
➜ # before
🕙07:31:14 alex@zen:qemu.git/builds/all (b44e6e6) (REBASING 1/2) [$?] took 10m
➜ hyperfine -w 2 "./qemu-ppc64 ~/lsrc/tests/lame.git-svn/builds/ppc64/frontend/lame -h pts-trondheim-3.wav pts-trondheim-3.mp3"
Benchmark 1: ./qemu-ppc64 ~/lsrc/tests/lame.git-svn/builds/ppc64/frontend/lame -h pts-trondheim-3.wav pts-trondheim-3.mp3
Time (mean ± σ): 649.858 s ± 58.351 s [User: 649.272 s, System: 0.448 s]
Range (min … max): 616.148 s … 764.585 s 10 runs
# after
hyperfine "./qemu-ppc64 ~/lsrc/tests/lame.git-svn/builds/ppc64/frontend/lame -h pts-trondheim-3.wav pts-trondheim-3.mp3"
Benchmark 1: ./qemu-ppc64 ~/lsrc/tests/lame.git-svn/builds/ppc64/frontend/lame -h pts-trondheim-3.wav pts-trondheim-3.mp3
Time (mean ± σ): 599.968 s ± 8.014 s [User: 599.656 s, System: 0.181 s]
Range (min … max): 591.171 s … 615.912 s 10 runs
Anyway
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-05-24 13:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 20:25 [PATCH] target/ppc: Merge COMPUTE_CLASS and COMPUTE_FPRF Richard Henderson
2023-05-23 22:50 ` BALATON Zoltan
2023-05-23 23:02 ` BALATON Zoltan
2023-05-23 23:06 ` Richard Henderson
2023-05-24 8:52 ` BALATON Zoltan
2023-05-24 13:18 ` Alex Bennée [this message]
2023-05-28 10:05 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzwxx3wh.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.