From: Juan Quintela <quintela@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, QEMU Trivial <qemu-trivial@nongnu.org>,
Hyman Huang <huangy81@chinatelecom.cn>,
Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH] softmmu: Tidy dirtylimit_dirty_ring_full_time
Date: Fri, 28 Apr 2023 20:38:12 +0200 [thread overview]
Message-ID: <87jzxv6eej.fsf@secure.mitica> (raw)
In-Reply-To: <be8ccc72-0dfb-ca33-e309-27d51d96a623@redhat.com> (Thomas Huth's message of "Fri, 28 Apr 2023 12:57:05 +0200")
Thomas Huth <thuth@redhat.com> wrote:
> On 28/04/2023 12.34, Richard Henderson wrote:
>> Drop inline marker: let compiler decide.
>> Change return type to uint64_t: this matches the computation in the
>> return statement and the local variable assignment in the caller.
>> Rename local to dirty_ring_size_MB to fix typo.
>> Simplify conversion to MiB via qemu_target_page_bits and right shift.
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Not that I expect the amount of bytes in one machine to not fit in
64bit, but good change.
About the signesdness of variables, I really hate it, specially that
compiler not help here where arguments, operands and assignment place is
unsigned. Sniff.
next prev parent reply other threads:[~2023-04-28 18:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 10:34 [PATCH] softmmu: Tidy dirtylimit_dirty_ring_full_time Richard Henderson
2023-04-28 10:57 ` Thomas Huth
2023-04-28 18:38 ` Juan Quintela [this message]
2023-04-28 22:01 ` Richard Henderson
2023-04-28 22:49 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzxv6eej.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=huangy81@chinatelecom.cn \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.