From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1CE9C77B71 for ; Fri, 21 Apr 2023 15:24:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7AD93E8F; Fri, 21 Apr 2023 17:23:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7AD93E8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1682090689; bh=/efUxqPsCQAUlG55h6QqYwpF4dHClUu+KJsp0K6ZIeo=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=mopBctQ3CJqe7NvRdUl4oi/ZKZaP83rvyaPzy5h0o/GxbSqUKqNJtXXfmd0mvWL75 2SHkar6rQy+McJ0twuqJ/hjbQrhDW6Gg2MoXxpcSypbHwspo1AxHEaNr0svdwx9YQ6 riO6z6bIyNlkJ739d+kvPuZ7SFoYNR20ofZXIx/4= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id F333CF80155; Fri, 21 Apr 2023 17:23:33 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 27E16F80155; Fri, 21 Apr 2023 17:23:31 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8362EF800D0 for ; Fri, 21 Apr 2023 17:23:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8362EF800D0 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=c7XkSH5m; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=j3R8+Zf1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 167631FDDC; Fri, 21 Apr 2023 15:23:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682090609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MckFqVjMj7I8OHKQM6Uw+7GVNe78cob/1LCi7HGaOhg=; b=c7XkSH5m4ogiVqnAeIEq0IcA4q8TnHBWsYYNr51GS/BiBAGk9YJsFT1kDV32mzsTX9eIfr uQkXirOL+xwbxyas11TZ3jiaUn1zHMw42GwupVY3f7fK2NaaLlN8++WlTXISpagL/4nhZC rscS3A+AWX7u0xNK2ICXLR+s19QlBqk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682090609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MckFqVjMj7I8OHKQM6Uw+7GVNe78cob/1LCi7HGaOhg=; b=j3R8+Zf1ym4DMS3Piny+HIcKTXIwiMoX7x4tyrpYOnTJHg6ptYZWhNU1QP0SeKt2NTqv+I 5H7Hp4T7zjLR0vBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DCCCC1390E; Fri, 21 Apr 2023 15:23:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Ms8hNHCqQmQkGwAAMHmgww (envelope-from ); Fri, 21 Apr 2023 15:23:28 +0000 Date: Fri, 21 Apr 2023 17:23:28 +0200 Message-ID: <87jzy5qmxb.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH] ALSA: emu10k1: properly assert DSP init constraints In-Reply-To: References: <20230421141006.1005524-1-oswald.buddenhagen@gmx.de> <87o7nhqnrb.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: LVDV2R637NY3ZGP5F3MCLFBEUH3BTZEM X-Message-ID-Hash: LVDV2R637NY3ZGP5F3MCLFBEUH3BTZEM X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 21 Apr 2023 17:08:50 +0200, Oswald Buddenhagen wrote: > > On Fri, Apr 21, 2023 at 05:05:28PM +0200, Takashi Iwai wrote: > > On Fri, 21 Apr 2023 16:10:06 +0200, > > Oswald Buddenhagen wrote: > >> > >> If these are hit, we've already trashed kernel space. There is no > >> recovery from that. > >> > >> Signed-off-by: Oswald Buddenhagen > > > > Sorry, it's a big NO-NO. BUG_ON() shouldn't be used here at all. > > > > BUG_ON() is used for the case you inevitably must stop everything > > immediately at this point. > > > yes, this is exactly what is intended, and i hoped that the commit > message makes it clear enough why. Not clear at all. Please explain in more details if we really *HAVE TO* use BUG_ON() there. thanks, Takashi