From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11283C77B61 for ; Fri, 7 Apr 2023 15:34:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id CF152C4339B; Fri, 7 Apr 2023 15:34:41 +0000 (UTC) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 4CF2DC433D2; Fri, 7 Apr 2023 15:34:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 4CF2DC433D2 Authentication-Results: smtp.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C6B64100006; Fri, 7 Apr 2023 15:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1680881677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D2Wdjko2vA/SMrvlsYQ/Ry1S7hpAQ7U5YkaaIz6cUuc=; b=fn8h7+IEzDznrfjQOvUfEH16tLHE9gDE8fxoXz2qEfjZcdJcLzzNQtX0KNawvdyA7OpZEQ wcl7V3ZEEbmmXtyyFNe7iO1Kvw5ix9GNripEeat05KnY1zROw1AQmIRKQviN7coVHxwqCQ jPp/3KqmnDj9UgirLMAYaZau67njqRFkzVHScdVbCFmtxk7QyU9lcCa5+ufXpy0JtcPks8 0p5X8petEfVMk7ZHnrk2Qxi1lb6hHXVRQH1ps6EXgBccVqPe3UmNiZ2d6BMc8dHChytCl1 Pqgbxty4EAfzXmkB32l+fWwnxKHbPgkuhtXE3ee405BYbevPgVAK0cZ4mY0KgA== From: Gregory CLEMENT To: INAGAKI Hiroshi , Andrew Lunn List-Id: Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com, arnd@arndb.de, olof@lixom.net, soc@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Subject: Re: [PATCH 2/2] ARM: dts: mvebu: add device tree for IIJ SA-W2 appliance In-Reply-To: <7d4a218d-8b8a-5a1d-eff8-e154bfde69be@gmail.com> References: <20230223132502.2045-1-musashino.open@gmail.com> <20230223132502.2045-2-musashino.open@gmail.com> <7d4a218d-8b8a-5a1d-eff8-e154bfde69be@gmail.com> Date: Fri, 07 Apr 2023 17:34:34 +0200 Message-ID: <87jzyn3dv9.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain Hello INAGAKI Hiroshi, do you plan to send a v2 soon based on the reviews you got ? Or if you already sent it, I missed it, in this case could you resend it with me in CC ? Thanks, Gregory > Hi Andrew, > > thank you for your reviews and detailed descriptions. > > On 2023/02/23 23:43, Andrew Lunn wrote: >>> + pcie { >>> + status = "okay"; >>> + >>> + pcie@1,0 { >>> + status = "okay"; >>> + >>> + /* Atheros AR9287 */ >>> + wifi@0,0 { >>> + compatible = "pci168c,002e"; >>> + reg = <0000 0 0 0 0>; >>> + }; >>> + }; >>> + >>> + pcie@3,0 { >>> + status = "okay"; >>> + >>> + /* Qualcomm Atheros QCA9880 */ >>> + wifi@0,0 { >>> + compatible = "qcom,ath10k"; >>> + reg = <0000 0 0 0 0>; >>> + }; >>> + }; >>> + }; >>> + }; >> These are not wrong, but they are also not needed. PCI devices should >> be discovered by enumeration, and you don't have any additional >> properties here, or phandles pointing to these nodes. >> >> I assume these are COTS wifi modules? By listing them here you are >> restricting some flexibility. The OEM could for example swap the >> modules around, and Linux would not care, but the DT would then be >> wrong. Or you could have a device with a different module because it >> is cheaper, and again, Linux would not care, but the DT would be >> wrong. > > Got it. SA-W2 is not designed to allow users to swap cards under > normal use, but certainly things like you said can happen... > I'll remove "wifi" nodes. > > > I assume these are COTS wifi modules? > > Yes, those are the modules manufactured by Silex Technology, Inc. [1][2]. > > [1]: https://www.silex.jp/products/wireless-module/sxpcegn.html > [2]: https://www.silex.jp/products/wireless-module/sxpceac.html > >> >>> +&usb0 { >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pmx_usb_pins>; >>> + status = "okay"; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + /* SMSC USB2514B */ >>> + hub@1 { >>> + compatible = "usb424,2514"; >>> + reg = <1>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + hub_port1: port@1 { >>> + reg = <1>; >>> + #trigger-source-cells = <0>; >>> + }; >>> + >>> + hub_port2: port@2 { >>> + reg = <2>; >>> + #trigger-source-cells = <0>; >>> + }; >>> + }; >>> +}; >> Same comment as PCI. However, it is likely that the USB hub is >> actually on the board, not a module, so it is a lot less likely to >> change. > > Yes, that USB hub is on the PCB and wired to the SoC directly. But > I'll keep it in mind... > >> >> As i said, they are not wrong, so you don't need to remove them. >> >> Andrew >> > > Regards, > Hiroshi -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C59D8C77B61 for ; Fri, 7 Apr 2023 15:35:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7lx7PM9cGIwvHW6rQWI7KBPP3Xp0CfiL7DPBFA0eqX0=; b=IH95Q0Vkyt0wwL FhFw1ZERBICbbwTs63/tznHttBaQiElSTG/OdAVxJe0rWNHpor69rTQblktg/rsKmxZhWSJw5dkjq q3ybNmeeWHPghJ5rasS6lZYRg2r3e+V8xgmTT2Zmxp9ST6rBfcICrTw6PoFD4TSGCtj6TN/GUDyVs lSBLH3/0rd1aOU8po+LiFvnnv78tBEyRLTcXgZHu33RuCppSIrNcX/gxq+Nh1g5AdZNVBK/ih5mKb o1fw/W6Zzcn/UG0vwRIoMwTgTz/XhUX4HzKhPrbAQQuXHk2eDmMYfXGbAUx1bEaJOEdjH6sB26POq 4bxNXUSDPSpB8gufHG4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pko6x-00AcuL-32; Fri, 07 Apr 2023 15:34:47 +0000 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pko6u-00Acsu-0U for linux-arm-kernel@lists.infradead.org; Fri, 07 Apr 2023 15:34:46 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C6B64100006; Fri, 7 Apr 2023 15:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1680881677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D2Wdjko2vA/SMrvlsYQ/Ry1S7hpAQ7U5YkaaIz6cUuc=; b=fn8h7+IEzDznrfjQOvUfEH16tLHE9gDE8fxoXz2qEfjZcdJcLzzNQtX0KNawvdyA7OpZEQ wcl7V3ZEEbmmXtyyFNe7iO1Kvw5ix9GNripEeat05KnY1zROw1AQmIRKQviN7coVHxwqCQ jPp/3KqmnDj9UgirLMAYaZau67njqRFkzVHScdVbCFmtxk7QyU9lcCa5+ufXpy0JtcPks8 0p5X8petEfVMk7ZHnrk2Qxi1lb6hHXVRQH1ps6EXgBccVqPe3UmNiZ2d6BMc8dHChytCl1 Pqgbxty4EAfzXmkB32l+fWwnxKHbPgkuhtXE3ee405BYbevPgVAK0cZ4mY0KgA== From: Gregory CLEMENT To: INAGAKI Hiroshi , Andrew Lunn Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com, arnd@arndb.de, olof@lixom.net, soc@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Subject: Re: [PATCH 2/2] ARM: dts: mvebu: add device tree for IIJ SA-W2 appliance In-Reply-To: <7d4a218d-8b8a-5a1d-eff8-e154bfde69be@gmail.com> References: <20230223132502.2045-1-musashino.open@gmail.com> <20230223132502.2045-2-musashino.open@gmail.com> <7d4a218d-8b8a-5a1d-eff8-e154bfde69be@gmail.com> Date: Fri, 07 Apr 2023 17:34:34 +0200 Message-ID: <87jzyn3dv9.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230407_083444_499176_DB08918F X-CRM114-Status: GOOD ( 21.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello INAGAKI Hiroshi, do you plan to send a v2 soon based on the reviews you got ? Or if you already sent it, I missed it, in this case could you resend it with me in CC ? Thanks, Gregory > Hi Andrew, > > thank you for your reviews and detailed descriptions. > > On 2023/02/23 23:43, Andrew Lunn wrote: >>> + pcie { >>> + status = "okay"; >>> + >>> + pcie@1,0 { >>> + status = "okay"; >>> + >>> + /* Atheros AR9287 */ >>> + wifi@0,0 { >>> + compatible = "pci168c,002e"; >>> + reg = <0000 0 0 0 0>; >>> + }; >>> + }; >>> + >>> + pcie@3,0 { >>> + status = "okay"; >>> + >>> + /* Qualcomm Atheros QCA9880 */ >>> + wifi@0,0 { >>> + compatible = "qcom,ath10k"; >>> + reg = <0000 0 0 0 0>; >>> + }; >>> + }; >>> + }; >>> + }; >> These are not wrong, but they are also not needed. PCI devices should >> be discovered by enumeration, and you don't have any additional >> properties here, or phandles pointing to these nodes. >> >> I assume these are COTS wifi modules? By listing them here you are >> restricting some flexibility. The OEM could for example swap the >> modules around, and Linux would not care, but the DT would then be >> wrong. Or you could have a device with a different module because it >> is cheaper, and again, Linux would not care, but the DT would be >> wrong. > > Got it. SA-W2 is not designed to allow users to swap cards under > normal use, but certainly things like you said can happen... > I'll remove "wifi" nodes. > > > I assume these are COTS wifi modules? > > Yes, those are the modules manufactured by Silex Technology, Inc. [1][2]. > > [1]: https://www.silex.jp/products/wireless-module/sxpcegn.html > [2]: https://www.silex.jp/products/wireless-module/sxpceac.html > >> >>> +&usb0 { >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pmx_usb_pins>; >>> + status = "okay"; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + /* SMSC USB2514B */ >>> + hub@1 { >>> + compatible = "usb424,2514"; >>> + reg = <1>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + hub_port1: port@1 { >>> + reg = <1>; >>> + #trigger-source-cells = <0>; >>> + }; >>> + >>> + hub_port2: port@2 { >>> + reg = <2>; >>> + #trigger-source-cells = <0>; >>> + }; >>> + }; >>> +}; >> Same comment as PCI. However, it is likely that the USB hub is >> actually on the board, not a module, so it is a lot less likely to >> change. > > Yes, that USB hub is on the PCB and wired to the SoC directly. But > I'll keep it in mind... > >> >> As i said, they are not wrong, so you don't need to remove them. >> >> Andrew >> > > Regards, > Hiroshi -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel