From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E513C6FD1D for ; Wed, 15 Mar 2023 05:33:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231358AbjCOFdn (ORCPT ); Wed, 15 Mar 2023 01:33:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231220AbjCOFdm (ORCPT ); Wed, 15 Mar 2023 01:33:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8102D2411F; Tue, 14 Mar 2023 22:33:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 149B261AA3; Wed, 15 Mar 2023 05:33:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21124C433D2; Wed, 15 Mar 2023 05:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678858385; bh=JDBgkW5qQtTPm1yWAp51l+ZgG0AKs3eXBoW5HnCX/MA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kbwOpU7JF4hU5h6xcfj11Qgfvtpqh5mMi0uUMmOwi5tvKTgG5FeQrIbm3ZObMJxOi Pd2OV69aatTDB3f705BKz/UIy6hUMExg9s86PkTCcSSvedmKica8rkCf5WBZ4tTbUI 04OSFs0GXPMawq6acf4ZOGnSk2edfAM2m2YfJPuRDfaWSn+aiWfrPmvYeFVnygwxkh Fm8ASG9bTzGUiGqnDrCFHYTTyvaNl4fA/j57alcPP9QxEwPXj9p/obP3lGfpvLBmxD qtwCkSPnTIIN5ZyOHbjrPmc4NdUgLmKTP9oek3xHkwWId/JdNWaPYqzbu2RvfDGsZ2 Dqe2eGY1KWRjQ== From: Kalle Valo To: Christian Lamparter Cc: Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, Tony Lindgren , Aaro Koskinen , Felipe Balbi , Arnd Bergmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , =?utf-8?Q?Beno=C3=AEt?= Cousson , Russell King , Dmitry Torokhov , Johannes Berg , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] p54spi: convert to devicetree References: <20230314163201.955689-1-arnd@kernel.org> Date: Wed, 15 Mar 2023 07:32:57 +0200 In-Reply-To: (Christian Lamparter's message of "Tue, 14 Mar 2023 21:18:55 +0100") Message-ID: <87jzziwpdi.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Christian Lamparter writes: > Hi, > > On 3/14/23 17:30, Arnd Bergmann wrote: >> The Prism54 SPI driver hardcodes GPIO numbers and expects users to >> pass them as module parameters, apparently a relic from its life as a >> staging driver. This works because there is only one user, the Nokia >> N8x0 tablet. >> >> Convert this to the gpio descriptor interface and move the gpio >> line information into devicetree to improve this and simplify the >> code at the same time. > > Yes, this is definitely the right idea/way. From what I remember, Kalle > Valo was partially involved in p54spi/stlc45xx. The details are very fuzzy. > So, I could be totally wrong. From what I remember Kalle was working > for Nokia (or as a contractor for Nokia?) at the time. I wrote stlc45xx driver as part of my thesis when working for Nokia and I think then someone wrote p54spi after that. Oh man, this was a long time ago so hard to remember :) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F182C61DA4 for ; Wed, 15 Mar 2023 05:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ycbggx+o0Mw0KtQmohQGyfBL5FbIbsdmoige+FhL5IE=; b=apnVcsMyhSFx3i wh/Pwjp536GPUefmcsP5myCgMQ3/edwmPgPu9HaiLVy3oHSWvta1hVxv3/lvTmFteNNEfPdiImxDK t4TucPhabvb16+kBEnc9cmMEu7odkPHVLBnIYGExg57st0+ZyCWCIrFhfIomulbYlBE/V7myzyRzn Jpg9huMBHOOmHv47jWa8q0lmk7/sBBF4dYsSp+XJF697/JJrdmOXnGZCF8MnxLarAOo9NZUTotA5w eprl206TAPmhIrb5nNo1LPo3K8prArauUQy1Cku6O2wM+UpZNKfe9J+M92TjtaOzzaGymbh94Qa7P +jaXf9iZ7aSebUMn8BrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcJlE-00CQUJ-0g; Wed, 15 Mar 2023 05:33:16 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcJl6-00CQTk-1S for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 05:33:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D912EB81C76; Wed, 15 Mar 2023 05:33:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21124C433D2; Wed, 15 Mar 2023 05:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678858385; bh=JDBgkW5qQtTPm1yWAp51l+ZgG0AKs3eXBoW5HnCX/MA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kbwOpU7JF4hU5h6xcfj11Qgfvtpqh5mMi0uUMmOwi5tvKTgG5FeQrIbm3ZObMJxOi Pd2OV69aatTDB3f705BKz/UIy6hUMExg9s86PkTCcSSvedmKica8rkCf5WBZ4tTbUI 04OSFs0GXPMawq6acf4ZOGnSk2edfAM2m2YfJPuRDfaWSn+aiWfrPmvYeFVnygwxkh Fm8ASG9bTzGUiGqnDrCFHYTTyvaNl4fA/j57alcPP9QxEwPXj9p/obP3lGfpvLBmxD qtwCkSPnTIIN5ZyOHbjrPmc4NdUgLmKTP9oek3xHkwWId/JdNWaPYqzbu2RvfDGsZ2 Dqe2eGY1KWRjQ== From: Kalle Valo To: Christian Lamparter Cc: Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, Tony Lindgren , Aaro Koskinen , Felipe Balbi , Arnd Bergmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , =?utf-8?Q?Beno=C3=AEt?= Cousson , Russell King , Dmitry Torokhov , Johannes Berg , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] p54spi: convert to devicetree References: <20230314163201.955689-1-arnd@kernel.org> Date: Wed, 15 Mar 2023 07:32:57 +0200 In-Reply-To: (Christian Lamparter's message of "Tue, 14 Mar 2023 21:18:55 +0100") Message-ID: <87jzziwpdi.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_223311_399401_D5569E6F X-CRM114-Status: GOOD ( 18.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Christian Lamparter writes: > Hi, > > On 3/14/23 17:30, Arnd Bergmann wrote: >> The Prism54 SPI driver hardcodes GPIO numbers and expects users to >> pass them as module parameters, apparently a relic from its life as a >> staging driver. This works because there is only one user, the Nokia >> N8x0 tablet. >> >> Convert this to the gpio descriptor interface and move the gpio >> line information into devicetree to improve this and simplify the >> code at the same time. > > Yes, this is definitely the right idea/way. From what I remember, Kalle > Valo was partially involved in p54spi/stlc45xx. The details are very fuzzy. > So, I could be totally wrong. From what I remember Kalle was working > for Nokia (or as a contractor for Nokia?) at the time. I wrote stlc45xx driver as part of my thesis when working for Nokia and I think then someone wrote p54spi after that. Oh man, this was a long time ago so hard to remember :) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel