Re: [RFC PATCH 1/2] fscrypt: new helper function - __fscrypt_prepare_atomic_open()

["Luís Henriques" <lhenriques@suse.de>]

kernel test robot <lkp@intel.com> writes:

> Hi Luís,
>
> [FYI, it's a private test report for your RFC patch.]
> [auto build test ERROR on ceph-client/testing]
> [also build test ERROR on ceph-client/for-linus linus/master v6.3-rc1 next-20230309]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Lu-s-Henriques/fscrypt-new-helper-function-__fscrypt_prepare_atomic_open/20230309-202021
> base:   https://github.com/ceph/ceph-client.git testing
> patch link:    https://lore.kernel.org/r/20230309121910.18939-2-lhenriques%40suse.de
> patch subject: [RFC PATCH 1/2] fscrypt: new helper function - __fscrypt_prepare_atomic_open()
> config: i386-tinyconfig (https://download.01.org/0day-ci/archive/20230309/202303092108.lUCfozm1-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> reproduce (this is a W=1 build):
>         # https://github.com/intel-lab-lkp/linux/commit/bc0e93e713bcb2b95af1bcb4ac369a7fe3a72863
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Lu-s-Henriques/fscrypt-new-helper-function-__fscrypt_prepare_atomic_open/20230309-202021
>         git checkout bc0e93e713bcb2b95af1bcb4ac369a7fe3a72863
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 O=build_dir ARCH=i386 olddefconfig
>         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303092108.lUCfozm1-lkp@intel.com/
>
> All error/warnings (new ones prefixed by >>):
>
>    In file included from fs/super.c:34:
>>> include/linux/fscrypt.h:692:5: warning: no previous prototype for '__fscrypt_prepare_atomic_open' [-Wmissing-prototypes]
>      692 | int __fscrypt_prepare_atomic_open(struct inode *dir, struct dentry *dentry)
>          |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Doh, I forgot to declare the helper as 'static' for the !CONFIG_FS_ENCRYPTION
case.  But I guess I'll hold on sending a v2 until I get some feedback
from the fscrypt maintainers.

Cheers,
-- 
Luís

> --
>    ld: fs/ioctl.o: in function `__fscrypt_prepare_atomic_open':
>>> ioctl.c:(.text+0x10a): multiple definition of `__fscrypt_prepare_atomic_open'; fs/super.o:super.c:(.text+0x461): first defined here
>    ld: fs/dcache.o: in function `__fscrypt_prepare_atomic_open':
>    dcache.c:(.text+0x897): multiple definition of `__fscrypt_prepare_atomic_open'; fs/super.o:super.c:(.text+0x461): first defined here
>    ld: fs/libfs.o: in function `__fscrypt_prepare_atomic_open':
>    libfs.c:(.text+0x782): multiple definition of `__fscrypt_prepare_atomic_open'; fs/super.o:super.c:(.text+0x461): first defined here
>
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests