All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	sam@ravnborg.org, daniel@ffwll.ch, airlied@gmail.com
Cc: linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org,
	linux-mips@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	linux-sunxi@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h
Date: Mon, 16 Jan 2023 18:19:56 +0200	[thread overview]
Message-ID: <87k01me9jn.fsf@intel.com> (raw)
In-Reply-To: <20230116131235.18917-1-tzimmermann@suse.de>

On Mon, 16 Jan 2023, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> A lot of source files include drm_crtc_helper.h for its contained
> include statements. This leads to excessive compile-time dependencies.
>
> Where possible, remove the include statements for drm_crtc_helper.h
> and include the required source files directly. Also remove the
> include statements from drm_crtc_helper.h itself, which doesn't need
> most of them.
>
> I built this patchset on x86-64, aarch64 and arm. Hopefully I found
> all include dependencies.

I think this is the right direction and I support this. Personally I
think it's enough to build test and fix any fallout afterwards.

To that end, I did build test this myself with my config, and it was
fine, though that probably doesn't add much coverage.

FWIW,

Acked-by: Jani Nikula <jani.nikula@intel.com>


-- 
Jani Nikula, Intel Open Source Graphics Center

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h
Date: Mon, 16 Jan 2023 18:19:56 +0200	[thread overview]
Message-ID: <87k01me9jn.fsf@intel.com> (raw)
In-Reply-To: <20230116131235.18917-1-tzimmermann@suse.de>

On Mon, 16 Jan 2023, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> A lot of source files include drm_crtc_helper.h for its contained
> include statements. This leads to excessive compile-time dependencies.
>
> Where possible, remove the include statements for drm_crtc_helper.h
> and include the required source files directly. Also remove the
> include statements from drm_crtc_helper.h itself, which doesn't need
> most of them.
>
> I built this patchset on x86-64, aarch64 and arm. Hopefully I found
> all include dependencies.

I think this is the right direction and I support this. Personally I
think it's enough to build test and fix any fallout afterwards.

To that end, I did build test this myself with my config, and it was
fine, though that probably doesn't add much coverage.

FWIW,

Acked-by: Jani Nikula <jani.nikula@intel.com>


-- 
Jani Nikula, Intel Open Source Graphics Center

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	sam@ravnborg.org, daniel@ffwll.ch, airlied@gmail.com
Cc: linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org,
	linux-mips@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	linux-sunxi@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h
Date: Mon, 16 Jan 2023 18:19:56 +0200	[thread overview]
Message-ID: <87k01me9jn.fsf@intel.com> (raw)
In-Reply-To: <20230116131235.18917-1-tzimmermann@suse.de>

On Mon, 16 Jan 2023, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> A lot of source files include drm_crtc_helper.h for its contained
> include statements. This leads to excessive compile-time dependencies.
>
> Where possible, remove the include statements for drm_crtc_helper.h
> and include the required source files directly. Also remove the
> include statements from drm_crtc_helper.h itself, which doesn't need
> most of them.
>
> I built this patchset on x86-64, aarch64 and arm. Hopefully I found
> all include dependencies.

I think this is the right direction and I support this. Personally I
think it's enough to build test and fix any fallout afterwards.

To that end, I did build test this myself with my config, and it was
fine, though that probably doesn't add much coverage.

FWIW,

Acked-by: Jani Nikula <jani.nikula@intel.com>


-- 
Jani Nikula, Intel Open Source Graphics Center

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	sam@ravnborg.org, daniel@ffwll.ch, airlied@gmail.com
Cc: linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org,
	linux-mips@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [Nouveau] [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h
Date: Mon, 16 Jan 2023 18:19:56 +0200	[thread overview]
Message-ID: <87k01me9jn.fsf@intel.com> (raw)
In-Reply-To: <20230116131235.18917-1-tzimmermann@suse.de>

On Mon, 16 Jan 2023, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> A lot of source files include drm_crtc_helper.h for its contained
> include statements. This leads to excessive compile-time dependencies.
>
> Where possible, remove the include statements for drm_crtc_helper.h
> and include the required source files directly. Also remove the
> include statements from drm_crtc_helper.h itself, which doesn't need
> most of them.
>
> I built this patchset on x86-64, aarch64 and arm. Hopefully I found
> all include dependencies.

I think this is the right direction and I support this. Personally I
think it's enough to build test and fix any fallout afterwards.

To that end, I did build test this myself with my config, and it was
fine, though that probably doesn't add much coverage.

FWIW,

Acked-by: Jani Nikula <jani.nikula@intel.com>


-- 
Jani Nikula, Intel Open Source Graphics Center

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	sam@ravnborg.org, daniel@ffwll.ch, airlied@gmail.com
Cc: linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org,
	linux-mips@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	linux-sunxi@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h
Date: Mon, 16 Jan 2023 18:19:56 +0200	[thread overview]
Message-ID: <87k01me9jn.fsf@intel.com> (raw)
In-Reply-To: <20230116131235.18917-1-tzimmermann@suse.de>

On Mon, 16 Jan 2023, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> A lot of source files include drm_crtc_helper.h for its contained
> include statements. This leads to excessive compile-time dependencies.
>
> Where possible, remove the include statements for drm_crtc_helper.h
> and include the required source files directly. Also remove the
> include statements from drm_crtc_helper.h itself, which doesn't need
> most of them.
>
> I built this patchset on x86-64, aarch64 and arm. Hopefully I found
> all include dependencies.

I think this is the right direction and I support this. Personally I
think it's enough to build test and fix any fallout afterwards.

To that end, I did build test this myself with my config, and it was
fine, though that probably doesn't add much coverage.

FWIW,

Acked-by: Jani Nikula <jani.nikula@intel.com>


-- 
Jani Nikula, Intel Open Source Graphics Center

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-01-16 16:20 UTC|newest]

Thread overview: 205+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16 13:12 [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 01/22] drm/amdgpu: Fix coding style Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 18:05   ` Alex Deucher
2023-01-16 18:05     ` Alex Deucher
2023-01-16 18:05     ` Alex Deucher
2023-01-16 18:05     ` [Nouveau] " Alex Deucher
2023-01-16 18:05     ` Alex Deucher
2023-01-16 18:05     ` Alex Deucher
2023-01-16 18:05     ` Alex Deucher
2023-01-16 13:12 ` [PATCH 02/22] drm: Remove unnecessary include statements for drm_crtc_helper.h Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 20:15   ` Sam Ravnborg
2023-01-16 20:15     ` Sam Ravnborg
2023-01-16 20:15     ` Sam Ravnborg
2023-01-16 20:15     ` [Nouveau] " Sam Ravnborg
2023-01-16 20:15     ` Sam Ravnborg
2023-01-16 20:15     ` Sam Ravnborg
2023-01-16 20:15     ` Sam Ravnborg
2023-01-16 13:12 ` [PATCH 03/22] drm/amdgpu: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 20:18   ` Sam Ravnborg
2023-01-16 20:18     ` Sam Ravnborg
2023-01-16 20:18     ` Sam Ravnborg
2023-01-16 20:18     ` [Nouveau] " Sam Ravnborg
2023-01-16 20:18     ` Sam Ravnborg
2023-01-16 20:18     ` Sam Ravnborg
2023-01-16 20:18     ` Sam Ravnborg
2023-01-16 13:12 ` [PATCH 04/22] drm/arm/komeda: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 05/22] drm/aspeed: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 20:27   ` Sam Ravnborg
2023-01-16 20:27     ` Sam Ravnborg
2023-01-16 20:27     ` Sam Ravnborg
2023-01-16 20:27     ` [Nouveau] " Sam Ravnborg
2023-01-16 20:27     ` Sam Ravnborg
2023-01-16 20:27     ` Sam Ravnborg
2023-01-16 20:27     ` Sam Ravnborg
2023-01-16 13:12 ` [PATCH 06/22] drm/ast: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 07/22] drm/bridge: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 08/22] drm/gma500: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 09/22] drm/i2c/ch7006: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 10/22] drm/ingenic: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 11/22] drm/kmb: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 12/22] drm/logicvc: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 13/22] drm/nouveau: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 14/22] drm/radeon: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 15/22] drm/rockchip: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 16/22] drm/shmobile: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 17/22] drm/sprd: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 18/22] drm/sun4i: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 20:31   ` Sam Ravnborg
2023-01-16 20:31     ` Sam Ravnborg
2023-01-16 20:31     ` Sam Ravnborg
2023-01-16 20:31     ` [Nouveau] " Sam Ravnborg
2023-01-16 20:31     ` Sam Ravnborg
2023-01-16 20:31     ` Sam Ravnborg
2023-01-16 20:31     ` Sam Ravnborg
2023-01-16 13:12 ` [PATCH 19/22] drm/tidss: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 20/22] drm/udl: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 21/22] drm/vboxvideo: " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 22/22] drm/crtc-helper: Remove most include statements from drm_crtc_helper.h Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 13:12   ` Thomas Zimmermann
2023-01-16 16:19 ` Jani Nikula [this message]
2023-01-16 16:19   ` [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h Jani Nikula
2023-01-16 16:19   ` [Nouveau] " Jani Nikula
2023-01-16 16:19   ` Jani Nikula
2023-01-16 16:19   ` Jani Nikula
2023-01-16 18:37   ` Alex Deucher
2023-01-16 18:37     ` Alex Deucher
2023-01-16 18:37     ` Alex Deucher
2023-01-16 18:37     ` [Nouveau] " Alex Deucher
2023-01-16 18:37     ` Alex Deucher
2023-01-16 18:37     ` Alex Deucher
2023-01-16 18:37     ` Alex Deucher
2023-01-17  8:41     ` Thomas Zimmermann
2023-01-17  8:41       ` Thomas Zimmermann
2023-01-17  8:41       ` [Nouveau] " Thomas Zimmermann
2023-01-17  8:41       ` Thomas Zimmermann
2023-01-17  8:41       ` Thomas Zimmermann
2023-01-17  8:41       ` Thomas Zimmermann
2023-01-16 20:47 ` Sam Ravnborg
2023-01-16 20:47   ` Sam Ravnborg
2023-01-16 20:47   ` Sam Ravnborg
2023-01-16 20:47   ` [Nouveau] " Sam Ravnborg
2023-01-16 20:47   ` Sam Ravnborg
2023-01-16 20:47   ` Sam Ravnborg
2023-01-16 20:47   ` Sam Ravnborg
2023-01-17  8:45   ` Thomas Zimmermann
2023-01-17  8:45     ` Thomas Zimmermann
2023-01-17  8:45     ` Thomas Zimmermann
2023-01-17  8:45     ` [Nouveau] " Thomas Zimmermann
2023-01-17  8:45     ` Thomas Zimmermann
2023-01-17  8:45     ` Thomas Zimmermann
2023-01-17  8:45     ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k01me9jn.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=nouveau@lists.freedesktop.org \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.