From: Richard Palethorpe <rpalethorpe@suse.de>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 4/6] Rewrite utime04.c using new LTP API
Date: Mon, 04 Jul 2022 14:31:56 +0100 [thread overview]
Message-ID: <87k08tt33s.fsf@suse.de> (raw)
In-Reply-To: <20220623080215.24186-5-akumar@suse.de>
Hello,
>
> -/*
> - * void
> - * cleanup() - performs all ONE TIME cleanup for this test at
> - * completion or premature exit.
> - * Remove the test directory and testfile created in the setup.
> - */
> -void cleanup(void)
> -{
> -
> - tst_rmdir();
> -
> -}
> +static struct tst_test test = {
> + .test_all = run,
> + .setup = setup,
> + .needs_root = 1,
> + .needs_tmpdir = 1
> +};
> --
> 2.36.1
Why don't we do this one on all file systems as well?
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-07-04 13:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 8:02 [LTP] [PATCH v2 0/6] Convert utime tests to new LTP API Avinesh Kumar
2022-06-23 8:02 ` [LTP] [PATCH v2 1/6] Rewrite utime01.c using " Avinesh Kumar
2022-07-04 13:13 ` Richard Palethorpe
2022-06-23 8:02 ` [LTP] [PATCH v2 2/6] Rewrite utime02.c " Avinesh Kumar
2022-07-04 13:22 ` Richard Palethorpe
2022-06-23 8:02 ` [LTP] [PATCH v2 3/6] utime03.c: Remove unnecessary header includes Avinesh Kumar
2022-07-04 13:25 ` Richard Palethorpe
2022-06-23 8:02 ` [LTP] [PATCH v2 4/6] Rewrite utime04.c using new LTP API Avinesh Kumar
2022-07-04 13:31 ` Richard Palethorpe [this message]
2022-06-23 8:02 ` [LTP] [PATCH v2 5/6] Rewrite utime05.c " Avinesh Kumar
2022-07-04 13:35 ` Richard Palethorpe
2022-06-23 8:02 ` [LTP] [PATCH v2 6/6] Rewrite utime06.c " Avinesh Kumar
2022-07-04 13:47 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k08tt33s.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.