From: Thomas Gleixner <tglx@linutronix.de>
To: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
sboyd@kernel.org, johannes@sipsolutions.net, rafael@kernel.org
Subject: Re: Possible race in dev_coredumpm()-del_timer() path
Date: Thu, 14 Apr 2022 13:31:49 +0200 [thread overview]
Message-ID: <87k0brew9m.ffs@tglx> (raw)
In-Reply-To: <20220414112055.GA14124@hu-mojha-hyd.qualcomm.com>
On Thu, Apr 14 2022 at 16:50, Mukesh Ojha wrote:
> On Thu, Apr 14, 2022 at 12:38:13PM +0200, Thomas Gleixner wrote:
>> So, yes this needs serialization of some sort.
>
> Thanks for understanding the problem.
> Can the patch mentioned at below link helps with the first problem ?
>
> https://lore.kernel.org/lkml/57a04278-0a60-cc7d-7ce8-a75c2befd568@quicinc.com/
Something like that.
>> Same problem vs. disabled_store().
>
> you mean, while userspace is reading the data and suddenly disable_store() done from
> sysfs.
No, that's not a problem because the reader holds a reference, but it's
the same problem vs. initialization:
device_add()
disable_store()
devcd_free()
mod_delayed_work()
....
Thanks,
tglx
prev parent reply other threads:[~2022-04-14 11:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 5:29 Possible race in dev_coredumpm()-del_timer() path Mukesh Ojha
2022-04-13 5:34 ` Greg KH
2022-04-13 6:41 ` Johannes Berg
2022-04-13 10:16 ` Mukesh Ojha
2022-04-13 10:58 ` Greg KH
2022-04-13 11:21 ` Mukesh Ojha
2022-04-13 13:01 ` Greg KH
2022-04-13 14:17 ` Mukesh Ojha
2022-04-13 14:18 ` Mukesh Ojha
2022-04-14 10:38 ` Thomas Gleixner
2022-04-14 11:20 ` Mukesh Ojha
2022-04-14 11:31 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0brew9m.ffs@tglx \
--to=tglx@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mojha@quicinc.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.