From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Kevin Bracey <kevin@bracey.fi>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] q_cake: allow changing to diffserv3
Date: Thu, 06 Jan 2022 21:38:54 +0100 [thread overview]
Message-ID: <87k0fca9b5.fsf@toke.dk> (raw)
In-Reply-To: <20220106111604.2919263-1-kevin@bracey.fi>
Kevin Bracey <kevin@bracey.fi> writes:
> A diffserv3 option (enum value 0) was never sent to the kernel, so it
> was not possible to use "tc qdisc change" to select it.
>
> This also meant that were also relying on the kernel's default being
> diffserv3 when adding. If the default were to change, we wouldn't have
> been able to request diffserv3 explicitly.
>
> Signed-off-by: Kevin Bracey <kevin@bracey.fi>
Yeah, that should probably be fixed; thanks!
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
prev parent reply other threads:[~2022-01-06 20:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 11:16 [PATCH iproute2] q_cake: allow changing to diffserv3 Kevin Bracey
2022-01-06 20:38 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0fca9b5.fsf@toke.dk \
--to=toke@toke.dk \
--cc=kevin@bracey.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.