From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4FFBB10E2BD for ; Wed, 29 Dec 2021 20:42:40 +0000 (UTC) Date: Wed, 29 Dec 2021 12:42:39 -0800 Message-ID: <87k0fn9m80.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20211229075239.1555546-1-priyanka.dandamudi@intel.com> References: <20211229075239.1555546-1-priyanka.dandamudi@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_ctx_exec: Skip test for RCS+CCS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: priyanka.dandamudi@intel.com Cc: igt-dev@lists.freedesktop.org, saurabhg.gupta@intel.com List-ID: On Tue, 28 Dec 2021 23:52:39 -0800, wrote: > > From: Priyanka Dandamudi > > Updated the nohangcheck test to skip for DG2 > as test fails when reset is applied for the RCS+CCS combination. > > Signed-off-by: Priyanka Dandamudi > Cc: John Harrison > Cc: Melkaveri, Arjun > --- > tests/i915/gem_ctx_exec.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c > index a1270a88..dbb46404 100644 > --- a/tests/i915/gem_ctx_exec.c > +++ b/tests/i915/gem_ctx_exec.c > @@ -276,6 +276,9 @@ static void nohangcheck_hostile(int i915) > int err = 0; > int dir; > uint64_t ahnd; > + bool rcs_found = false; > + bool ccs_found = false; > + Extra newline. > > /* > * Even if the user disables hangcheck during their context, > @@ -293,6 +296,17 @@ static void nohangcheck_hostile(int i915) > > igt_require(__enable_hangcheck(dir, false)); > > + for_each_ctx_engine(i915, ctx, e) { > + if(rcs_found && ccs_found) Need space before opening bracket (both "(" and "{"), everywhere. > + break; > + else if(e->class == I915_ENGINE_CLASS_RENDER && rcs_found == false){ No need for rcs_found check. > + rcs_found = true; > + continue; No need for 'continue' since we have an "else if". > + } > + else if(e->class == I915_ENGINE_CLASS_COMPUTE && ccs_found == false) No need for ccs_found check. > + ccs_found = true; > + } > + igt_require(!(rcs_found && ccs_found)); This one I am not sure of. Do RCS + CCS have dependent resets only for particular products so that this check would unnecessarily skip on future products where such dependence may not exist? How has this been handled elsewhere? > for_each_ctx_engine(i915, ctx, e) { > igt_spin_t *spin; > int new; > -- > 2.25.1 >