All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: John Harrison <john.c.harrison@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 2/4] lib/i915: Return actual submission method from gem_submission_method
Date: Thu, 04 Nov 2021 10:36:09 -0700	[thread overview]
Message-ID: <87k0hnakmu.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <75ba03a7-109d-7495-618d-c370832f8e15@intel.com>

On Wed, 03 Nov 2021 11:22:25 -0700, John Harrison wrote:
>
> > diff --git a/lib/i915/gem_submission.h b/lib/i915/gem_submission.h
> > index 55bcfc09965..1c82e3c5ede 100644
> > --- a/lib/i915/gem_submission.h
> > +++ b/lib/i915/gem_submission.h
> > @@ -28,8 +28,9 @@
> >     #include "intel_ctx.h"
> >   -#define GEM_SUBMISSION_EXECLISTS	(1 << 1)
> > -#define GEM_SUBMISSION_GUC		(1 << 2)
> > +#define GEM_SUBMISSION_LEGACY_RING_BUF	1
> As per comment above, I would just name this GEM_SUBMISSION_RINGBUF.
>
> With that changed:
> Reviewed-by: John Harrison <John.C.Harrison@Intel.com>

Thanks, made the change and merged now.

  reply	other threads:[~2021-11-04 17:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02 23:30 [igt-dev] [PATCH i-g-t 0/4] Return actual submission methods from submission method functions Ashutosh Dixit
2021-11-02 23:30 ` [igt-dev] [PATCH i-g-t 1/4] Remove "semaphores" submission method Ashutosh Dixit
2021-11-03 18:18   ` John Harrison
2021-11-02 23:30 ` [igt-dev] [PATCH i-g-t 2/4] lib/i915: Return actual submission method from gem_submission_method Ashutosh Dixit
2021-11-03 18:22   ` John Harrison
2021-11-04 17:36     ` Dixit, Ashutosh [this message]
2021-11-02 23:30 ` [igt-dev] [PATCH i-g-t 3/4] lib/i915: Clarify gem_submission function names Ashutosh Dixit
2021-11-03 18:23   ` John Harrison
2021-11-02 23:30 ` [igt-dev] [PATCH i-g-t 4/4] tests/gem_ctx_shared: Fix disjoint_timelines test requirements Ashutosh Dixit
2021-11-03 18:23   ` John Harrison
2021-11-03  0:13 ` [igt-dev] ✓ Fi.CI.BAT: success for Return actual submission methods from submission method functions (rev2) Patchwork
2021-11-03  2:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-11-04  3:28 ` [igt-dev] ✓ Fi.CI.BAT: success for Return actual submission methods from submission method functions (rev3) Patchwork
2021-11-04  5:52 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0hnakmu.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=john.c.harrison@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.