From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF3B0C432BE for ; Tue, 31 Aug 2021 15:02:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 216A36103A for ; Tue, 31 Aug 2021 15:02:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 216A36103A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:59086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL5H4-0005As-UZ for qemu-devel@archiver.kernel.org; Tue, 31 Aug 2021 11:02:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL5Fa-0003o0-TN for qemu-devel@nongnu.org; Tue, 31 Aug 2021 11:00:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57430) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL5FZ-0002uU-85 for qemu-devel@nongnu.org; Tue, 31 Aug 2021 11:00:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630422032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EFwGEA77dqXFe2x85zIZvkrKinMUoPFVzTAgYEIQpPE=; b=jBNBBavNwqYcX+ELWi7W0rphuabeWDxjJEvqU0pFJzP+UnslFiV77q/78/wsI0MIeFMylw RoDv6WB3zSIqLxR5w5G+3lbIKkxczPAU+bXDDXXKOfv0076QMKNTTPIRUV9m00tDVtVrL4 ODRL23hHa/bKPk3UG+hiVNxazVHDVk0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-67-yhT6XxVGNzOmlkz5qD2XMg-1; Tue, 31 Aug 2021 11:00:31 -0400 X-MC-Unique: yhT6XxVGNzOmlkz5qD2XMg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4AB181966340; Tue, 31 Aug 2021 15:00:30 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-4.ams2.redhat.com [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C90D6A05B; Tue, 31 Aug 2021 15:00:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A574711380A9; Tue, 31 Aug 2021 17:00:23 +0200 (CEST) From: Markus Armbruster To: Yuri Benditovich Subject: Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command. References: <20210713153758.323614-1-andrew@daynix.com> <20210713153758.323614-6-andrew@daynix.com> <87y29dct4m.fsf@dusky.pond.sub.org> <877dgbpco1.fsf@dusky.pond.sub.org> <87v93n8nu3.fsf@dusky.pond.sub.org> <87a6kz8i4g.fsf@dusky.pond.sub.org> Date: Tue, 31 Aug 2021 17:00:23 +0200 In-Reply-To: (Yuri Benditovich's message of "Mon, 30 Aug 2021 19:56:03 +0300") Message-ID: <87k0k1wtfc.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.391, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Melnichenko , "Daniel P. =?utf-8?Q?Berrang=C3=A9?=" , "Michael S. Tsirkin" , Jason Wang , qemu-devel@nongnu.org, Yan Vugenfirer , Eric Blake Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Yuri Benditovich writes: > On Mon, Aug 30, 2021 at 11:14 AM Markus Armbruster wrote: >> >> Yuri Benditovich writes: >> >> > On Mon, Aug 30, 2021 at 9:10 AM Markus Armbruster wrote: [...] >> >> So let's try again: if libvirt does use the wrong RSS helper, how does >> >> the system behave? >> > >> > The receive-side scaling may work incorrectly, i.e. finally may move >> > incoming packets to a virtqueue different than expected one. >> >> Then I'm confused about the purpose of "the stamp" mentioned below. Can >> you enlighten me? > > The stamp is a string (common for qemu executable and RSS helper > executable during build) that qemu can later retrieve from the helper > in run-time and ensure this helper is fully compatible with this build > of qemu (in terms of eBPF operation). The helper is built with the > same C headers (related to ebpf operation) as the qemu, the qemu is > able to receive file descriptors created by the helper (of ebpf > program and ebpf data structure's maps) from libvirt and deal with > them as if it has created them. Thanks. I tried to apply your series to check a few of my assumptions, but I'm getting conflicts. Got something I could git-pull? [...]