From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:e20e:0:0:0:0:0 with SMTP id z14csp38839lfg; Wed, 5 May 2021 00:19:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLUig88sI79ouNHshCZ9odaXlUSaJ5TtTSzNr0lMWWJ1t5Exh/A1HWr/Tz2cqjT0+4Q8XK X-Received: by 2002:a37:46c5:: with SMTP id t188mr29537949qka.47.1620199140096; Wed, 05 May 2021 00:19:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620199140; cv=none; d=google.com; s=arc-20160816; b=PP040w9JtiLbKdJgEDXZ743p6xtXJwgV4dxX5fGkP+W2PvghmTisMQSuRVrH6bruM3 rBbHvxXC87y3uBKsDh1+iD1DpwRzmcyH7nTKkSbpBVF9pzLqlsV+8y+SwulQAG7ddU1h CciJTXZpWMqDKcf6E8ptWtH6MpVYrrN0wjNNrRFY3naiXlUWBG4Mp92Vo3tPMalTvO3R BSZ38GWfsMmE9uX/jOJiw9ANOvarV5fmMAs1xPwqQuwF3E0rznsggCavPAjyEpnsraQI 2hTvx+Z7DJUXbO5uFH2NJfeGwLqKzLTDv7pPVk4SsGQZ20MI4N3aPMLeC2rgGhxxGG9C +OXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:user-agent:message-id:in-reply-to:date:references :subject:to:from:dkim-signature; bh=lcJBx5/+oT6AjUvfJBCJWV6stmSIaCf7lZuS7+KkG64=; b=iFYZrTsyuzGr3hYc5nA3xlAzGtEErj39c6pwKqSMWMrtf3BY0IiPgeFKicIVJ4pHLS ZdvjuCSXOSm+dwDAAZFdchfo63o28bGeK3JEsozustftPyG+PNzNUCWD8aiXMKG58ts2 SKuHcQpIqdzjA1eOyDX9x2FM4xeG6jR1y0fEIqF35A+Adqe41Y38c+BQ9sOAb85r2oSb qetPgtM2hejPB/W/KV10cfG4p9Fpy0bb13+wMbBqVpFxnLmv1KnMngBhBkU6+76MDYQ9 UIFejaFLRF36OFuYWrBN+8aksCPI6BMjCAgRA3k98Vso8OUEIMzbKZdMkzBn2CBNkYkw RdIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=jFhY9mcn; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p13si3942076qtn.111.2021.05.05.00.18.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 May 2021 00:19:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=jFhY9mcn; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:58276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leBoB-0003L7-Fg for alex.bennee@linaro.org; Wed, 05 May 2021 03:18:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leBng-0003Jw-I9 for qemu-arm@nongnu.org; Wed, 05 May 2021 03:18:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leBnd-0007w4-DF for qemu-arm@nongnu.org; Wed, 05 May 2021 03:18:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620199103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lcJBx5/+oT6AjUvfJBCJWV6stmSIaCf7lZuS7+KkG64=; b=jFhY9mcnuoncxUc/L1S3jpwb9ah4sdoUQv1NArFkRCNLQHJNShlkjukaQIe+NDr/Of6n6F jf2EMJA8lbUrRO1g+e8YiA2MQDWLUN60ZHs+cuSi7uLSbGQ6t4lKAh+65WQ5O2b8BQCqF3 hGGQ6he/NWixXJjYEiYdfIYAbJGrn30= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-6OnkcauGNIGR_ZucnKNwuA-1; Wed, 05 May 2021 03:18:20 -0400 X-MC-Unique: 6OnkcauGNIGR_ZucnKNwuA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7F6EFC7404; Wed, 5 May 2021 07:18:18 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-17.ams2.redhat.com [10.36.114.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DEB6A610DF; Wed, 5 May 2021 07:18:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4C2251138529; Wed, 5 May 2021 09:18:16 +0200 (CEST) From: Markus Armbruster To: Peter Maydell Subject: Re: [PATCH v2 1/3] hw/block/nand: Register machine reset handler References: <20210502203121.630944-1-f4bug@amsat.org> <20210502203121.630944-2-f4bug@amsat.org> Date: Wed, 05 May 2021 09:18:16 +0200 In-Reply-To: (Peter Maydell's message of "Sun, 2 May 2021 21:38:59 +0100") Message-ID: <87k0odvebr.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.697, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Qemu-block , QEMU Developers , Mark Cave-Ayland , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Max Reitz , qemu-arm , =?utf-8?Q?Herv=C3=A9?= Poussineau , qemu-ppc Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: ElkI9iqhxBb5 Peter Maydell writes: > On Sun, 2 May 2021 at 21:31, Philippe Mathieu-Daud=C3=A9 wrote: >> >> The TYPE_NAND device is bus-less, thus isn't reset automatically. >> Register a reset handler to get reset with the machine. >> >> Fixed: 7426aa72c36 ("nand: Don't inherit from Sysbus") >> Signed-off-by: Philippe Mathieu-Daud=C3=A9 >> --- > > Personally I would just revert 7426aa72c36 rather than introduce > a new use of qemu_register_reset()... I think this depends on what you dislike more, qemu_register_reset() or sysbus. Neither is deprecated, both have more than a hundred users. One more user doesn't matter all that much for either. I happen to dislike sysbus more, but my opinion on this is yet another thin that doesn't matter all that much :)