From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 059A0C433DB for ; Tue, 23 Mar 2021 14:07:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5CB96199F for ; Tue, 23 Mar 2021 14:07:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5CB96199F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 201F66E8A0; Tue, 23 Mar 2021 14:07:17 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 367BE6E8A0; Tue, 23 Mar 2021 14:07:16 +0000 (UTC) IronPort-SDR: hp+iLZf4Jb1pGIs0Yo9ZSr5FeIF3euV+XYdvE5nZMxNty3TnTkt/yJS2JVq5/zL/WJGlBwOXgO osND/Gd6lfzw== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="187164567" X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="187164567" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 07:07:15 -0700 IronPort-SDR: OgCpjYysMewcIG7T/5T0gGkytTxkwKdQzZxfWA+o+XkeIOGiAR9CjOmP4KM7hy9ER20JHM2jeu T502Uf/10h2w== X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="414998948" Received: from wjlloyd-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.53.124]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 07:06:08 -0700 From: Jani Nikula To: lyude@redhat.com, intel-gfx@lists.freedesktop.org In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210318170204.513000-1-lyude@redhat.com> Date: Tue, 23 Mar 2021 16:06:05 +0200 Message-ID: <87k0py3qya.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/dpcd_bl: Don't try vesa interface unless specified by VBT X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , open list , "open list:DRM DRIVERS" , Sean Paul , Aaron Ma , Dave Airlie Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gVGh1LCAxOCBNYXIgMjAyMSwgTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4gd3JvdGU6 Cj4gQWN0dWFsbHktTkFLIHRoaXMuIEkganVzdCByZWFsaXplZCBJJ3ZlIGJlZW4gbWlzcmVhZGlu ZyB0aGUgYnVnIGFuZCB0aGF0IHRoaXMKPiBkb2Vzbid0IGFjdHVhbGx5IHNlZW0gdG8gYmUgZml4 ZWQuIFdpbGwgcmVzZW5kIG9uY2UgSSBmaWd1cmUgb3V0IHdoYXQncyBnb2luZyBvbgoKV2VsbCwg SSB0aGluayB0aGVyZSBhcmUgYWN0dWFsbHkgbXVsdGlwbGUgaXNzdWVzIG9uIG11bHRpcGxlCm1h Y2hpbmVzLiBUaGlzIGZpeGVzIHRoZSBpc3N1ZSBvbiBUaGlua1BhZCBYMSBUaXRhbml1bSBHZW4x IFsxXS4KCkkgc3VzcGVjdCByZXZlcnRpbmcgOThlNDk3ZTIwM2E1ICgiZHJtL2k5MTUvZHBjZF9i bDogdW5jaGVjayBQV01fUElOX0NBUAp3aGVuIGRldGVjdCBlRFAgYmFja2xpZ2h0IGNhcGFiaWxp dGllcyIpIHdvdWxkIHRvby4gQnV0IHRoZW4gdGhhdCB3b3VsZApicmVhayAqb3RoZXIqIG1hY2hp bmVzIHRoYXQgY2xhaW0gc3VwcG9ydCBmb3IgKmJvdGgqIGVEUCBQV00gcGluIGFuZApEUENEIGJh Y2tsaWdodCBjb250cm9sLCBJIHRoaW5rLgoKSSB0aGluayB0aGVyZSBhcmUgaXNzdWVzIHdpdGgg aG93IHdlIHRyeSBzZXR1cCBEUENEIGJhY2tsaWdodCBpZiB0aGUgR09QCmhhcyBzZXQgdXAgUFdN IGJhY2tsaWdodC4gRm9yIGV4YW1wbGUsIHdlIGRvbid0IHNldCB0aGUgYmFja2xpZ2h0CmNvbnRy b2wgbW9kZSBjb3JyZWN0bHkgdW50aWwgdGhlIG5leHQgZGlzYWJsZS9lbmFibGUgc2VxdWVuY2Uu IEhvd2V2ZXIsCkkgdHJpZWQgdG8gZml4IHRoaXMsIGFuZCBJIHRoaW5rIEkgd2FzIGRvaW5nIGFs bCB0aGUgcmlnaHQgdGhpbmdzLCBhbmQKRFBDRCByZWFkcyBzZWVtZWQgdG8gY29uZmlybSB0aGlz LCB5ZXQgSSB3YXMgbm90IGFibGUgdG8gY29udHJvbApicmlnaHRuZXNzIHVzaW5nIERQQ0QuIEkg ZG9uJ3Qga25vdyB3aGF0IGdpdmVzLCBidXQgSSBkbyBrbm93IGVEUCBQV00KcGluIGNvbnRyb2wg d29ya3MuCgoKQlIsCkphbmkuCgoKWzFdIGh0dHBzOi8vZ2l0bGFiLmZyZWVkZXNrdG9wLm9yZy9k cm0vaW50ZWwvLS9pc3N1ZXMvMzE1OAoKCj4KPiBPbiBUaHUsIDIwMjEtMDMtMTggYXQgMTM6MDIg LTA0MDAsIEx5dWRlIFBhdWwgd3JvdGU6Cj4+IExvb2tzIGxpa2UgdGhhdCB0aGVyZSBhY3R1YWxs eSBhcmUgYW5vdGhlciBzdWJzZXQgb2YgbGFwdG9wcyBvbiB0aGUgbWFya2V0Cj4+IHRoYXQgZG9u J3Qgc3VwcG9ydCB0aGUgSW50ZWwgSERSIGJhY2tsaWdodCBpbnRlcmZhY2UsIGJ1dCBkbyBhZHZl cnRpc2UKPj4gc3VwcG9ydCBmb3IgdGhlIFZFU0EgRFBDRCBiYWNrbGlnaHQgaW50ZXJmYWNlIGRl c3BpdGUgdGhlIGZhY3QgaXQgZG9lc24ndAo+PiBzZWVtIHRvIHdvcmsuCj4+IAo+PiBOb3RlIHRo b3VnaCBJJ20gbm90IGVudGlyZWx5IGNsZWFyIG9uIHRoaXMgLSBvbiBvbmUgb2YgdGhlIG1hY2hp bmVzIHdoZXJlCj4+IHRoaXMgaXNzdWUgd2FzIG9ic2VydmVkLCBJIGFsc28gbm90aWNlZCB0aGF0 IHdlIGFwcGVhcmVkIHRvIGJlIHJlamVjdGluZwo+PiB0aGUgVkJUIGRlZmluZWQgYmFja2xpZ2h0 IGZyZXF1ZW5jeSBpbgo+PiBpbnRlbF9kcF9hdXhfdmVzYV9jYWxjX21heF9iYWNrbGlnaHQoKS4g SXQncyBub3RlZCBpbiB0aGlzIGZ1bmN0aW9uIHRoYXQ6Cj4+IAo+PiAvKiBVc2UgaGlnaGVzdCBw b3NzaWJsZSB2YWx1ZSBvZiBQbiBmb3IgbW9yZSBncmFudWxhcml0eSBvZiBicmlnaHRuZXNzCj4+ IMKgKiBhZGp1c3RtZW50IHdoaWxlIHNhdGlmeWluZyB0aGUgY29uZGl0aW9ucyBiZWxvdy4KPj4g wqAqIC4uLgo+PiDCoCogLSBGeFAgaXMgd2l0aGluIDI1JSBvZiBkZXNpcmVkIHZhbHVlLgo+PiDC oCrCoMKgIE5vdGU6IDI1JSBpcyBhcmJpdHJhcnkgdmFsdWUgYW5kIG1heSBuZWVkIHNvbWUgdHdl YWsuCj4+IMKgKi8KPj4gCj4+IFNvIGl0J3MgcG9zc2libGUgdGhhdCB0aGlzIHZhbHVlIG1pZ2h0 IGp1c3QgbmVlZCB0byBiZSB0d2Vha2VkLCBidXQgZm9yIG5vdwo+PiBsZXQncyBqdXN0IGRpc2Fi bGUgdGhlIFZFU0EgYmFja2xpZ2h0IGludGVyZmFjZSB1bmxlc3MgaXQncyBzcGVjaWZpZWQgaW4K Pj4gdGhlIFZCVCBqdXN0IHRvIGJlIHNhZmUuIFdlIG1pZ2h0IGJlIGFibGUgdG8gdHJ5IGVuYWJs aW5nIHRoaXMgYWdhaW4gYnkKPj4gZGVmYXVsdCBpbiB0aGUgZnV0dXJlLgo+PiAKPj4gRml4ZXM6 IDIyMjc4MTZlNjQ3YSAoImRybS9pOTE1L2RwOiBBbGxvdyBmb3JjaW5nIHNwZWNpZmljIGludGVy ZmFjZXMgdGhyb3VnaAo+PiBlbmFibGVfZHBjZF9iYWNrbGlnaHQiKQo+PiBDYzogSmFuaSBOaWt1 bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52 aXZpQGludGVsLmNvbT4KPj4gQnVnemlsbGE6IGh0dHBzOi8vZ2l0bGFiLmZyZWVkZXNrdG9wLm9y Zy9kcm0vaW50ZWwvLS9pc3N1ZXMvMzE2OQo+PiBTaWduZWQtb2ZmLWJ5OiBMeXVkZSBQYXVsIDxs eXVkZUByZWRoYXQuY29tPgo+PiAtLS0KPj4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5 L2ludGVsX2RwX2F1eF9iYWNrbGlnaHQuYyB8IDEgLQo+PiDCoDEgZmlsZSBjaGFuZ2VkLCAxIGRl bGV0aW9uKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxh eS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw bGF5L2ludGVsX2RwX2F1eF9iYWNrbGlnaHQuYwo+PiBpbmRleCA2NTE4ODQzOTAxMzcuLjRmODMz N2M3ZmQyZSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9kcF9hdXhfYmFja2xpZ2h0LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxh eS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPj4gQEAgLTY0Niw3ICs2NDYsNiBAQCBpbnQgaW50 ZWxfZHBfYXV4X2luaXRfYmFja2xpZ2h0X2Z1bmNzKHN0cnVjdAo+PiBpbnRlbF9jb25uZWN0b3Ig KmNvbm5lY3RvcikKPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgYnJlYWs7Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgY2FzZSBJTlRF TF9CQUNLTElHSFRfRElTUExBWV9EREk6Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoHRyeV9pbnRlbF9pbnRlcmZhY2UgPSB0cnVlOwo+PiAtwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHRyeV92ZXNhX2ludGVyZmFj ZSA9IHRydWU7Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoGJyZWFrOwo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGRlZmF1bHQ6Cj4+ IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiAt RU5PREVWOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50 ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC24DC433E1 for ; Tue, 23 Mar 2021 14:07:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F8DD6199F for ; Tue, 23 Mar 2021 14:07:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F8DD6199F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5AA2D6E8C3; Tue, 23 Mar 2021 14:07:17 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 367BE6E8A0; Tue, 23 Mar 2021 14:07:16 +0000 (UTC) IronPort-SDR: hp+iLZf4Jb1pGIs0Yo9ZSr5FeIF3euV+XYdvE5nZMxNty3TnTkt/yJS2JVq5/zL/WJGlBwOXgO osND/Gd6lfzw== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="187164567" X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="187164567" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 07:07:15 -0700 IronPort-SDR: OgCpjYysMewcIG7T/5T0gGkytTxkwKdQzZxfWA+o+XkeIOGiAR9CjOmP4KM7hy9ER20JHM2jeu T502Uf/10h2w== X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="414998948" Received: from wjlloyd-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.53.124]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 07:06:08 -0700 From: Jani Nikula To: lyude@redhat.com, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/i915/dpcd_bl: Don't try vesa interface unless specified by VBT In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210318170204.513000-1-lyude@redhat.com> Date: Tue, 23 Mar 2021 16:06:05 +0200 Message-ID: <87k0py3qya.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , open list , "open list:DRM DRIVERS" , Sean Paul , Rodrigo Vivi , Aaron Ma , Dave Airlie Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCAxOCBNYXIgMjAyMSwgTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4gd3JvdGU6 Cj4gQWN0dWFsbHktTkFLIHRoaXMuIEkganVzdCByZWFsaXplZCBJJ3ZlIGJlZW4gbWlzcmVhZGlu ZyB0aGUgYnVnIGFuZCB0aGF0IHRoaXMKPiBkb2Vzbid0IGFjdHVhbGx5IHNlZW0gdG8gYmUgZml4 ZWQuIFdpbGwgcmVzZW5kIG9uY2UgSSBmaWd1cmUgb3V0IHdoYXQncyBnb2luZyBvbgoKV2VsbCwg SSB0aGluayB0aGVyZSBhcmUgYWN0dWFsbHkgbXVsdGlwbGUgaXNzdWVzIG9uIG11bHRpcGxlCm1h Y2hpbmVzLiBUaGlzIGZpeGVzIHRoZSBpc3N1ZSBvbiBUaGlua1BhZCBYMSBUaXRhbml1bSBHZW4x IFsxXS4KCkkgc3VzcGVjdCByZXZlcnRpbmcgOThlNDk3ZTIwM2E1ICgiZHJtL2k5MTUvZHBjZF9i bDogdW5jaGVjayBQV01fUElOX0NBUAp3aGVuIGRldGVjdCBlRFAgYmFja2xpZ2h0IGNhcGFiaWxp dGllcyIpIHdvdWxkIHRvby4gQnV0IHRoZW4gdGhhdCB3b3VsZApicmVhayAqb3RoZXIqIG1hY2hp bmVzIHRoYXQgY2xhaW0gc3VwcG9ydCBmb3IgKmJvdGgqIGVEUCBQV00gcGluIGFuZApEUENEIGJh Y2tsaWdodCBjb250cm9sLCBJIHRoaW5rLgoKSSB0aGluayB0aGVyZSBhcmUgaXNzdWVzIHdpdGgg aG93IHdlIHRyeSBzZXR1cCBEUENEIGJhY2tsaWdodCBpZiB0aGUgR09QCmhhcyBzZXQgdXAgUFdN IGJhY2tsaWdodC4gRm9yIGV4YW1wbGUsIHdlIGRvbid0IHNldCB0aGUgYmFja2xpZ2h0CmNvbnRy b2wgbW9kZSBjb3JyZWN0bHkgdW50aWwgdGhlIG5leHQgZGlzYWJsZS9lbmFibGUgc2VxdWVuY2Uu IEhvd2V2ZXIsCkkgdHJpZWQgdG8gZml4IHRoaXMsIGFuZCBJIHRoaW5rIEkgd2FzIGRvaW5nIGFs bCB0aGUgcmlnaHQgdGhpbmdzLCBhbmQKRFBDRCByZWFkcyBzZWVtZWQgdG8gY29uZmlybSB0aGlz LCB5ZXQgSSB3YXMgbm90IGFibGUgdG8gY29udHJvbApicmlnaHRuZXNzIHVzaW5nIERQQ0QuIEkg ZG9uJ3Qga25vdyB3aGF0IGdpdmVzLCBidXQgSSBkbyBrbm93IGVEUCBQV00KcGluIGNvbnRyb2wg d29ya3MuCgoKQlIsCkphbmkuCgoKWzFdIGh0dHBzOi8vZ2l0bGFiLmZyZWVkZXNrdG9wLm9yZy9k cm0vaW50ZWwvLS9pc3N1ZXMvMzE1OAoKCj4KPiBPbiBUaHUsIDIwMjEtMDMtMTggYXQgMTM6MDIg LTA0MDAsIEx5dWRlIFBhdWwgd3JvdGU6Cj4+IExvb2tzIGxpa2UgdGhhdCB0aGVyZSBhY3R1YWxs eSBhcmUgYW5vdGhlciBzdWJzZXQgb2YgbGFwdG9wcyBvbiB0aGUgbWFya2V0Cj4+IHRoYXQgZG9u J3Qgc3VwcG9ydCB0aGUgSW50ZWwgSERSIGJhY2tsaWdodCBpbnRlcmZhY2UsIGJ1dCBkbyBhZHZl cnRpc2UKPj4gc3VwcG9ydCBmb3IgdGhlIFZFU0EgRFBDRCBiYWNrbGlnaHQgaW50ZXJmYWNlIGRl c3BpdGUgdGhlIGZhY3QgaXQgZG9lc24ndAo+PiBzZWVtIHRvIHdvcmsuCj4+IAo+PiBOb3RlIHRo b3VnaCBJJ20gbm90IGVudGlyZWx5IGNsZWFyIG9uIHRoaXMgLSBvbiBvbmUgb2YgdGhlIG1hY2hp bmVzIHdoZXJlCj4+IHRoaXMgaXNzdWUgd2FzIG9ic2VydmVkLCBJIGFsc28gbm90aWNlZCB0aGF0 IHdlIGFwcGVhcmVkIHRvIGJlIHJlamVjdGluZwo+PiB0aGUgVkJUIGRlZmluZWQgYmFja2xpZ2h0 IGZyZXF1ZW5jeSBpbgo+PiBpbnRlbF9kcF9hdXhfdmVzYV9jYWxjX21heF9iYWNrbGlnaHQoKS4g SXQncyBub3RlZCBpbiB0aGlzIGZ1bmN0aW9uIHRoYXQ6Cj4+IAo+PiAvKiBVc2UgaGlnaGVzdCBw b3NzaWJsZSB2YWx1ZSBvZiBQbiBmb3IgbW9yZSBncmFudWxhcml0eSBvZiBicmlnaHRuZXNzCj4+ IMKgKiBhZGp1c3RtZW50IHdoaWxlIHNhdGlmeWluZyB0aGUgY29uZGl0aW9ucyBiZWxvdy4KPj4g wqAqIC4uLgo+PiDCoCogLSBGeFAgaXMgd2l0aGluIDI1JSBvZiBkZXNpcmVkIHZhbHVlLgo+PiDC oCrCoMKgIE5vdGU6IDI1JSBpcyBhcmJpdHJhcnkgdmFsdWUgYW5kIG1heSBuZWVkIHNvbWUgdHdl YWsuCj4+IMKgKi8KPj4gCj4+IFNvIGl0J3MgcG9zc2libGUgdGhhdCB0aGlzIHZhbHVlIG1pZ2h0 IGp1c3QgbmVlZCB0byBiZSB0d2Vha2VkLCBidXQgZm9yIG5vdwo+PiBsZXQncyBqdXN0IGRpc2Fi bGUgdGhlIFZFU0EgYmFja2xpZ2h0IGludGVyZmFjZSB1bmxlc3MgaXQncyBzcGVjaWZpZWQgaW4K Pj4gdGhlIFZCVCBqdXN0IHRvIGJlIHNhZmUuIFdlIG1pZ2h0IGJlIGFibGUgdG8gdHJ5IGVuYWJs aW5nIHRoaXMgYWdhaW4gYnkKPj4gZGVmYXVsdCBpbiB0aGUgZnV0dXJlLgo+PiAKPj4gRml4ZXM6 IDIyMjc4MTZlNjQ3YSAoImRybS9pOTE1L2RwOiBBbGxvdyBmb3JjaW5nIHNwZWNpZmljIGludGVy ZmFjZXMgdGhyb3VnaAo+PiBlbmFibGVfZHBjZF9iYWNrbGlnaHQiKQo+PiBDYzogSmFuaSBOaWt1 bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52 aXZpQGludGVsLmNvbT4KPj4gQnVnemlsbGE6IGh0dHBzOi8vZ2l0bGFiLmZyZWVkZXNrdG9wLm9y Zy9kcm0vaW50ZWwvLS9pc3N1ZXMvMzE2OQo+PiBTaWduZWQtb2ZmLWJ5OiBMeXVkZSBQYXVsIDxs eXVkZUByZWRoYXQuY29tPgo+PiAtLS0KPj4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5 L2ludGVsX2RwX2F1eF9iYWNrbGlnaHQuYyB8IDEgLQo+PiDCoDEgZmlsZSBjaGFuZ2VkLCAxIGRl bGV0aW9uKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxh eS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw bGF5L2ludGVsX2RwX2F1eF9iYWNrbGlnaHQuYwo+PiBpbmRleCA2NTE4ODQzOTAxMzcuLjRmODMz N2M3ZmQyZSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9kcF9hdXhfYmFja2xpZ2h0LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxh eS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPj4gQEAgLTY0Niw3ICs2NDYsNiBAQCBpbnQgaW50 ZWxfZHBfYXV4X2luaXRfYmFja2xpZ2h0X2Z1bmNzKHN0cnVjdAo+PiBpbnRlbF9jb25uZWN0b3Ig KmNvbm5lY3RvcikKPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgYnJlYWs7Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgY2FzZSBJTlRF TF9CQUNLTElHSFRfRElTUExBWV9EREk6Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoHRyeV9pbnRlbF9pbnRlcmZhY2UgPSB0cnVlOwo+PiAtwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHRyeV92ZXNhX2ludGVyZmFj ZSA9IHRydWU7Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoGJyZWFrOwo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGRlZmF1bHQ6Cj4+ IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiAt RU5PREVWOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50 ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEB7CC433E2 for ; Tue, 23 Mar 2021 14:06:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F1E2619C0 for ; Tue, 23 Mar 2021 14:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232141AbhCWOGW convert rfc822-to-8bit (ORCPT ); Tue, 23 Mar 2021 10:06:22 -0400 Received: from mga14.intel.com ([192.55.52.115]:44770 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232158AbhCWOGN (ORCPT ); Tue, 23 Mar 2021 10:06:13 -0400 IronPort-SDR: 46nylmF01wxZhGJfMmOb9TvHP9mipiLaU3egVVxEARU0sKt4nF5Tdsw9YsWNU1IhRMsfQpRJCx QPSij6jLbspg== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="189882787" X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="189882787" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 07:06:12 -0700 IronPort-SDR: OgCpjYysMewcIG7T/5T0gGkytTxkwKdQzZxfWA+o+XkeIOGiAR9CjOmP4KM7hy9ER20JHM2jeu T502Uf/10h2w== X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="414998948" Received: from wjlloyd-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.53.124]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 07:06:08 -0700 From: Jani Nikula To: lyude@redhat.com, intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi , Joonas Lahtinen , David Airlie , Daniel Vetter , Sean Paul , Aaron Ma , Dave Airlie , "open list\:DRM DRIVERS" , open list Subject: Re: [PATCH] drm/i915/dpcd_bl: Don't try vesa interface unless specified by VBT In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210318170204.513000-1-lyude@redhat.com> Date: Tue, 23 Mar 2021 16:06:05 +0200 Message-ID: <87k0py3qya.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Mar 2021, Lyude Paul wrote: > Actually-NAK this. I just realized I've been misreading the bug and that this > doesn't actually seem to be fixed. Will resend once I figure out what's going on Well, I think there are actually multiple issues on multiple machines. This fixes the issue on ThinkPad X1 Titanium Gen1 [1]. I suspect reverting 98e497e203a5 ("drm/i915/dpcd_bl: uncheck PWM_PIN_CAP when detect eDP backlight capabilities") would too. But then that would break *other* machines that claim support for *both* eDP PWM pin and DPCD backlight control, I think. I think there are issues with how we try setup DPCD backlight if the GOP has set up PWM backlight. For example, we don't set the backlight control mode correctly until the next disable/enable sequence. However, I tried to fix this, and I think I was doing all the right things, and DPCD reads seemed to confirm this, yet I was not able to control brightness using DPCD. I don't know what gives, but I do know eDP PWM pin control works. BR, Jani. [1] https://gitlab.freedesktop.org/drm/intel/-/issues/3158 > > On Thu, 2021-03-18 at 13:02 -0400, Lyude Paul wrote: >> Looks like that there actually are another subset of laptops on the market >> that don't support the Intel HDR backlight interface, but do advertise >> support for the VESA DPCD backlight interface despite the fact it doesn't >> seem to work. >> >> Note though I'm not entirely clear on this - on one of the machines where >> this issue was observed, I also noticed that we appeared to be rejecting >> the VBT defined backlight frequency in >> intel_dp_aux_vesa_calc_max_backlight(). It's noted in this function that: >> >> /* Use highest possible value of Pn for more granularity of brightness >>  * adjustment while satifying the conditions below. >>  * ... >>  * - FxP is within 25% of desired value. >>  *   Note: 25% is arbitrary value and may need some tweak. >>  */ >> >> So it's possible that this value might just need to be tweaked, but for now >> let's just disable the VESA backlight interface unless it's specified in >> the VBT just to be safe. We might be able to try enabling this again by >> default in the future. >> >> Fixes: 2227816e647a ("drm/i915/dp: Allow forcing specific interfaces through >> enable_dpcd_backlight") >> Cc: Jani Nikula >> Cc: Rodrigo Vivi >> Bugzilla: https://gitlab.freedesktop.org/drm/intel/-/issues/3169 >> Signed-off-by: Lyude Paul >> --- >>  drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 1 - >>  1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c >> b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c >> index 651884390137..4f8337c7fd2e 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c >> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c >> @@ -646,7 +646,6 @@ int intel_dp_aux_init_backlight_funcs(struct >> intel_connector *connector) >>                         break; >>                 case INTEL_BACKLIGHT_DISPLAY_DDI: >>                         try_intel_interface = true; >> -                       try_vesa_interface = true; >>                         break; >>                 default: >>                         return -ENODEV; -- Jani Nikula, Intel Open Source Graphics Center