From: Markus Armbruster <armbru@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] monitor/qmp: Stop processing requests when shutdown is requested
Date: Mon, 15 Feb 2021 13:42:51 +0100 [thread overview]
Message-ID: <87k0r9y01g.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20210215122819.GL7226@merkur.fritz.box> (Kevin Wolf's message of "Mon, 15 Feb 2021 13:28:19 +0100")
Kevin Wolf <kwolf@redhat.com> writes:
> Am 15.02.2021 um 13:09 hat Markus Armbruster geschrieben:
>> Kevin Wolf <kwolf@redhat.com> writes:
>>
>> > monitor_qmp_dispatcher_co() used to check whether shutdown is requested
>>
>> "used to": until when?
>
> Until right before this patch. Do you prefer present tense to describe
> the old state?
I've done it both ways. I think present tense works better for me.
Case in point: I wasn't confident I read your commit message correctly,
so I asked.
> Also, does your Tested-by imply that you expect someone else to merge
> this series? I'm planning to send a pull request today, so if that was
> your intention, I can include it there.
I didn't mean to imply anything beyond "I ran my reproducer, and your
patches fix it."
I don't mind you including the fixes in your pull request. I also don't
mind doing a pull request for your fixes. Up to you!
next prev parent reply other threads:[~2021-02-15 12:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 17:20 [PATCH 0/2] monitor: Shutdown fixes Kevin Wolf
2021-02-12 17:20 ` [PATCH 1/2] monitor: Fix assertion failure on shutdown Kevin Wolf
2021-02-12 17:20 ` [PATCH 2/2] monitor/qmp: Stop processing requests when shutdown is requested Kevin Wolf
2021-02-15 12:09 ` Markus Armbruster
2021-02-15 12:28 ` Kevin Wolf
2021-02-15 12:42 ` Markus Armbruster [this message]
2021-02-15 13:58 ` Kevin Wolf
2021-02-15 14:22 ` Markus Armbruster
2021-02-15 12:16 ` [PATCH 0/2] monitor: Shutdown fixes Markus Armbruster
2021-02-15 12:44 ` Markus Armbruster
2021-06-29 9:14 ` Vladimir Sementsov-Ogievskiy
2021-07-06 15:32 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0r9y01g.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.