All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] utils/getdeveloperlib.py: reduce Cc: list based on package infras
Date: Thu, 11 Feb 2021 21:56:42 +0100	[thread overview]
Message-ID: <87k0reiar9.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20210210080136.2709779-1-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Wed, 10 Feb 2021 09:01:35 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > When a developer has package/pkg-<infra>.mk assigned to him/her in the
 > DEVELOPERS file, this has 3 implications:

 >  (1) Patches adding new packages using this infrastructure are Cc'ed
 >      to this developer. This is done by the analyze_patch() function,
 >      which matches the regexp r"^\+\$\(eval
 >      \$\((host-)?([^-]*)-package\)\)$" in the patch, i.e where an
 >      added line contains a reference to the infra maintained by the
 >      developer.

 >  (2) Patches touching the package/pkg-<infra>.mk file itself are Cc'ed
 >      to this developer.

 >  (3) Any patch touching a package using this infra are also Cc'ed to
 >      this developer.

 > Point (3) causes a significant amount of patches to be sent to
 > developers who have package/pkg-generic.mk and
 > package/pkg-autotools.mk assigned to them in the DEVELOPERS
 > file. Basically, all patches touching generic or autotools packages
 > get CC'ed to such developers, which causes a massive amount of patches
 > to be received.

 > So this patch adjusts the getdeveloperlib.py to drop point (3), but
 > preserves point (1) and (2). Indeed, it makes sense to be Cc'ed on new
 > package additions (to make a review that they use the package
 > infrastructure correctly), and it makes sense to be Cc'ed on patches
 > that touch the infrastructure code itself.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2020.02.x and 2020.11.x, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2021-02-11 20:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10  8:01 [Buildroot] [PATCH] utils/getdeveloperlib.py: reduce Cc: list based on package infras Thomas Petazzoni
2021-02-10 21:11 ` Yann E. MORIN
2021-02-11 20:56 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0reiar9.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.