From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E93C8C433DB for ; Wed, 27 Jan 2021 12:06:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5AC720789 for ; Wed, 27 Jan 2021 12:06:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237539AbhA0MGh (ORCPT ); Wed, 27 Jan 2021 07:06:37 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:55940 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237102AbhA0MEa (ORCPT ); Wed, 27 Jan 2021 07:04:30 -0500 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1611749027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=60DlocLh3R/JAb1KNLhb+H3bpgfRLVI+G5SZHUtePuk=; b=i5ghaZB5AF7HFjkEmiWc4OvCKIYXSaZ8cv62rAERZYpHkUspD5nhhDROkzUGVJFYnQt6BW W/lvhipoxp8ZpgUzfY0fFEnd0O+PeRDw1mjZs8oJVQ1BtGTfBRVCwyimXjvdOydo+JAYj+ aq5QskS5QG/cShkk9o78zuNirA+PFABfkvHR9qwSuFjRrTTDy4nVQpRgHiMPN6CElFT5Yl vuT0GdjI2EH3d2LrfCBjKtYYXi6RE12Ah8VNuZ/GnJEVzDne7rcGXyyxMmfWtkd009BxKO 1WlH9K+BnRPrG54vpSbQ8wTpzJaQPADib3ZM+Iz+A8UyjSFePsQXoICM9qwsag== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1611749027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=60DlocLh3R/JAb1KNLhb+H3bpgfRLVI+G5SZHUtePuk=; b=6wfla+p6f2NeTQiyZ8pSbK9b+PyvPJ2w0SVvBJOBuu1cM5wi5UHY5ADoNsvcrJes1fUOjQ tzQKzxXZwhgcyuDg== To: Adam Lackorzynski , maz@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linusw@kernel.org, kaloz@openwrt.org, khalasa@piap.pl, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com Subject: Re: [PATCH 6/6] x86/ioapic: Fix return check of __irq_domain_alloc_irqs In-Reply-To: <20210102175859.335447-6-adam@l4re.org> References: <20210102175859.335447-1-adam@l4re.org> <20210102175859.335447-6-adam@l4re.org> Date: Wed, 27 Jan 2021 13:03:46 +0100 Message-ID: <87k0ryfuxp.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, Jan 02 2021 at 18:58, Adam Lackorzynski wrote: > 0 is not a proper IRQ number and also indicates failure. > Also check for this case in upwards functions. 0 is a valid irq number for historical reasons on x86. So no. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEBEEC433E0 for ; Wed, 27 Jan 2021 12:05:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FE6F20784 for ; Wed, 27 Jan 2021 12:05:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FE6F20784 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MLMT/X4+Cr6ZBGCHnmNBCiplg8Tey0CD15YH6ZH8weo=; b=3O6vhmNV+QOHDzUT+jqne9gXL RNuRygYLm4ZDa2aL3e6fHC+Z9ei7b9N0xaSyvfMK6wgBKZEXzQTQfmWYOcDZGGmiJRF/GpgbaYdM+ +87vn8bYIFkLafIuh1yGOzfzq1wGM3spKeiYMqgoTU/2XXSOaDFnthdsDYHDVNUqG4jY8KmbynPk7 BB/Md4fCnh6B19KJvH/g6bTbbvGdQPt1W5cbx1uNd2OZH03cdFQ3xSuQO7g3gfeYsaiioRGlR44Yg GV4BQ5VvjQzmJ/B2qzcvpuaG0AnKU6INQ0ZPN6Qj6BzMYlbsOmqwl2kEnHGlbMQ6NXqf4PlqMSI1z OlSPwbn6A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4jYA-0004SE-MA; Wed, 27 Jan 2021 12:03:54 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4jY7-0004QG-M2 for linux-arm-kernel@lists.infradead.org; Wed, 27 Jan 2021 12:03:52 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1611749027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=60DlocLh3R/JAb1KNLhb+H3bpgfRLVI+G5SZHUtePuk=; b=i5ghaZB5AF7HFjkEmiWc4OvCKIYXSaZ8cv62rAERZYpHkUspD5nhhDROkzUGVJFYnQt6BW W/lvhipoxp8ZpgUzfY0fFEnd0O+PeRDw1mjZs8oJVQ1BtGTfBRVCwyimXjvdOydo+JAYj+ aq5QskS5QG/cShkk9o78zuNirA+PFABfkvHR9qwSuFjRrTTDy4nVQpRgHiMPN6CElFT5Yl vuT0GdjI2EH3d2LrfCBjKtYYXi6RE12Ah8VNuZ/GnJEVzDne7rcGXyyxMmfWtkd009BxKO 1WlH9K+BnRPrG54vpSbQ8wTpzJaQPADib3ZM+Iz+A8UyjSFePsQXoICM9qwsag== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1611749027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=60DlocLh3R/JAb1KNLhb+H3bpgfRLVI+G5SZHUtePuk=; b=6wfla+p6f2NeTQiyZ8pSbK9b+PyvPJ2w0SVvBJOBuu1cM5wi5UHY5ADoNsvcrJes1fUOjQ tzQKzxXZwhgcyuDg== To: Adam Lackorzynski , maz@kernel.org Subject: Re: [PATCH 6/6] x86/ioapic: Fix return check of __irq_domain_alloc_irqs In-Reply-To: <20210102175859.335447-6-adam@l4re.org> References: <20210102175859.335447-1-adam@l4re.org> <20210102175859.335447-6-adam@l4re.org> Date: Wed, 27 Jan 2021 13:03:46 +0100 Message-ID: <87k0ryfuxp.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_070351_850616_D4ED50D0 X-CRM114-Status: UNSURE ( 6.36 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, bgolaszewski@baylibre.com, linusw@kernel.org, linux-gpio@vger.kernel.org, khalasa@piap.pl, kaloz@openwrt.org, gregory.clement@bootlin.com, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jan 02 2021 at 18:58, Adam Lackorzynski wrote: > 0 is not a proper IRQ number and also indicates failure. > Also check for this case in upwards functions. 0 is a valid irq number for historical reasons on x86. So no. Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel