All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: John Snow <jsnow@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: QMP and the 'id' parameter
Date: Tue, 10 Nov 2020 11:27:26 +0100	[thread overview]
Message-ID: <87k0utwlpt.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20201110091512.GA866671@redhat.com> ("Daniel P. Berrangé"'s message of "Tue, 10 Nov 2020 09:15:12 +0000")

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Tue, Nov 10, 2020 at 07:22:26AM +0100, Markus Armbruster wrote:
[...]
>> Command responses get sent strictly in order (even parse errors), except
>> for commands executed out-of-band.
>
> With out of band commands, how much runs in the background ? Is the
> JSON parsing still in the foreground, such that we can expect that
> even for OOB commands, a error response without a "id" is still
> received strictly in order.

Yes, you can.  We made sure both errors and results flow through the
same pipeline[*].  The only fork is for OOB commands, and to take it,
the parser must have yielded a JSON object.

Use of exec-oob without "id" is foolish.

Pipelining commands without "id" is merely unadvisable.


[*] We queue parse errors along with successfully parsed values.
The QMP dispatcher dequeues, executes if it's a request, sends the
response, loop.



  reply	other threads:[~2020-11-10 10:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10  1:47 QMP and the 'id' parameter John Snow
2020-11-10  6:22 ` Markus Armbruster
2020-11-10  9:15   ` Daniel P. Berrangé
2020-11-10 10:27     ` Markus Armbruster [this message]
2020-11-10 16:32   ` John Snow
2020-11-11  8:27     ` Markus Armbruster
2020-11-20  0:22       ` John Snow
2020-11-20 10:25         ` Markus Armbruster
2020-11-20 16:49           ` John Snow
2020-11-23  6:57             ` Markus Armbruster
2020-11-30 18:32               ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0utwlpt.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.